Foodsoft/foodsoft
1
1
Fork 0
Code Issues 36 Pull requests 5 Projects 1 Releases Wiki Activity

fix: add null checks for articles convert_units

Browse source 
Prevents division by zero exception because of a unit beeing 0.
A Unit becomes also zero e.g. when a comma symbol is used Unit.new("0,9kg") == 0

fixes #1014
This commit is contained in:
Philipp Rothmann 2023-06-22 22:45:21 +02:00
parent 45e2668cea
commit 33034e66b8
2 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/models/article.rb
View file

@ -211,7 +211,7 @@ class Article < ApplicationRecord
rescue StandardError
nil
end
if fc_unit && supplier_unit && fc_unit =~ supplier_unit
if fc_unit != 0 && supplier_unit != 0 && fc_unit && supplier_unit && fc_unit =~ supplier_unit
conversion_factor = (supplier_unit / fc_unit).to_base.to_r
new_price = new_article.price / conversion_factor
new_unit_quantity = new_article.unit_quantity * conversion_factor