Foodsoft/foodsoft
1
1
Fork 0
Code Issues 36 Pull requests 5 Projects 1 Releases Wiki Activity

Remove protected_attributes gem

Browse source 
We do not enforce the rules, so removing it and switching the existing
annotations to strong_parameters does not make our situation worse.
This commit is contained in:
Patrick Gansterer 2019-10-29 15:16:43 +01:00
parent 9fc51bdce8
commit 39aff78f11
8 changed files with 32 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

12
app/controllers/tasks_controller.rb
View file

@ -17,7 +17,7 @@ class TasksController < ApplicationController
end
def create
@task = Task.new(params[:task])
@task = Task.new(task_params, current_user_id: current_user.id)
if params[:periodic]
@task.periodic_task_group = PeriodicTaskGroup.new
end
@ -44,6 +44,7 @@ class TasksController < ApplicationController
task_group = @task.periodic_task_group
was_periodic = @task.periodic?
prev_due_date = @task.due_date
@task.current_user_id = current_user.id
@task.attributes=(params[:task])
if @task.errors.empty? && @task.save
task_group.update_tasks_including(@task, prev_due_date) if params[:periodic]
@ -111,4 +112,13 @@ class TasksController < ApplicationController
redirect_to tasks_url, :alert => I18n.t('tasks.error_not_found')
end
end
private
def task_params
params
.require(:task)
.permit(:name, :description, :duration, :user_list, :required_users, :workgroup, :due_date, :done)
end
end