fix order bug

This commit is contained in:
wvengen 2014-05-06 10:51:45 +02:00
parent 3953c21ae2
commit 3a41e9530f
5 changed files with 6 additions and 6 deletions

View file

@ -13,7 +13,7 @@ class GroupOrderArticle < ActiveRecord::Base
validates_inclusion_of :tolerance, :in => 0..99
validates_uniqueness_of :order_article_id, :scope => :group_order_id # just once an article per group order
scope :ordered, -> { includes(:group_order => :ordergroup).order(:groups => :name) }
scope :ordered, -> { includes(:group_order => :ordergroup).order('groups.name') }
localize_input_of :result

View file

@ -46,7 +46,7 @@ class Order < ActiveRecord::Base
# make sure to include those articles which are no longer available
# but which have already been ordered in this stock order
StockArticle.available.includes(:article_category).
order('article_categories.name, articles.name').reject{ |a|
order('article_categories.name', 'articles.name').reject{ |a|
a.quantity_available <= 0 and not a.ordered_in_order?(self)
}.group_by { |a| a.article_category.name }
else

View file

@ -65,9 +65,9 @@ class User < ActiveRecord::Base
def self.natural_order
# would be sensible to match ApplicationController#show_user
if FoodsoftConfig[:use_nick]
order('nick ASC')
order('nick')
else
order('first_name ASC, last_name ASC')
order('first_name', 'last_name')
end
end

View file

@ -3,7 +3,7 @@ class Workgroup < Group
has_many :tasks
# returns all non-finished tasks
has_many :open_tasks, -> { where(:done => false).order('due_date ASC, name ASC') }, :class_name => 'Task'
has_many :open_tasks, -> { where(:done => false).order('due_date', 'name') }, :class_name => 'Task'
validates_uniqueness_of :name
validate :last_admin_on_earth, :on => :update