better readable IBAN (#824)

display IBANs in groups of 4 digits with whitespaces in between

app/helpers/application_helper.rb

@@ -25,6 +25,11 @@ module ApplicationHelper
     content_tag :span, number_to_currency(amount), class: class_name
   end
 
+  # Splits an IBAN into groups of 4 digits displayed with margins in between
+  def format_iban(iban)
+    iban.scan(/..?.?.?/).map{ |item| content_tag(:span, item, style: "margin-right: 0.5em;") }.join.html_safe
+  end
+
   # Creates ajax-controlled-links for pagination
   def pagination_links_remote(collection, options = {})
     per_page = options[:per_page] || @per_page

app/views/admin/finances/_bank_accounts.html.haml

@@ -9,7 +9,7 @@
     - @bank_accounts.each do |bank_account|
       %tr
         %td= bank_account.name
-        %td= bank_account.iban
+        %td= format_iban bank_account.iban
         %td= truncate bank_account.description, length: 50
         %td
           = link_to t('ui.edit'), edit_admin_bank_account_path(bank_account), remote: true, class: 'btn btn-mini'

app/views/finance/bank_accounts/index.html.haml

@@ -11,6 +11,6 @@
     - for account in @bank_accounts
       %tr
         %td= link_to account.name, finance_bank_account_transactions_path(account)
-        %td= account.iban
+        %td= format_iban account.iban
         %td= truncate account.description, length: 50
         %td.numeric{style: 'width:5em'}= format_currency account.balance

app/views/finance/bank_transactions/show.html.haml

@@ -10,7 +10,7 @@
 - if @bank_transaction.iban?
   %p
     %b= heading_helper(BankTransaction, :iban) + ':'
-    = @bank_transaction.iban
+    = format_iban @bank_transaction.iban
     - if user = @bank_transaction.user
       = t('.belongs_to_user')
       = user.display

app/views/finance/invoices/unpaid.html.haml

@@ -23,7 +23,7 @@
     %p
       - if supplier.iban.present?
         %b= heading_helper(Supplier, :iban) + ':'
-        = supplier.iban
+        = format_iban supplier.iban
         %br/
       %b= t('.invoices_text') + ':'
       = invoices_text.join(', ')

app/views/home/reference_calculator.haml

@@ -73,4 +73,4 @@
       = t('.text1')
       %b.reference= '?'
       = t('.text2')
-      %b= ba.iban
+      %b= format_iban ba.iban

app/views/suppliers/show.html.haml

@@ -34,7 +34,7 @@
         %dd= @supplier.supplier_category.try(:name)
       - if FoodsoftConfig[:use_iban]
         %dt= heading_helper(Supplier, :iban) + ':'
-        %dd= @supplier.iban
+        %dd= format_iban @supplier.iban
       %dt= heading_helper(Supplier, :delivery_days) + ':'
       %dd= @supplier.delivery_days
       %dt= heading_helper(Supplier, :order_howto) + ':'