add specs

spec/factories/group_order.rb

@@ -5,5 +5,6 @@ FactoryBot.define do
   factory :group_order do
     ordergroup { create(:user, groups: [FactoryBot.create(:ordergroup)]).ordergroup }
     updated_by { create(:user) }
+    order
   end
 end

spec/factories/multi_group_order.rb

@@ -0,0 +1,8 @@
+require 'factory_bot'
+
+FactoryBot.define do
+  factory :multi_group_order do
+    group_orders { [create(:group_order)] }
+    association :multi_order
+  end
+end

spec/factories/multi_order.rb

@@ -0,0 +1,21 @@
+require 'factory_bot'
+
+FactoryBot.define do
+  factory :multi_order do
+    transient do
+      orders { [create(:order, state: 'closed')] }
+    end
+
+    after(:build) do |multi_order, evaluator|
+      # Assign orders before validation so custom validations can see them
+      multi_order.orders = evaluator.orders
+    end
+
+    after(:create) do |multi_order, _evaluator|
+      # Persist the relationship by updating the orders (if needed)
+      multi_order.orders.each do |order|
+        order.update!(multi_order: multi_order)
+      end
+    end
+  end
+end

spec/factories/ordergroup_invoice.rb

@@ -0,0 +1,8 @@
+require 'factory_bot'
+
+FactoryBot.define do
+  factory :ordergroup_invoice do
+    multi_group_order { create :multi_group_order }
+    after(:build) { |ogi| ogi.init }
+  end
+end

spec/integration/multi_order_spec.rb

@@ -0,0 +1,82 @@
+require_relative '../spec_helper'
+
+feature MultiOrder, type: :feature, js: true do
+  let(:admin) { create :user, groups: [create(:workgroup, role_finance: true), create(:ordergroup, name: "AdminOrders")] }
+  let(:user) { create :user, groups: [create(:ordergroup)] }
+
+  let(:article) { create :article, unit_quantity: 4 }
+  let(:article1) { create :article, unit_quantity: 2 }
+  let(:order) { create :order, supplier: article.supplier, article_ids: [article.id], ends: Time.now } 
+  let(:order1) { create :order, supplier: article1.supplier, article_ids: [article1.id], ends: Time.now } 
+
+  let(:go) { create :group_order, order: order, ordergroup: user.ordergroup}
+  let(:go1) { create :group_order, order: order1, ordergroup: admin.ordergroup}
+
+  let(:oa) { order.order_articles.find_by_article_id(article.id) }
+  let(:oa1) { order1.order_articles.find_by_article_id(article1.id) }
+  let(:ftt) { create :financial_transaction_type }
+
+  let(:goa) { create :group_order_article, group_order: go, order_article: oa }
+  let(:goa1) { create :group_order_article, group_order: go1, order_article: oa1 }
+
+  include ActiveJob::TestHelper
+
+  before do
+    login admin
+    goa.update_quantities 2, 0
+    goa1.update_quantities 2, 0
+    oa.update_results!
+    oa1.update_results!
+    FoodsoftConfig[:contact][:tax_number] = 12_345_678
+    order.update!(state: 'closed')
+    order1.update!(state: 'closed')
+  end
+
+  after { clear_enqueued_jobs }
+
+  # first ensure theres multiple orders and the check box to combine them to a multiorder
+
+  it 'shows the elements to combine orders' do
+    visit finance_order_index_path
+    expect(page).to have_css("#order_#{order.id}_combine")
+    expect(page).to have_css("#order_#{order1.id}_combine")
+    expect(page).to have_css(".merge-orders-btn")
+  end
+
+  it 'cannot combine orders when orders are not closed' do
+    order.update!(state: 'finished')
+    visit finance_order_index_path
+    expect(page).to have_css("#order_#{order.id}_combine")
+    expect(page).to have_css("#order_#{order1.id}_combine")
+    expect(page).to have_css(".merge-orders-btn")
+    # check the checkboxes and click the button
+    check("order_#{order.id}_combine")
+    check("order_#{order1.id}_combine")
+    click_link_or_button 'Zusammenführen'
+    expect(page).to have_content('Die Bestellung ist bereits Teil einer Multi-Bestellung oder ist noch nicht abgeschlossen.')
+  end
+
+  it 'cannot combine orders when group_orders already have an invoice' do
+    group_order_invoice = create(:group_order_invoice, group_order: go)
+    visit finance_order_index_path
+    expect(page).to have_css("#order_#{order.id}_combine")
+    expect(page).to have_css("#order_#{order1.id}_combine")
+    expect(page).to have_css(".merge-orders-btn")
+    # check the checkboxes and click the button
+    check("order_#{order.id}_combine")
+    check("order_#{order1.id}_combine")
+    click_link_or_button 'Zusammenführen'
+    expect(page).to have_content('Zusammenführen nicht möglich. Es gibt bereits Rechnungen für einige der Bestellgruppen.')
+  end
+
+  it 'combines orders into multi_order' do
+    visit finance_order_index_path
+    expect(MultiOrder.count).to eq(0)
+    check("order_#{order.id}_combine")
+    check("order_#{order1.id}_combine")
+    click_link_or_button 'Zusammenführen'
+    sleep 2
+    expect(page).to have_content("Multi Bestellung für #{MultiOrder.last.name} erstellt")
+    expect(MultiOrder.count).to eq(1)
+  end
+end

spec/integration/ordergroup_invoice_spec.rb

@@ -0,0 +1,131 @@
+require_relative '../spec_helper'
+
+feature OrdergroupInvoice, type: :feature, js: true do
+  let(:admin) { create :user, groups: [create(:workgroup, role_finance: true), create(:ordergroup, name: "AdminOrders")] }
+  let(:user) { create :user, groups: [create(:ordergroup)] }
+
+  let(:article) { create :article, unit_quantity: 4 }
+  let(:article1) { create :article, unit_quantity: 2 }
+  let(:order) { create :order, supplier: article.supplier, article_ids: [article.id], ends: Time.now } 
+  let(:order1) { create :order, supplier: article1.supplier, article_ids: [article1.id], ends: Time.now } 
+
+  let(:go) { create :group_order, order: order, ordergroup: user.ordergroup}
+  let(:go1) { create :group_order, order: order1, ordergroup: admin.ordergroup}
+
+  let(:oa) { order.order_articles.find_by_article_id(article.id) }
+  let(:oa1) { order1.order_articles.find_by_article_id(article1.id) }
+  let(:ftt) { create :financial_transaction_type }
+
+  let(:goa) { create :group_order_article, group_order: go, order_article: oa }
+  let(:goa1) { create :group_order_article, group_order: go1, order_article: oa1 }
+
+  include ActiveJob::TestHelper
+
+  before do
+    login admin
+    goa.update_quantities 2, 0
+    goa1.update_quantities 2, 0
+    oa.update_results!
+    oa1.update_results!
+    FoodsoftConfig[:contact][:tax_number] = 12_345_678
+    order.update!(state: 'closed')
+    order1.update!(state: 'closed')
+  end
+
+  after { clear_enqueued_jobs }
+
+  # first ensure theres multiple orders and the check box to combine them to a multiorder
+
+  it 'shows the elements to combine orders' do
+    visit finance_order_index_path
+    expect(page).to have_css("#order_#{order.id}_combine")
+    expect(page).to have_css("#order_#{order1.id}_combine")
+    expect(page).to have_css(".merge-orders-btn")
+  end
+
+  it 'cannot combine orders when orders are not closed' do
+    order.update!(state: 'finished')
+    visit finance_order_index_path
+    expect(page).to have_css("#order_#{order.id}_combine")
+    expect(page).to have_css("#order_#{order1.id}_combine")
+    expect(page).to have_css(".merge-orders-btn")
+    # check the checkboxes and click the button
+    check("order_#{order.id}_combine")
+    check("order_#{order1.id}_combine")
+    click_link_or_button 'Zusammenführen'
+    expect(page).to have_content('Die Bestellung ist bereits Teil einer Multi-Bestellung oder ist noch nicht abgeschlossen.')
+  end
+
+  it 'cannot combine orders when group_orders already have an invoice' do
+    group_order_invoice = create(:group_order_invoice, group_order: go)
+    visit finance_order_index_path
+    expect(page).to have_css("#order_#{order.id}_combine")
+    expect(page).to have_css("#order_#{order1.id}_combine")
+    expect(page).to have_css(".merge-orders-btn")
+    # check the checkboxes and click the button
+    check("order_#{order.id}_combine")
+    check("order_#{order1.id}_combine")
+    click_link_or_button 'Zusammenführen'
+    expect(page).to have_content('Zusammenführen nicht möglich. Es gibt bereits Rechnungen für einige der Bestellgruppen.')
+  end
+
+  it 'can generate multiple ordergroup invoice' do
+    multi_order = create(:multi_order, orders: [order, order1])
+    visit finance_order_index_path
+    expect(page).to have_selector(:link_or_button, "Multi Bestellung auflösen")
+    click_link_or_button 'Toggle details'
+    expect(page).to have_selector(:link_or_button, I18n.t('activerecord.attributes.group_order_invoice.links.generate_with_date'))
+    click_link_or_button I18n.t('activerecord.attributes.group_order_invoice.links.generate_with_date')
+    sleep 1
+    expect(OrdergroupInvoice.all.count).to eq(2)
+  end
+
+  it 'can generate single ordergroup invoice' do
+    multi_order = create(:multi_order, orders: [order, order1])
+    visit finance_order_index_path
+    expect(page).to have_selector(:link_or_button, "Multi Bestellung auflösen")
+    click_link_or_button 'Toggle details'
+    expect(page).to have_selector(:link_or_button, I18n.t('activerecord.attributes.group_order_invoice.links.generate'))
+    first(:link_or_button, I18n.t('activerecord.attributes.group_order_invoice.links.generate')).click
+    sleep 1
+    expect(OrdergroupInvoice.all.count).to eq(1)
+  end
+  it 'cannot toggel details when config wrong' do
+    FoodsoftConfig[:contact][:tax_number] = nil
+    multi_order = create(:multi_order, orders: [order, order1])
+    visit finance_order_index_path
+    expect(page).not_to have_selector(:link_or_button, 'Toggle details')
+  end
+  
+  it 'cannot destroy multi_order if invoice attached' do
+    multi_order = create(:multi_order, orders: [order, order1])
+    visit finance_order_index_path
+    expect(page).to have_selector(:link_or_button, "Multi Bestellung auflösen")
+    click_link_or_button 'Toggle details'
+    expect(page).to have_selector(:link_or_button, I18n.t('activerecord.attributes.group_order_invoice.links.generate'))
+    sleep 1
+    first(:link_or_button, I18n.t('activerecord.attributes.group_order_invoice.links.generate')).click
+    sleep 1
+    expect(OrdergroupInvoice.all.count).to eq(1)
+    click_link_or_button 'Multi Bestellung auflösen'
+    expect(page).to have_content("Lösche erst die Rechnungen")
+  end
+
+  it 'can toggle elements for ordergroup invoice' do
+    multi_order = create(:multi_order, orders: [order, order1])
+    visit finance_order_index_path
+    expect(page).to have_selector(:link_or_button, "Multi Bestellung auflösen")
+    click_link_or_button 'Toggle details'
+    expect(page).to have_selector(:link_or_button, I18n.t('activerecord.attributes.group_order_invoice.links.generate_with_date'))
+    click_link_or_button I18n.t('activerecord.attributes.group_order_invoice.links.generate_with_date')
+    sleep 1
+    expect(OrdergroupInvoice.all.count).to eq(2)
+    check("sepa_downloaded_all_multi_#{multi_order.id}")
+    sleep 1
+    expect(page).to have_checked_field("sepa_downloaded_multi_#{OrdergroupInvoice.last.id}")
+    expect(page).to have_checked_field("sepa_downloaded_multi_#{OrdergroupInvoice.first.id}")
+    check("paid_all_multi_#{multi_order.id}")
+    expect(page).to have_checked_field("paid_multi_#{OrdergroupInvoice.first.id}")
+    expect(page).to have_checked_field("paid_multi_#{OrdergroupInvoice.last.id}")
+  end
+end

spec/models/group_order_invoice_spec.rb

@@ -43,7 +43,7 @@ describe GroupOrderInvoice do
 
     it 'fails to create if group_order_id is used multiple times for creation' do
       expect(goi1.group_order.id).to eq(group_order.id)
-      expect { goi2 }.to raise_error(ActiveRecord::RecordNotUnique)
+      expect { goi2 }.to raise_error(ActiveRecord::RecordInvalid)
     end
 
     it 'creates two different group order invoice with different invoice_numbers' do

spec/models/multi_group_order_spec.rb

@@ -0,0 +1,31 @@
+require_relative '../spec_helper'
+describe MultiGroupOrder do
+  let(:admin) { create :user, groups: [create(:workgroup, role_finance: true), create(:ordergroup, name: "AdminOrders")] }
+  let(:user) { create :user, groups: [create(:ordergroup)] }
+  
+  let(:article1) { create :article, unit_quantity: 1 }
+  let(:article2) { create :article, unit_quantity: 3 }
+    
+  context 'does not generate Multi Group Order without valid multi_order' do
+    it 'when orders are not closed' do
+      order1 = create :order, multi_order: nil
+      order2 = create :order, multi_order: nil
+      group_order1 = create :group_order, ordergroup: user.ordergroup, order: order1
+      group_order2 = create :group_order, ordergroup: user.ordergroup, order: order2
+      expect { create(:multi_order, orders:[order1, order2]) }.to raise_error(ActiveRecord::RecordInvalid)
+      expect(MultiGroupOrder.count).to eq(0)
+    end
+  end
+  context 'Multi Group Order is created by MultiOrder' do
+    it 'when orders are closed' do
+      order1 = create :order, multi_order: nil
+      order2 = create :order, multi_order: nil
+      group_order1 = create :group_order, ordergroup: user.ordergroup, order: order1
+      group_order2 = create :group_order, ordergroup: user.ordergroup, order: order2
+      order1.update!(state: 'closed')
+      order2.update!(state: 'closed')
+      multi_order = create(:multi_order, orders: [order1, order2])
+      expect(MultiGroupOrder.count).to eq(1)
+    end
+  end
+end

spec/models/multi_order_spec.rb

@@ -0,0 +1,68 @@
+require_relative '../spec_helper'
+describe MultiOrder do
+  let(:admin) { create :user, groups: [create(:workgroup, role_finance: true), create(:ordergroup, name: "AdminOrders")] }
+  let(:user) { create :user, groups: [create(:ordergroup)] }
+
+  let(:article1) { create :article, unit_quantity: 1 }
+  let(:article2) { create :article, unit_quantity: 3 }
+
+  context 'does not generate Multi Order' do
+    let(:order1) { create :order }
+    let(:order2) { create :order}
+    let!(:group_order1) { create :group_order, ordergroup: user.ordergroup, order: order1 }
+    let!(:group_order2) { create :group_order, ordergroup: user.ordergroup, order: order2 }
+    let!(:group_order3) { create :group_order, ordergroup: admin.ordergroup, order: order1 }
+  
+    before do
+      order1.update!(state: 'open')
+      order2.update!(state: 'open')
+      FoodsoftConfig[:contact][:tax_number] = 123_457_8
+    end
+  
+    it 'when orders are not closed' do
+      expect { create(:multi_order, orders: [order1]) }.to raise_error(ActiveRecord::RecordInvalid)
+    end
+
+    it 'when orders are not finished' do
+      expect { create(:multi_order, orders: [order2]) }.to raise_error(ActiveRecord::RecordInvalid)
+    end
+
+    
+    it 'when group order invoices are present' do
+      order1.update!(state: 'closed')
+      order2.update!(state: 'closed')
+      group_order1.update!(group_order_invoice: create(:group_order_invoice))
+      group_order2.update!(group_order_invoice: create(:group_order_invoice))
+      expect { create(:multi_order, orders: [order1, order2]) }.to raise_error(ActiveRecord::RecordInvalid)
+    end
+  end
+
+  context 'generates Multi Order' do
+
+    let(:order3) { create :order, multi_order: nil }
+    let(:order4) { create :order, multi_order: nil }
+    let(:order5) { create :order, multi_order: nil }
+
+    let!(:group_order1) { create :group_order, ordergroup: user.ordergroup, order: order3 }
+    let!(:group_order2) { create :group_order, ordergroup: user.ordergroup, order: order4 }
+    let!(:group_order3) { create :group_order, ordergroup: admin.ordergroup, order: order5 }
+    let!(:group_order4) { create :group_order, ordergroup: admin.ordergroup, order: order4 }
+
+    before do
+      order3.update!(state: 'closed')
+      order4.update!(state: 'closed')
+      order5.update!(state: 'closed')
+    end
+
+    it 'when orders are closed' do
+      #as it is right now orders can be in multiple multi orders
+      # expect(create(:multi_order, orders: [order3])).to be_valid
+      expect(create(:multi_order, orders: [order3])).to be_valid
+    end
+
+    it 'when group order invoices are not present' do
+      multi_order2 = create(:multi_order, orders: [order3, order4])
+      expect(multi_order2).to be_valid
+    end
+  end
+end

spec/models/ordergroup_invoice_spec.rb

@@ -0,0 +1,60 @@
+require_relative '../spec_helper'
+
+describe OrdergroupInvoice do
+  # TODO: DO REAL TESTING!
+  let(:user) { create :user, groups: [create(:ordergroup)] }
+  let(:supplier) { create :supplier }
+  let(:article) { create :article, supplier: supplier }
+  let(:order) { create :order, state: 'closed' }
+  let(:group_order) { create :group_order, order: order, ordergroup: user.ordergroup }
+  let(:multi_group_order) { create :multi_group_order, multi_order: create(:multi_order, orders: [order]) }
+  
+  describe 'erroneous group order invoice' do
+    before do
+      order.update!(state: 'closed')
+    end
+    let(:ogi) do
+      build(:ordergroup_invoice, multi_group_order: multi_group_order).tap(&:init)
+    end    
+    it 'does not create group order invoice if tax_number not set' do
+      expect { ogi }.to raise_error(ActiveRecord::RecordInvalid, /.*/)
+    end
+  end
+
+  describe 'valid group order invoice' do
+    before do
+      FoodsoftConfig[:contact][:tax_number] = 123_457_8
+      order.update!(state: 'closed')
+    end
+    let(:multi_group_order1) { create :multi_group_order, multi_order: create(:multi_order, orders: [order]) }
+    let(:ogi) do
+      build(:ordergroup_invoice, multi_group_order: multi_group_order1).tap(&:init)
+    end
+    invoice_number1 = Time.now.strftime("%Y%m%d") + '0001'
+    invoice_number2 = Time.now.strftime("%Y%m%d") + '0002'
+
+    it 'creates group order invoice if tax_number is set' do
+      expect(ogi).to be_valid
+    end
+
+    it 'sets invoice_number according to date' do
+      number = Time.now.strftime("%Y%m%d") + '0001'
+      expect(odi1.invoice_number).to eq(number.to_i)
+    end
+
+    it 'fails to create if group_order_id is used multiple times for creation' do
+      expect(odi1.group_order.id).to eq(group_order.id)
+      expect { odi2 }.to raise_error(ActiveRecord::RecordInvalid)
+    end
+
+    it 'creates two different group order invoice with different invoice_numbers' do
+      expect(odi1.invoice_number).to eq(invoice_number1.to_i)
+      expect(goi3.invoice_number).to eq(invoice_number2.to_i)
+    end
+
+    it 'fails to create two different group order invoice with same invoice_numbers' do
+      odi1
+      expect { goi4 }.to raise_error(ActiveRecord::RecordInvalid)
+    end
+  end
+end

spec/spec_helper.rb

@@ -19,6 +19,8 @@ end
 # in spec/support/ and its subdirectories.
 Dir[Rails.root.join('spec/support/**/*.rb')].each { |f| require f }
 
+ActiveRecord::Migration.maintain_test_schema!
+
 RSpec.configure do |config|
   # We use capybara with webkit, and need database_cleaner
   config.before do