Foodsoft/foodsoft
1
1
Fork 0
Code Issues 36 Pull requests 5 Projects 1 Releases Wiki Activity

make uniqueness_of_name validations work again (closes foodcoops/foodsoft#157)

Browse source
This commit is contained in:
wvengen 2013-07-15 18:03:02 +02:00
parent 3fd498d29f
commit 5e9a49b2c7
2 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
app/models/ordergroup.rb
View file

@ -108,13 +108,13 @@ class Ordergroup < Group
# Make sure, the name is uniq, add usefull message if uniq group is already deleted # Make sure, the name is uniq, add usefull message if uniq group is already deleted
def uniqueness_of_name def uniqueness_of_name
id = new_record? ? nil : self.id group = Ordergroup.where('groups.name = ?', name)
group = Ordergroup.where('groups.id != ? AND groups.name = ?', id, name).first group = group.where('groups.id != ?', self.id) unless new_record?
if group.present? if group.exists?
message = group.deleted? ? :taken_with_deleted : :taken message = group.first.deleted? ? :taken_with_deleted : :taken
errors.add :name, message errors.add :name, message
end end
end end
end end

8
app/models/supplier.rb
View file

@ -82,10 +82,10 @@ class Supplier < ActiveRecord::Base
# Make sure, the name is uniq, add usefull message if uniq group is already deleted # Make sure, the name is uniq, add usefull message if uniq group is already deleted
def uniqueness_of_name def uniqueness_of_name
id = new_record? ? nil : self.id supplier = Supplier.where('suppliers.name = ?', name)
supplier = Supplier.where('suppliers.id != ? AND suppliers.name = ?', id, name).first supplier = supplier.where('suppliers.id != ?', self.id) unless new_record?
if supplier.present? if supplier.exists?
message = supplier.deleted? ? :taken_with_deleted : :taken message = supplier.first.deleted? ? :taken_with_deleted : :taken
errors.add :name, message errors.add :name, message
end end
end end