Show private messages in foodsofts index pages (fixes #106)

plugins/messages/app/controllers/message_threads_controller.rb

@@ -8,6 +8,6 @@ class MessageThreadsController < ApplicationController
 
   def show
     @group = Group.find_by_id(params[:id])
-    @message_threads = Message.pub.threads.where(group: @group).page(params[:page]).per(@per_page).order(created_at: :desc)
+    @message_threads = Message.readable_for(current_user).threads.where(group: @group).page(params[:page]).per(@per_page).order(created_at: :desc)
   end
 end

plugins/messages/app/controllers/messages_controller.rb

@@ -4,7 +4,7 @@ class MessagesController < ApplicationController
 
   # Renders the "inbox" action.
   def index
-    @messages = Message.pub.page(params[:page]).per(@per_page).order('created_at DESC').includes(:sender)
+    @messages = Message.readable_for(current_user).page(params[:page]).per(@per_page).order('created_at DESC').includes(:sender)
   end
 
   # Creates a new message object.

plugins/messages/app/models/message.rb

@@ -9,9 +9,11 @@ class Message < ApplicationRecord
 
   attr_accessor :send_method, :recipient_tokens, :order_id
 
-  scope :pub, -> { where(:private => false) }
   scope :threads, -> { where(:reply_to => nil) }
   scope :thread, -> (id) { where("id = ? OR reply_to = ?", id, id) }
+  scope :readable_for, -> (user) {
+    joins(:message_recipients).where('private = ? OR message_recipients.user_id = ?', false, user.try(&:id)).distinct
+  }
 
   validates_presence_of :message_recipients, :subject, :body
   validates_length_of :subject, :in => 1..255

plugins/messages/app/overrides/home/index/latest_public_messages_index.html.haml.deface

@@ -1,7 +1,7 @@
 / insert_after 'erb[silent]:contains("<dashboard_middle_mark>")'
 - if FoodsoftMessages.enabled?
-  - unless Message.pub.empty?
+  - unless Message.readable_for(current_user).empty?
     %section#messages
       %h2= t '.messages.title'
-      = render 'messages/messages', messages: Message.pub.order('created_at DESC').limit(5), pagination: false
+      = render 'messages/messages', messages: Message.readable_for(current_user).order('created_at DESC').limit(5), pagination: false
       %p= raw t '.messages.view_all.text', messages: link_to(t('.messages.view_all.messages'), messages_path), threads: link_to(t('.messages.view_all.threads'), message_threads_path)

plugins/messages/app/views/message_threads/_groupmessage_threads.html.haml

@@ -1,4 +1,4 @@
-- message_threads = Message.pub.threads.where(group: group).order(created_at: :desc).limit(5)
+- message_threads = Message.readable_for(current_user).threads.where(group: group).order(created_at: :desc).limit(5)
 - unless message_threads.empty?
   %section
     %h3

plugins/messages/app/views/message_threads/_message_threads.html.haml

@@ -1,5 +1,5 @@
 - if pagination
-  - if Message.pub.count > 20
+  - if Message.readable_for(current_user).count > 20
     = items_per_page
   = pagination_links_remote message_threads
 

plugins/messages/app/views/messages/_messages.html.haml

@@ -1,5 +1,5 @@
 - if pagination
-  - if Message.pub.count > 20
+  - if Message.readable_for(current_user).count > 20
     = items_per_page
   = pagination_links_remote messages