Foodsoft/foodsoft
1
1
Fork 0
Code Issues 36 Pull requests 5 Projects 1 Releases Wiki Activity

Allow increasing just tolerance in the boxfill phase

Browse source
This commit is contained in:
wvengen 2015-10-13 23:29:23 +02:00
parent 9d7735849d
commit 90b21ecc3a
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/models/order_article.rb
View file

@ -223,17 +223,17 @@ class OrderArticle < ActiveRecord::Base
# Throws an exception when the changed article decreases the amount of filled boxes. # Throws an exception when the changed article decreases the amount of filled boxes.
def enforce_boxfill def enforce_boxfill
# Either nothing changes, or # Either nothing changes, or the tolerance increases,
# missing_units becomes less and the amount doesn't decrease, or # missing_units decreases and the amount doesn't decrease, or
# tolerance was moved to quantity. Only then are changes allowed in the boxfill phase. # tolerance was moved to quantity. Only then are changes allowed in the boxfill phase.
delta_q = quantity - quantity_was delta_q = quantity - quantity_was
delta_t = tolerance - tolerance_was delta_t = tolerance - tolerance_was
delta_mis = missing_units - missing_units_was delta_mis = missing_units - missing_units_was
delta_box = units_to_order - units_to_order_was delta_box = units_to_order - units_to_order_was
unless (delta_q == 0 && delta_t == 0) || unless (delta_q == 0 && delta_t >= 0) ||
(delta_mis < 0 && delta_box >= 0 && delta_t >= 0) || (delta_mis < 0 && delta_box >= 0 && delta_t >= 0) ||
(delta_q > 0 && delta_q == -delta_t) (delta_q > 0 && delta_q == -delta_t)
raise ActiveRecord::RecordNotSaved.new("Change not acceptable in boxfill phase, sorry.", self) raise ActiveRecord::RecordNotSaved.new("Change not acceptable in boxfill phase for '#{article.name}', sorry.", self)
end end
end end