Foodsoft/foodsoft
1
1
Fork 0
Code Issues 36 Pull requests 5 Projects 1 Releases Wiki Activity

Avoid out of range error when using big numbers in financial transactions.

Browse source 
The database schema allows numbers up (+/-) 999_999.99. But as we are also adding the amount to the Ordergroup#account_balance, we use lower barriers to avoid running in errors when updating the account balance.

So, technically the user has to make 10 times the maximum input to raise an account balance error. This should be sufficient, I hope.
This commit is contained in:
Benjamin Meichsner 2014-09-22 11:21:12 +02:00
parent 9b03ac9a7c
commit 91bcf0c580
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/models/financial_transaction.rb
View file

@ -3,9 +3,10 @@
class FinancialTransaction < ActiveRecord::Base class FinancialTransaction < ActiveRecord::Base
belongs_to :ordergroup belongs_to :ordergroup
belongs_to :user belongs_to :user
validates_presence_of :amount, :note, :user_id, :ordergroup_id validates_presence_of :amount, :note, :user_id, :ordergroup_id
validates_numericality_of :amount validates_numericality_of :amount, greater_then: -100_000,
less_than: 100_000
localize_input_of :amount localize_input_of :amount
@ -14,4 +15,3 @@ class FinancialTransaction < ActiveRecord::Base
ordergroup.add_financial_transaction! amount, note, user ordergroup.add_financial_transaction! amount, note, user
end end
end end