Foodsoft/foodsoft
1
1
Fork 0
Code Issues 36 Pull requests 5 Projects 1 Releases Wiki Activity

Bundle update rubocop

Browse source
This commit is contained in:
Patrick Gansterer 2022-02-16 17:28:51 +01:00
parent bca29bea70
commit ae99619bf5
2 changed files with 146 additions and 88 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

214
.rubocop_todo.yml
View file

@ -1,6 +1,6 @@
# This configuration was generated by # This configuration was generated by
# `rubocop --auto-gen-config` # `rubocop --auto-gen-config`
# on 2021-03-01 12:00:00 UTC using RuboCop version 1.11.0. # on 2022-02-05 12:00:00 UTC using RuboCop version 1.25.1.
# The point is for the user to remove these configuration records # The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base. # one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new # Note that changes in the inspected code, or installation of new
@ -14,6 +14,22 @@ Bundler/OrderedGems:
Exclude: Exclude:
- 'Gemfile' - 'Gemfile'
# Offense count: 9
# Cop supports --auto-correct.
# Configuration parameters: Include.
# Include: **/*.gemspec
Gemspec/RequireMFA:
Exclude:
- 'plugins/current_orders/foodsoft_current_orders.gemspec'
- 'plugins/discourse/foodsoft_discourse.gemspec'
- 'plugins/documents/foodsoft_documents.gemspec'
- 'plugins/links/foodsoft_links.gemspec'
- 'plugins/messages/foodsoft_messages.gemspec'
- 'plugins/polls/foodsoft_polls.gemspec'
- 'plugins/printer/foodsoft_printer.gemspec'
- 'plugins/uservoice/foodsoft_uservoice.gemspec'
- 'plugins/wiki/foodsoft_wiki.gemspec'
# Offense count: 9 # Offense count: 9
# Configuration parameters: Include. # Configuration parameters: Include.
# Include: **/*.gemspec # Include: **/*.gemspec
@ -30,6 +46,7 @@ Gemspec/RequiredRubyVersion:
- 'plugins/wiki/foodsoft_wiki.gemspec' - 'plugins/wiki/foodsoft_wiki.gemspec'
# Offense count: 8 # Offense count: 8
# Configuration parameters: IgnoredMethods.
Lint/AmbiguousBlockAssociation: Lint/AmbiguousBlockAssociation:
Exclude: Exclude:
- 'lib/foodsoft/expansion_variables.rb' - 'lib/foodsoft/expansion_variables.rb'
@ -44,6 +61,15 @@ Lint/AmbiguousOperator:
- 'app/mailers/mailer.rb' - 'app/mailers/mailer.rb'
- 'spec/models/order_article_spec.rb' - 'spec/models/order_article_spec.rb'
# Offense count: 4
# Cop supports --auto-correct.
Lint/AmbiguousOperatorPrecedence:
Exclude:
- 'app/models/concerns/price_calculation.rb'
- 'db/seeds/seed_helper.rb'
- 'plugins/messages/app/mail_receivers/messages_mail_receiver.rb'
- 'plugins/wiki/app/helpers/pages_helper.rb'
# Offense count: 2 # Offense count: 2
# Cop supports --auto-correct. # Cop supports --auto-correct.
Lint/AmbiguousRegexpLiteral: Lint/AmbiguousRegexpLiteral:
@ -109,13 +135,13 @@ Lint/IneffectiveAccessModifier:
- 'lib/token_verifier.rb' - 'lib/token_verifier.rb'
# Offense count: 1 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct-all.
Lint/InterpolationCheck: Lint/InterpolationCheck:
Exclude: Exclude:
- 'db/migrate/007_create_article_prices.rb' - 'db/migrate/007_create_article_prices.rb'
# Offense count: 1 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct-all.
Lint/Loop: Lint/Loop:
Exclude: Exclude:
- 'app/models/concerns/mark_as_deleted_with_name.rb' - 'app/models/concerns/mark_as_deleted_with_name.rb'
@ -127,7 +153,7 @@ Lint/MixedRegexpCaptureTypes:
- 'lib/foodsoft_mail_receiver.rb' - 'lib/foodsoft_mail_receiver.rb'
# Offense count: 1 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct-all.
Lint/NonDeterministicRequireOrder: Lint/NonDeterministicRequireOrder:
Exclude: Exclude:
- 'spec/spec_helper.rb' - 'spec/spec_helper.rb'
@ -186,7 +212,7 @@ Lint/ShadowingOuterLocalVariable:
- 'spec/integration/config_spec.rb' - 'spec/integration/config_spec.rb'
# Offense count: 2 # Offense count: 2
# Configuration parameters: AllowComments. # Configuration parameters: AllowComments, AllowNil.
Lint/SuppressedException: Lint/SuppressedException:
Exclude: Exclude:
- 'lib/foodsoft_config.rb' - 'lib/foodsoft_config.rb'
@ -265,12 +291,12 @@ Lint/Void:
Exclude: Exclude:
- 'lib/foodsoft_config.rb' - 'lib/foodsoft_config.rb'
# Offense count: 158 # Offense count: 160
# Configuration parameters: IgnoredMethods, CountRepeatedAttributes. # Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
Metrics/AbcSize: Metrics/AbcSize:
Max: 143 Max: 143
# Offense count: 72 # Offense count: 73
# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
# IgnoredMethods: refine # IgnoredMethods: refine
Metrics/BlockLength: Metrics/BlockLength:
@ -291,7 +317,7 @@ Metrics/ClassLength:
Metrics/CyclomaticComplexity: Metrics/CyclomaticComplexity:
Max: 22 Max: 22
# Offense count: 155 # Offense count: 158
# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
Metrics/MethodLength: Metrics/MethodLength:
Max: 112 Max: 112
@ -496,9 +522,9 @@ RSpec/EmptyLineAfterHook:
- 'spec/support/api_oauth.rb' - 'spec/support/api_oauth.rb'
# Offense count: 59 # Offense count: 59
# Configuration parameters: Max. # Configuration parameters: CountAsOne.
RSpec/ExampleLength: RSpec/ExampleLength:
Enabled: false Max: 81
# Offense count: 7 # Offense count: 7
# Cop supports --auto-correct. # Cop supports --auto-correct.
@ -517,6 +543,13 @@ RSpec/FactoryBot/FactoryClassName:
- 'spec/factories/doorkeeper.rb' - 'spec/factories/doorkeeper.rb'
- 'spec/factories/supplier.rb' - 'spec/factories/supplier.rb'
# Offense count: 2
# Cop supports --auto-correct.
RSpec/FactoryBot/SyntaxMethods:
Exclude:
- 'spec/integration/articles_spec.rb'
- 'spec/models/article_spec.rb'
# Offense count: 7 # Offense count: 7
# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly. # Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
# Include: **/*_spec*rb*, **/spec/**/* # Include: **/*_spec*rb*, **/spec/**/*
@ -676,6 +709,14 @@ Rails/ActiveRecordCallbacksOrder:
- 'app/models/order.rb' - 'app/models/order.rb'
- 'app/models/stock_change.rb' - 'app/models/stock_change.rb'
# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: Include.
# Include: db/migrate/*.rb
Rails/AddColumnIndex:
Exclude:
- 'db/migrate/20171002000000_create_financial_links.rb'
# Offense count: 1 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct.
Rails/ApplicationMailer: Rails/ApplicationMailer:
@ -709,17 +750,10 @@ Rails/Blank:
Exclude: Exclude:
- 'app/controllers/api/v1/base_controller.rb' - 'app/controllers/api/v1/base_controller.rb'
# Offense count: 34 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct.
Rails/ContentTag: Rails/ContentTag:
Exclude: Exclude:
- 'app/helpers/admin/configs_helper.rb'
- 'app/helpers/application_helper.rb'
- 'app/helpers/orders_helper.rb'
- 'app/helpers/tasks_helper.rb'
- 'app/inputs/delta_input.rb'
- 'plugins/current_orders/app/helpers/current_orders_helper.rb'
- 'plugins/messages/app/helpers/messages_helper.rb'
- 'plugins/wiki/app/helpers/pages_helper.rb' - 'plugins/wiki/app/helpers/pages_helper.rb'
# Offense count: 33 # Offense count: 33
@ -728,20 +762,19 @@ Rails/ContentTag:
Rails/CreateTableWithTimestamps: Rails/CreateTableWithTimestamps:
Enabled: false Enabled: false
# Offense count: 6 # Offense count: 5
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle, AllowToTime.
# SupportedStyles: strict, flexible # SupportedStyles: strict, flexible
Rails/Date: Rails/Date:
Exclude: Exclude:
- 'app/controllers/deliveries_controller.rb' - 'app/controllers/deliveries_controller.rb'
- 'app/documents/order_fax.rb' - 'app/documents/order_fax.rb'
- 'app/models/periodic_task_group.rb' - 'app/models/periodic_task_group.rb'
- 'lib/foodsoft_date_util.rb'
- 'spec/integration/order_spec.rb' - 'spec/integration/order_spec.rb'
- 'spec/models/order_spec.rb' - 'spec/models/order_spec.rb'
# Offense count: 67 # Offense count: 66
# Cop supports --auto-correct. # Cop supports --auto-correct-all.
# Configuration parameters: Whitelist, AllowedMethods, AllowedReceivers. # Configuration parameters: Whitelist, AllowedMethods, AllowedReceivers.
# Whitelist: find_by_sql # Whitelist: find_by_sql
# AllowedMethods: find_by_sql # AllowedMethods: find_by_sql
@ -749,6 +782,12 @@ Rails/Date:
Rails/DynamicFindBy: Rails/DynamicFindBy:
Enabled: false Enabled: false
# Offense count: 1
# Cop supports --auto-correct.
Rails/EagerEvaluationLogMessage:
Exclude:
- 'db/migrate/20130718183101_migrate_user_settings.rb'
# Offense count: 1 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: Include. # Configuration parameters: Include.
@ -770,16 +809,6 @@ Rails/FilePath:
- 'plugins/current_orders/app/documents/multiple_orders_by_groups.rb' - 'plugins/current_orders/app/documents/multiple_orders_by_groups.rb'
- 'spec/api/v1/swagger_spec.rb' - 'spec/api/v1/swagger_spec.rb'
# Offense count: 5
# Cop supports --auto-correct.
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/FindBy:
Exclude:
- 'app/models/order.rb'
- 'app/models/supplier.rb'
- 'app/models/user.rb'
# Offense count: 7 # Offense count: 7
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: Include, IgnoredMethods. # Configuration parameters: Include, IgnoredMethods.
@ -793,7 +822,7 @@ Rails/FindEach:
- 'app/models/periodic_task_group.rb' - 'app/models/periodic_task_group.rb'
- 'app/models/task.rb' - 'app/models/task.rb'
# Offense count: 20 # Offense count: 26
# Configuration parameters: Include. # Configuration parameters: Include.
# Include: app/models/**/*.rb # Include: app/models/**/*.rb
Rails/HasManyOrHasOneDependent: Rails/HasManyOrHasOneDependent:
@ -843,7 +872,7 @@ Rails/IndexBy:
- 'spec/api/v1/user/ordergroup_spec.rb' - 'spec/api/v1/user/ordergroup_spec.rb'
# Offense count: 23 # Offense count: 23
# Configuration parameters: Include. # Configuration parameters: IgnoreScopes, Include.
# Include: app/models/**/*.rb # Include: app/models/**/*.rb
Rails/InverseOf: Rails/InverseOf:
Exclude: Exclude:
@ -877,7 +906,7 @@ Rails/LinkToBlank:
- 'app/helpers/application_helper.rb' - 'app/helpers/application_helper.rb'
# Offense count: 3 # Offense count: 3
# Cop supports --auto-correct. # Cop supports --auto-correct-all.
Rails/NegateInclude: Rails/NegateInclude:
Exclude: Exclude:
- 'app/helpers/application_helper.rb' - 'app/helpers/application_helper.rb'
@ -885,6 +914,7 @@ Rails/NegateInclude:
- 'lib/tasks/foodsoft_setup.rake' - 'lib/tasks/foodsoft_setup.rake'
# Offense count: 34 # Offense count: 34
# Cop supports --auto-correct.
# Configuration parameters: Include. # Configuration parameters: Include.
# Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb # Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb
Rails/Output: Rails/Output:
@ -939,8 +969,8 @@ Rails/Presence:
Rails/Present: Rails/Present:
Enabled: false Enabled: false
# Offense count: 5 # Offense count: 6
# Cop supports --auto-correct. # Cop supports --auto-correct-all.
# Configuration parameters: Include. # Configuration parameters: Include.
# Include: **/Rakefile, **/*.rake # Include: **/Rakefile, **/*.rake
Rails/RakeEnvironment: Rails/RakeEnvironment:
@ -955,6 +985,12 @@ Rails/RedundantForeignKey:
- 'app/models/financial_transaction.rb' - 'app/models/financial_transaction.rb'
- 'plugins/messages/app/models/message.rb' - 'plugins/messages/app/models/message.rb'
# Offense count: 1
# Cop supports --auto-correct.
Rails/RedundantPresenceValidationOnBelongsTo:
Exclude:
- 'app/models/financial_transaction_type.rb'
# Offense count: 1 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: ConvertTry. # Configuration parameters: ConvertTry.
@ -999,7 +1035,7 @@ Rails/UnknownEnv:
- 'config/initializers/gaffe.rb' - 'config/initializers/gaffe.rb'
- 'config/initializers/secret_token.rb' - 'config/initializers/secret_token.rb'
# Offense count: 64 # Offense count: 68
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: Include. # Configuration parameters: Include.
# Include: app/models/**/*.rb # Include: app/models/**/*.rb
@ -1059,14 +1095,6 @@ Style/AndOr:
- 'plugins/documents/app/controllers/documents_controller.rb' - 'plugins/documents/app/controllers/documents_controller.rb'
- 'spec/support/coverage.rb' - 'spec/support/coverage.rb'
# Offense count: 2
# Configuration parameters: AllowedChars.
# AllowedChars: ©
Style/AsciiComments:
Exclude:
- 'app/helpers/orders_helper.rb'
- 'app/inputs/delta_input.rb'
# Offense count: 19 # Offense count: 19
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods, AllowBracesOnProceduralOneLiners, BracesRequiredMethods. # Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
@ -1095,7 +1123,7 @@ Style/CaseEquality:
- 'lib/tasks/foodsoft_setup.rake' - 'lib/tasks/foodsoft_setup.rake'
# Offense count: 7 # Offense count: 7
# Cop supports --auto-correct. # Cop supports --auto-correct-all.
Style/CaseLikeIf: Style/CaseLikeIf:
Exclude: Exclude:
- 'app/helpers/admin/configs_helper.rb' - 'app/helpers/admin/configs_helper.rb'
@ -1144,7 +1172,7 @@ Style/ColonMethodCall:
- 'plugins/discourse/app/controllers/discourse_controller.rb' - 'plugins/discourse/app/controllers/discourse_controller.rb'
- 'plugins/messages/app/mail_receivers/messages_mail_receiver.rb' - 'plugins/messages/app/mail_receivers/messages_mail_receiver.rb'
# Offense count: 6 # Offense count: 7
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, AllowInnerBackticks. # Configuration parameters: EnforcedStyle, AllowInnerBackticks.
# SupportedStyles: backticks, percent_x, mixed # SupportedStyles: backticks, percent_x, mixed
@ -1154,7 +1182,7 @@ Style/CommandLiteral:
# Offense count: 10 # Offense count: 10
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: Keywords. # Configuration parameters: Keywords, RequireColon.
# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW, NOTE # Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW, NOTE
Style/CommentAnnotation: Style/CommentAnnotation:
Exclude: Exclude:
@ -1202,7 +1230,8 @@ Style/DefWithParentheses:
Exclude: Exclude:
- 'app/models/user.rb' - 'app/models/user.rb'
# Offense count: 307 # Offense count: 314
# Configuration parameters: AllowedConstants.
Style/Documentation: Style/Documentation:
Enabled: false Enabled: false
@ -1226,7 +1255,7 @@ Style/EmptyElse:
- 'app/models/user.rb' - 'app/models/user.rb'
- 'lib/token_verifier.rb' - 'lib/token_verifier.rb'
# Offense count: 2 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/EmptyLiteral: Style/EmptyLiteral:
Exclude: Exclude:
@ -1267,8 +1296,17 @@ Style/ExplicitBlockArgument:
- 'plugins/current_orders/app/documents/multiple_orders_by_articles.rb' - 'plugins/current_orders/app/documents/multiple_orders_by_articles.rb'
- 'plugins/current_orders/app/documents/multiple_orders_by_groups.rb' - 'plugins/current_orders/app/documents/multiple_orders_by_groups.rb'
# Offense count: 1 # Offense count: 4
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/FileWrite:
Exclude:
- 'config/initializers/secret_token.rb'
- 'lib/order_txt.rb'
- 'lib/render_csv.rb'
- 'lib/render_pdf.rb'
# Offense count: 1
# Cop supports --auto-correct-all.
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: left_coerce, right_coerce, single_coerce, fdiv # SupportedStyles: left_coerce, right_coerce, single_coerce, fdiv
Style/FloatDivision: Style/FloatDivision:
@ -1306,7 +1344,7 @@ Style/FormatString:
Style/FormatStringToken: Style/FormatStringToken:
EnforcedStyle: unannotated EnforcedStyle: unannotated
# Offense count: 482 # Offense count: 490
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: always, always_true, never # SupportedStyles: always, always_true, never
@ -1321,7 +1359,7 @@ Style/GlobalStdStream:
- 'lib/tasks/foodsoft.rake' - 'lib/tasks/foodsoft.rake'
- 'lib/tasks/foodsoft_setup.rake' - 'lib/tasks/foodsoft_setup.rake'
# Offense count: 62 # Offense count: 61
# Configuration parameters: MinBodyLength. # Configuration parameters: MinBodyLength.
Style/GuardClause: Style/GuardClause:
Enabled: false Enabled: false
@ -1359,10 +1397,11 @@ Style/HashLikeCase:
- 'plugins/documents/app/controllers/documents_controller.rb' - 'plugins/documents/app/controllers/documents_controller.rb'
- 'plugins/wiki/app/controllers/pages_controller.rb' - 'plugins/wiki/app/controllers/pages_controller.rb'
# Offense count: 3900 # Offense count: 3904
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. # Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
# SupportedShorthandSyntax: always, never, either
Style/HashSyntax: Style/HashSyntax:
Enabled: false Enabled: false
@ -1376,7 +1415,7 @@ Style/IfInsideElse:
- 'lib/apple_bar.rb' - 'lib/apple_bar.rb'
- 'plugins/wiki/app/controllers/pages_controller.rb' - 'plugins/wiki/app/controllers/pages_controller.rb'
# Offense count: 59 # Offense count: 60
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/IfUnlessModifier: Style/IfUnlessModifier:
Enabled: false Enabled: false
@ -1391,13 +1430,13 @@ Style/IfWithBooleanLiteralBranches:
- 'app/models/task.rb' - 'app/models/task.rb'
# Offense count: 1 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct-all.
Style/InfiniteLoop: Style/InfiniteLoop:
Exclude: Exclude:
- 'lib/order_pdf.rb' - 'lib/order_pdf.rb'
# Offense count: 3 # Offense count: 3
# Cop supports --auto-correct. # Cop supports --auto-correct-all.
# Configuration parameters: InverseMethods, InverseBlocks. # Configuration parameters: InverseMethods, InverseBlocks.
Style/InverseMethods: Style/InverseMethods:
Exclude: Exclude:
@ -1422,6 +1461,12 @@ Style/LineEndConcatenation:
- 'db/migrate/20130702113610_update_group_order_totals.rb' - 'db/migrate/20130702113610_update_group_order_totals.rb'
- 'plugins/current_orders/app/documents/multiple_orders_by_articles.rb' - 'plugins/current_orders/app/documents/multiple_orders_by_articles.rb'
# Offense count: 1
# Cop supports --auto-correct-all.
Style/MapToHash:
Exclude:
- 'lib/foodsoft_config.rb'
# Offense count: 1 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods. # Configuration parameters: IgnoredMethods.
@ -1476,6 +1521,7 @@ Style/MultilineWhenThen:
# Offense count: 5 # Offense count: 5
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: AllowMethodComparison.
Style/MultipleComparison: Style/MultipleComparison:
Exclude: Exclude:
- 'app/models/order.rb' - 'app/models/order.rb'
@ -1515,7 +1561,7 @@ Style/NestedParenthesizedCalls:
- 'app/models/user.rb' - 'app/models/user.rb'
- 'spec/models/order_article_spec.rb' - 'spec/models/order_article_spec.rb'
# Offense count: 9 # Offense count: 7
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, MinBodyLength. # Configuration parameters: EnforcedStyle, MinBodyLength.
# SupportedStyles: skip_modifier_ifs, always # SupportedStyles: skip_modifier_ifs, always
@ -1524,7 +1570,6 @@ Style/Next:
- 'app/controllers/finance/financial_transactions_controller.rb' - 'app/controllers/finance/financial_transactions_controller.rb'
- 'app/controllers/orders_controller.rb' - 'app/controllers/orders_controller.rb'
- 'app/helpers/orders_helper.rb' - 'app/helpers/orders_helper.rb'
- 'app/workers/user_notifier.rb'
- 'db/migrate/20130622095040_move_weekly_tasks.rb' - 'db/migrate/20130622095040_move_weekly_tasks.rb'
- 'lib/tasks/foodsoft.rake' - 'lib/tasks/foodsoft.rake'
@ -1552,12 +1597,12 @@ Style/Not:
# Offense count: 6 # Offense count: 6
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: Strict. # Configuration parameters: Strict, AllowedNumbers.
Style/NumericLiterals: Style/NumericLiterals:
MinDigits: 7 MinDigits: 7
# Offense count: 60 # Offense count: 60
# Cop supports --auto-correct. # Cop supports --auto-correct-all.
# Configuration parameters: EnforcedStyle, IgnoredMethods. # Configuration parameters: EnforcedStyle, IgnoredMethods.
# SupportedStyles: predicate, comparison # SupportedStyles: predicate, comparison
Style/NumericPredicate: Style/NumericPredicate:
@ -1615,7 +1660,7 @@ Style/PerlBackrefs:
- 'plugins/wiki/app/helpers/pages_helper.rb' - 'plugins/wiki/app/helpers/pages_helper.rb'
# Offense count: 2 # Offense count: 2
# Cop supports --auto-correct. # Cop supports --auto-correct-all.
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: short, verbose # SupportedStyles: short, verbose
Style/PreferredHashMethods: Style/PreferredHashMethods:
@ -1652,7 +1697,7 @@ Style/RandomWithOffset:
- 'db/seeds/seed_helper.rb' - 'db/seeds/seed_helper.rb'
# Offense count: 1 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct-all.
# Configuration parameters: Methods. # Configuration parameters: Methods.
Style/RedundantArgument: Style/RedundantArgument:
Exclude: Exclude:
@ -1675,7 +1720,7 @@ Style/RedundantConditional:
- 'app/models/task.rb' - 'app/models/task.rb'
# Offense count: 3 # Offense count: 3
# Cop supports --auto-correct. # Cop supports --auto-correct-all.
# Configuration parameters: SafeForConstants. # Configuration parameters: SafeForConstants.
Style/RedundantFetchBlock: Style/RedundantFetchBlock:
Exclude: Exclude:
@ -1728,13 +1773,19 @@ Style/RedundantReturn:
- 'app/models/supplier.rb' - 'app/models/supplier.rb'
- 'lib/bank_transaction_reference.rb' - 'lib/bank_transaction_reference.rb'
# Offense count: 85 # Offense count: 82
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/RedundantSelf: Style/RedundantSelf:
Enabled: false Enabled: false
# Offense count: 1 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/RedundantSelfAssignmentBranch:
Exclude:
- 'db/migrate/20130718183101_migrate_user_settings.rb'
# Offense count: 1
# Cop supports --auto-correct-all.
Style/RedundantSort: Style/RedundantSort:
Exclude: Exclude:
- 'app/models/article_category.rb' - 'app/models/article_category.rb'
@ -1784,13 +1835,19 @@ Style/SafeNavigation:
- 'plugins/printer/app/controllers/printer_controller.rb' - 'plugins/printer/app/controllers/printer_controller.rb'
- 'spec/factories/order.rb' - 'spec/factories/order.rb'
# Offense count: 1
# Cop supports --auto-correct.
Style/SelectByRegexp:
Exclude:
- 'lib/foodsoft_config.rb'
# Offense count: 1 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/SelfAssignment: Style/SelfAssignment:
Exclude: Exclude:
- 'app/helpers/application_helper.rb' - 'app/helpers/application_helper.rb'
# Offense count: 14 # Offense count: 16
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: AllowAsExpressionSeparator. # Configuration parameters: AllowAsExpressionSeparator.
Style/Semicolon: Style/Semicolon:
@ -1807,7 +1864,7 @@ Style/Semicolon:
- 'spec/models/order_article_spec.rb' - 'spec/models/order_article_spec.rb'
# Offense count: 5 # Offense count: 5
# Cop supports --auto-correct. # Cop supports --auto-correct-all.
Style/SlicingWithRange: Style/SlicingWithRange:
Exclude: Exclude:
- 'app/helpers/admin/configs_helper.rb' - 'app/helpers/admin/configs_helper.rb'
@ -1824,24 +1881,25 @@ Style/SoleNestedConditional:
# Offense count: 9 # Offense count: 9
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: . # Configuration parameters: RequireEnglish.
# SupportedStyles: use_perl_names, use_english_names # SupportedStyles: use_perl_names, use_english_names
Style/SpecialGlobalVars: Style/SpecialGlobalVars:
EnforcedStyle: use_perl_names EnforcedStyle: use_perl_names
# Offense count: 32 # Offense count: 32
# Cop supports --auto-correct. # Cop supports --auto-correct-all.
# Configuration parameters: Mode.
Style/StringConcatenation: Style/StringConcatenation:
Enabled: false Enabled: false
# Offense count: 1796 # Offense count: 1799
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
# SupportedStyles: single_quotes, double_quotes # SupportedStyles: single_quotes, double_quotes
Style/StringLiterals: Style/StringLiterals:
Enabled: false Enabled: false
# Offense count: 79 # Offense count: 80
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: MinSize. # Configuration parameters: MinSize.
# SupportedStyles: percent, brackets # SupportedStyles: percent, brackets
@ -1849,7 +1907,7 @@ Style/SymbolArray:
EnforcedStyle: brackets EnforcedStyle: brackets
# Offense count: 19 # Offense count: 19
# Cop supports --auto-correct. # Cop supports --auto-correct-all.
# Configuration parameters: AllowMethodsWithArguments, IgnoredMethods. # Configuration parameters: AllowMethodsWithArguments, IgnoredMethods.
# IgnoredMethods: respond_to, define_method # IgnoredMethods: respond_to, define_method
Style/SymbolProc: Style/SymbolProc:
@ -1938,16 +1996,16 @@ Style/WordArray:
- 'spec/support/faker.rb' - 'spec/support/faker.rb'
# Offense count: 3 # Offense count: 3
# Cop supports --auto-correct. # Cop supports --auto-correct-all.
Style/ZeroLengthPredicate: Style/ZeroLengthPredicate:
Exclude: Exclude:
- 'app/models/group_order_article.rb' - 'app/models/group_order_article.rb'
- 'plugins/current_orders/app/documents/multiple_orders_by_articles.rb' - 'plugins/current_orders/app/documents/multiple_orders_by_articles.rb'
- 'plugins/current_orders/app/documents/multiple_orders_by_groups.rb' - 'plugins/current_orders/app/documents/multiple_orders_by_groups.rb'
# Offense count: 447 # Offense count: 448
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https # URISchemes: http, https
Layout/LineLength: Layout/LineLength:
Max: 420 Max: 420

20
Gemfile.lock
View file

@ -312,8 +312,8 @@ GEM
nokogiri (1.12.5) nokogiri (1.12.5)
mini_portile2 (~> 2.6.1) mini_portile2 (~> 2.6.1)
racc (~> 1.4) racc (~> 1.4)
parallel (1.20.1) parallel (1.21.0)
parser (3.0.0.0) parser (3.1.0.0)
ast (~> 2.4.1) ast (~> 2.4.1)
pdf-core (0.9.0) pdf-core (0.9.0)
polyglot (0.3.5) polyglot (0.3.5)
@ -377,7 +377,7 @@ GEM
method_source method_source
rake (>= 0.8.7) rake (>= 0.8.7)
thor (>= 0.19.0, < 2.0) thor (>= 0.19.0, < 2.0)
rainbow (3.0.0) rainbow (3.1.1)
rake (13.0.3) rake (13.0.3)
ransack (2.4.2) ransack (2.4.2)
activerecord (>= 5.2.4) activerecord (>= 5.2.4)
@ -396,7 +396,7 @@ GEM
redis-namespace (1.8.1) redis-namespace (1.8.1)
redis (>= 3.0.4) redis (>= 3.0.4)
ref (2.0.0) ref (2.0.0)
regexp_parser (2.0.3) regexp_parser (2.2.1)
responders (3.0.1) responders (3.0.1)
actionpack (>= 5.0) actionpack (>= 5.0)
railties (>= 5.0) railties (>= 5.0)
@ -437,17 +437,17 @@ GEM
rspec-rerun (1.1.0) rspec-rerun (1.1.0)
rspec (~> 3.0) rspec (~> 3.0)
rspec-support (3.10.2) rspec-support (3.10.2)
rubocop (1.11.0) rubocop (1.25.1)
parallel (~> 1.10) parallel (~> 1.10)
parser (>= 3.0.0.0) parser (>= 3.1.0.0)
rainbow (>= 2.2.2, < 4.0) rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0) regexp_parser (>= 1.8, < 3.0)
rexml rexml
rubocop-ast (>= 1.2.0, < 2.0) rubocop-ast (>= 1.15.1, < 2.0)
ruby-progressbar (~> 1.7) ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 3.0) unicode-display_width (>= 1.4.0, < 3.0)
rubocop-ast (1.4.1) rubocop-ast (1.15.2)
parser (>= 2.7.1.5) parser (>= 3.0.1.1)
rubocop-rails (2.9.1) rubocop-rails (2.9.1)
activesupport (>= 4.2.0) activesupport (>= 4.2.0)
rack (>= 1.1) rack (>= 1.1)
@ -537,7 +537,7 @@ GEM
unf (0.1.4) unf (0.1.4)
unf_ext unf_ext
unf_ext (0.0.7.7) unf_ext (0.0.7.7)
unicode-display_width (2.0.0) unicode-display_width (2.1.0)
uniform_notifier (1.13.2) uniform_notifier (1.13.2)
vegas (0.1.11) vegas (0.1.11)
rack (>= 1.0.0) rack (>= 1.0.0)