Simplifiying balancing view part 2. Lets call it finished.
This commit is contained in:
benni
parent
dc0d1b3e46
commit
af3c07f031
26 changed files with 185 additions and 219 deletions
|
|
@ -13,7 +13,8 @@ class Finance::BalancingController < ApplicationController
|
|||
end
|
||||
|
||||
def new
|
||||
@order = Order.find(params[:id])
|
||||
@order = Order.find(params[:order_id])
|
||||
flash.now.alert = "Achtung, Bestellung wurde schon abgerechnet" if @order.closed?
|
||||
@comments = @order.comments
|
||||
|
||||
if params['sort']
|
||||
|
|
@ -35,131 +36,20 @@ class Finance::BalancingController < ApplicationController
|
|||
@articles = @articles.to_a.sort { |a,b| b.article.order_number.gsub(/[^[:digit:]]/, "").to_i <=> a.article.order_number.gsub(/[^[:digit:]]/, "").to_i }
|
||||
end
|
||||
|
||||
view = params[:view]
|
||||
params[:view] = nil
|
||||
|
||||
case view.try(:to_sym)
|
||||
when 'editResults'
|
||||
render :partial => 'edit_results_by_articles' and return
|
||||
when :groups_overview
|
||||
render :partial => 'shared/articles_by_groups', :locals => {:order => @order} and return
|
||||
when 'articlesOverview'
|
||||
render :partial => 'shared/articles_by_articles', :locals => {:order => @order} and return
|
||||
end
|
||||
render layout: false if request.xhr?
|
||||
end
|
||||
|
||||
def new_group_order_article
|
||||
goa = OrderArticle.find(params[:id]).group_order_articles.build
|
||||
render :update do |page|
|
||||
page["edit_box"].replace_html :partial => "new_group_order_article",
|
||||
:locals => {:group_order_article => goa}
|
||||
page["edit_box"].show
|
||||
end
|
||||
def edit_note
|
||||
@order = Order.find(params[:id])
|
||||
render :layout => false
|
||||
end
|
||||
|
||||
# Creates a new GroupOrderArticle
|
||||
# If the the chosen Ordergroup hasn't ordered yet, a GroupOrder will also be created
|
||||
#FIXME: Clean up this messy code !
|
||||
def create_group_order_article
|
||||
goa = GroupOrderArticle.new(params[:group_order_article])
|
||||
order_article = goa.order_article
|
||||
order = order_article.order
|
||||
|
||||
# creates a new GroupOrder if necessary
|
||||
group_order = GroupOrder.first :conditions => {:order_id => order.id, :ordergroup_id => goa.ordergroup_id}
|
||||
unless group_order
|
||||
goa.create_group_order(:order_id => order.id, :ordergroup_id => goa.ordergroup_id)
|
||||
def update_note
|
||||
@order = Order.find(params[:id])
|
||||
if @order.update_attributes(params[:order])
|
||||
render :layout => false
|
||||
else
|
||||
goa.group_order = group_order
|
||||
end
|
||||
|
||||
# If there is an GroupOrderArticle already, only update result attribute.
|
||||
if group_order_article = GroupOrderArticle.first(:conditions => {:group_order_id => goa.group_order, :order_article_id => goa.order_article})
|
||||
goa = group_order_article
|
||||
goa.result = params[:group_order_article]["result"]
|
||||
end
|
||||
|
||||
render :update do |page|
|
||||
if goa.save
|
||||
goa.group_order.update_price! # Update the price attribute of new GroupOrder
|
||||
order_article.update_results! if order_article.article.is_a?(StockArticle) # Update units_to_order of order_article
|
||||
page["edit_box"].hide
|
||||
page["order_article_#{order_article.id}"].replace_html :partial => 'order_article', :locals => {:order_article => order_article}
|
||||
|
||||
page["group_order_articles_#{order_article.id}"].replace_html :partial => 'group_order_articles',
|
||||
:locals => {:order_article => order_article}
|
||||
page["group_order_article_#{goa.id}"].visual_effect :highlight, :duration => 2
|
||||
|
||||
page["summary"].replace_html :partial => 'summary', :locals => {:order => order}
|
||||
page["order_profit"].visual_effect :highlight, :duration => 2
|
||||
else
|
||||
page["edit_box"].replace_html :partial => "new_group_order_article",
|
||||
:locals => {:group_order_article => goa}
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
def edit_group_order_article
|
||||
group_order_article = GroupOrderArticle.find(params[:id])
|
||||
render :partial => 'edit_group_order_article',
|
||||
:locals => {:group_order_article => group_order_article}
|
||||
end
|
||||
|
||||
def update_group_order_article
|
||||
goa = GroupOrderArticle.find(params[:id])
|
||||
|
||||
render :update do |page|
|
||||
if goa.update_attributes(params[:group_order_article])
|
||||
goa.group_order.update_price! # Update the price attribute of new GroupOrder
|
||||
goa.order_article.update_results! if goa.order_article.article.is_a?(StockArticle) # Update units_to_order of order_article
|
||||
|
||||
page["edit_box"].hide
|
||||
page["order_article_#{goa.order_article.id}"].replace_html :partial => 'order_article', :locals => {:order_article => goa.order_article}
|
||||
page["group_order_articles_#{goa.order_article.id}"].replace_html :partial => 'group_order_articles',
|
||||
:locals => {:order_article => goa.order_article}
|
||||
page["summary"].replace_html :partial => 'summary', :locals => {:order => goa.order_article.order}
|
||||
page["order_profit"].visual_effect :highlight, :duration => 2
|
||||
else
|
||||
page["edit_box"].replace_html :partial => 'edit_group_order_article'
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
def update_group_order_article_result
|
||||
goa = GroupOrderArticle.find(params[:id])
|
||||
|
||||
if params[:modifier] == '-'
|
||||
goa.update_attributes({:result => goa.result - 1})
|
||||
elsif params[:modifier] == '+'
|
||||
goa.update_attributes({:result => goa.result + 1})
|
||||
end
|
||||
|
||||
render :update do |page|
|
||||
goa.group_order.update_price! # Update the price attribute of new GroupOrder
|
||||
goa.order_article.update_results! if goa.order_article.article.is_a?(StockArticle) # Update units_to_order of order_article
|
||||
|
||||
page["order_article_#{goa.order_article.id}"].replace_html :partial => 'order_article', :locals => {:order_article => goa.order_article}
|
||||
page["group_order_articles_#{goa.order_article.id}"].replace_html :partial => 'group_order_articles',
|
||||
:locals => {:order_article => goa.order_article}
|
||||
page["summary"].replace_html :partial => 'summary', :locals => {:order => goa.order_article.order}
|
||||
page["order_profit"].visual_effect :highlight, :duration => 2
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
def destroy_group_order_article
|
||||
goa = GroupOrderArticle.find(params[:id])
|
||||
goa.destroy
|
||||
goa.group_order.update_price! # Updates the price attribute of new GroupOrder
|
||||
goa.order_article.update_results! if goa.order_article.article.is_a?(StockArticle) # Update units_to_order of order_article
|
||||
|
||||
render :update do |page|
|
||||
page["edit_box"].hide
|
||||
page["order_article_#{goa.order_article.id}"].replace_html :partial => 'order_article', :locals => {:order_article => goa.order_article}
|
||||
page["group_order_articles_#{goa.order_article.id}"].replace_html :partial => 'group_order_articles',
|
||||
:locals => {:order_article => goa.order_article}
|
||||
page["summary"].replace_html :partial => 'summary', :locals => {:order => goa.order_article.order}
|
||||
page["order_profit"].visual_effect :highlight, :duration => 2
|
||||
render :action => :edit_note, :layout => false
|
||||
end
|
||||
end
|
||||
|
||||
|
|
@ -171,27 +61,20 @@ class Finance::BalancingController < ApplicationController
|
|||
# Balances the Order, Update of the Ordergroup.account_balances
|
||||
def close
|
||||
@order = Order.find(params[:id])
|
||||
begin
|
||||
@order.close!(@current_user)
|
||||
flash[:notice] = "Bestellung wurde erfolgreich abgerechnet, die Kontostände aktualisiert."
|
||||
redirect_to :action => "index"
|
||||
rescue => e
|
||||
flash[:error] = "Ein Fehler ist beim Abrechnen aufgetreten: " + e
|
||||
redirect_to :action => "new", :id => @order
|
||||
end
|
||||
@order.close!(@current_user)
|
||||
redirect_to finance_balancing_url, notice: "Bestellung wurde erfolgreich abgerechnet, die Kontostände aktualisiert."
|
||||
|
||||
rescue => error
|
||||
redirect_to finance_balancing_url, alert: "Ein Fehler ist beim Abrechnen aufgetreten: #{error.message}"
|
||||
end
|
||||
|
||||
# Close the order directly, without automaticly updating ordergroups account balances
|
||||
def close_direct
|
||||
@order = Order.find(params[:id])
|
||||
if @order.finished?
|
||||
@order.update_attributes(:state => 'closed', :updated_by => @current_user)
|
||||
flash[:notice] = 'Die Bestellung wurde auf "gebucht" gesetzt.'
|
||||
redirect_to :action => 'listOrders', :id => @order
|
||||
else
|
||||
flash[:error] = 'Die Bestellung ist noch nicht beendet.'
|
||||
redirect_to :action => 'listOrders', :id => @order
|
||||
end
|
||||
@order.close_direct!(@current_user)
|
||||
redirect_to finance_balancing_url, notice: "Bestellung wurde geschlossen."
|
||||
rescue => error
|
||||
redirect_to finance_balancing_url, alert: "Bestellung kann nicht geschlossen werden: #{error.message}"
|
||||
end
|
||||
|
||||
end
|
||||
|
|
|
|||
|
|
@ -6,5 +6,78 @@ class Finance::GroupOrderArticlesController < ApplicationController
|
|||
|
||||
def new
|
||||
@order_article = OrderArticle.find(params[:order_article_id])
|
||||
@group_order_article = GroupOrderArticle.new(order_article: @order_article)
|
||||
end
|
||||
|
||||
def create
|
||||
@group_order_article = GroupOrderArticle.new(params[:group_order_article])
|
||||
@order_article = @group_order_article.order_article
|
||||
|
||||
# As we hide group_order_articles with a result of 0, we should not complain, when an existing group_order_article is found
|
||||
goa = GroupOrderArticle.where(group_order_id: @group_order_article.group_order_id,
|
||||
order_article_id: @order_article.id).first
|
||||
|
||||
if goa and goa.update_attributes(params[:group_order_article])
|
||||
@group_order_article = goa
|
||||
|
||||
update_summaries(@group_order_article)
|
||||
render :update
|
||||
|
||||
elsif @group_order_article.save
|
||||
update_summaries(@group_order_article)
|
||||
render :update
|
||||
|
||||
else # Validation failed, show form
|
||||
render :new
|
||||
end
|
||||
end
|
||||
|
||||
def edit
|
||||
@group_order_article = GroupOrderArticle.find(params[:id])
|
||||
@order_article = @group_order_article.order_article
|
||||
end
|
||||
|
||||
def update
|
||||
@group_order_article = GroupOrderArticle.find(params[:id])
|
||||
@order_article = @group_order_article.order_article
|
||||
|
||||
if @group_order_article.update_attributes(params[:group_order_article])
|
||||
update_summaries(@group_order_article)
|
||||
else
|
||||
render :edit
|
||||
end
|
||||
end
|
||||
|
||||
def update_result
|
||||
group_order_article = GroupOrderArticle.find(params[:id])
|
||||
@order_article = group_order_article.order_article
|
||||
|
||||
if params[:modifier] == '-'
|
||||
group_order_article.update_attribute :result, group_order_article.result - 1
|
||||
elsif params[:modifier] == '+'
|
||||
group_order_article.update_attribute :result, group_order_article.result + 1
|
||||
end
|
||||
|
||||
update_summaries(group_order_article)
|
||||
|
||||
render :update
|
||||
end
|
||||
|
||||
def destroy
|
||||
group_order_article = GroupOrderArticle.find(params[:id])
|
||||
group_order_article.destroy
|
||||
update_summaries(group_order_article)
|
||||
@order_article = group_order_article.order_article
|
||||
|
||||
render :update
|
||||
end
|
||||
|
||||
protected
|
||||
|
||||
def update_summaries(group_order_article)
|
||||
# Update the price attribute of new GroupOrder
|
||||
group_order_article.group_order.update_price!
|
||||
# Update units_to_order of order_article
|
||||
group_order_article.order_article.update_results! if group_order_article.order_article.article.is_a?(StockArticle)
|
||||
end
|
||||
end
|
||||
|
|
|
|||
|
|
@ -2,7 +2,7 @@ class Finance::OrderArticlesController < ApplicationController
|
|||
|
||||
before_filter :authenticate_finance
|
||||
|
||||
layout false # We only use this controller to server js snippets, no need for layout rendering
|
||||
layout false # We only use this controller to serve js snippets, no need for layout rendering
|
||||
|
||||
def new
|
||||
@order = Order.find(params[:order_id])
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue