add specs for odin, bnn, foodsoft files

spec/integration/articles_spec.rb

@@ -1,9 +1,9 @@
 require_relative '../spec_helper'
 
 feature ArticlesController do
-  let(:user) { create :user, groups: [create(:workgroup, role_article_meta: true)] }
-  let(:supplier) { create :supplier }
-  let!(:article_category) { create :article_category }
+  let(:user) { create(:user, groups: [create(:workgroup, role_article_meta: true)]) }
+  let(:supplier) { create(:supplier) }
+  let!(:article_category) { create(:article_category) }
 
   before { login user }
 
@@ -18,7 +18,7 @@ feature ArticlesController do
     it 'can create a new article' do
       click_on I18n.t('articles.index.new')
       expect(page).to have_selector('form#new_article')
-      article = build :article, supplier: supplier, article_category: article_category
+      article = build(:article, supplier: supplier, article_category: article_category)
       within('#new_article') do
         fill_in 'article_name', :with => article.name
         fill_in 'article_unit', :with => article.unit
@@ -42,13 +42,14 @@ feature ArticlesController do
     before do
       visit upload_supplier_articles_path(supplier_id: supplier.id)
       attach_file 'articles_file', file
-      find("#articles_type option[value='foodsoft']").select_option
     end
 
     Dir.glob('spec/fixtures/foodsoft_file_01.*') do |test_file|
       describe "can import articles from #{test_file}" do
         let(:file) { Rails.root.join(test_file) }
+
         it do
+          find("#articles_type option[value='foodsoft']").select_option
           find('input[type="submit"]').click
           expect(find("tr:nth-child(1) #new_articles__note").value).to eq "bio ◎"
           expect(find("tr:nth-child(2) #new_articles__name").value).to eq "Pijnboompitten"
@@ -64,56 +65,99 @@ feature ArticlesController do
       end
     end
 
-    describe "can update existing article" do
-      let!(:article) { create :article, supplier: supplier, name: 'Foobar', order_number: 1, unit: '250 g' }
+    Dir.glob('spec/fixtures/bnn_file_01.*') do |test_file|
+      describe "can import articles from #{test_file}" do
+        let(:file) { Rails.root.join(test_file) }
 
-      it do
-        find('input[type="submit"]').click
-        expect(find("#articles_#{article.id}_name").value).to eq 'Tomatoes'
-        find('input[type="submit"]').click
-        article.reload
-        expect(article.name).to eq 'Tomatoes'
-        expect([article.unit, article.unit_quantity, article.price]).to eq ['500 g', 20, 1.2]
+        it do
+          find("#articles_type option[value='bnn']").select_option
+          find('input[type="submit"]').click
+          expect(find("tr:nth-child(1) #new_articles__note").value).to eq "bio"
+          expect(find("tr:nth-child(1) #new_articles__name").value).to eq "Walnoten (ongeroosterd)"
+          # set article category
+          4.times do |i|
+            all("tr:nth-child(#{i + 1}) select > option")[1].select_option
+          end
+          find('input[type="submit"]').click
+
+          expect(page).to have_content("Pijnboompitten")
+
+          expect(supplier.articles.count).to eq 4
+        end
       end
     end
+  end
 
-    describe "handles missing data" do
-      it do
-        find('input[type="submit"]').click # to overview
-        find('input[type="submit"]').click # missing category, re-show form
-        expect(find('tr.alert')).to be_present
-        expect(supplier.articles.count).to eq 0
+  describe "updates" do
+    file_paths = ['spec/fixtures/foodsoft_file_02.csv', 'spec/fixtures/bnn_file_02.bnn', 'spec/fixtures/odin_file_02.xml']
+    let(:filename) { 'foodsoft_file_02.csv' }
+    let(:file)     { Rails.root.join("spec/fixtures/#{filename}") }
+    let(:val) { 'foodsoft' }
+    let(:type) { %w[foodsoft bnn odin] }
 
-        all("tr select > option")[1].select_option
-        find('input[type="submit"]').click # now it should succeed
-        expect(supplier.articles.count).to eq 1
-      end
+    before do
+      visit upload_supplier_articles_path(supplier_id: supplier.id)
+      attach_file 'articles_file', file
+      find("#articles_type option[value='#{val}']").select_option
     end
 
-    describe "can remove an existing article" do
-      let!(:article) { create :article, supplier: supplier, name: 'Foobar', order_number: 99999 }
+    file_paths.each_with_index do |test_file, index|
+      describe "updates article for #{test_file}" do
+        let(:article) { create(:article, supplier: supplier, name: 'Foobar', order_number: 1, unit: '250 g') }
+        let(:file) { Rails.root.join(test_file) }
+        let(:val) { type[index] }
 
-      it do
-        check('articles_outlist_absent')
-        find('input[type="submit"]').click
-        expect(find("#outlisted_articles_#{article.id}", visible: :all)).to be_present
+        it do
+          article.reload
+          find('input[type="submit"]').click
+          expect(find("#articles_#{article.id}_name").value).to eq 'Tomatoes'
+          find('input[type="submit"]').click
+          article.reload
+          expect(article.name).to eq 'Tomatoes'
+          if type[index] == "odin"
+            expect([article.unit, article.unit_quantity, article.price]).to eq ['500gr', 20, 1.20]
+          else
+            expect([article.unit, article.unit_quantity, article.price]).to eq ['500 g', 20, 1.20]
+          end
+        end
 
-        all("tr select > option")[1].select_option
-        find('input[type="submit"]').click
-        expect(article.reload.deleted?).to be true
+        it "handles missing data" do
+          find('input[type="submit"]').click # to overview
+          find('input[type="submit"]').click # missing category, re-show form
+          expect(find('tr.alert')).to be_present
+          expect(supplier.articles.count).to eq 0
+
+          all("tr select > option")[1].select_option
+          find('input[type="submit"]').click # now it should succeed
+          expect(supplier.articles.count).to eq 1
+        end
       end
-    end
 
-    describe "can convert units when updating" do
-      let!(:article) { create :article, supplier: supplier, order_number: 1, unit: '250 g' }
+      describe "can remove an existing article" do
+        let!(:article) { create(:article, supplier: supplier, name: 'Foobar', order_number: 99999) }
 
-      it do
-        check('articles_convert_units')
-        find('input[type="submit"]').click
-        expect(find("#articles_#{article.id}_name").value).to eq 'Tomatoes'
-        find('input[type="submit"]').click
-        article.reload
-        expect([article.unit, article.unit_quantity, article.price]).to eq ['250 g', 40, 0.6]
+        it do
+          check('articles_outlist_absent')
+          find('input[type="submit"]').click
+          expect(find("#outlisted_articles_#{article.id}", visible: :all)).to be_present
+
+          all("tr select > option")[1].select_option
+          find('input[type="submit"]').click
+          expect(article.reload.deleted?).to be true
+        end
+      end
+
+      describe "can convert units when updating" do
+        let!(:article) { create(:article, supplier: supplier, order_number: 1, unit: '250 g') }
+
+        it do
+          check('articles_convert_units')
+          find('input[type="submit"]').click
+          expect(find("#articles_#{article.id}_name").value).to eq 'Tomatoes'
+          find('input[type="submit"]').click
+          article.reload
+          expect([article.unit, article.unit_quantity, article.price]).to eq ['250 g', 40, 0.6]
+        end
       end
     end
   end