Fixed updating order article in stockit balancing.

app/controllers/finance/order_articles_controller.rb

@@ -26,7 +26,7 @@ class Finance::OrderArticlesController < ApplicationController
     @order = Order.find(params[:order_id])
     @order_article = OrderArticle.find(params[:id])
     begin
-      @order_article.update_article_and_price!(params[:article], params[:article_price], params[:order_article])
+      @order_article.update_article_and_price!(params[:order_article], params[:article], params[:article_price])
     rescue
       render action: :edit
     end

app/models/order_article.rb

@@ -93,7 +93,7 @@ class OrderArticle < ActiveRecord::Base
   end
 
   # Updates order_article and belongings during balancing process
-  def update_article_and_price!(article_attributes, price_attributes, order_article_attributes)
+  def update_article_and_price!(order_article_attributes, article_attributes, price_attributes = nil)
     OrderArticle.transaction do
       # Updates self
       self.update_attributes!(order_article_attributes)
@@ -102,20 +102,22 @@ class OrderArticle < ActiveRecord::Base
       article.update_attributes!(article_attributes)
 
       # Updates article_price belonging to current order article
-      article_price.attributes = price_attributes
+      if price_attributes.present?
-      if article_price.changed?
+        article_price.attributes = price_attributes
-        # Updates also price attributes of article if update_current_price is selected
+        if article_price.changed?
-        if update_current_price
+          # Updates also price attributes of article if update_current_price is selected
-          article.update_attributes!(price_attributes)
+          if update_current_price
-          self.article_price = article.article_prices.first # Assign new created article price to order article
+            article.update_attributes!(price_attributes)
-        else
+            self.article_price = article.article_prices.first # Assign new created article price to order article
-          # Creates a new article_price if neccessary
+          else
-          # Set created_at timestamp to order ends, to make sure the current article price isn't changed
+            # Creates a new article_price if neccessary
-          create_article_price!(price_attributes.merge(created_at: order.ends)) and save
+            # Set created_at timestamp to order ends, to make sure the current article price isn't changed
-        end
+            create_article_price!(price_attributes.merge(created_at: order.ends)) and save
+          end
 
-        # Updates ordergroup values
+          # Updates ordergroup values
-        update_ordergroup_prices
+          update_ordergroup_prices
+        end
       end
     end
   end

app/views/finance/order_articles/_edit.html.haml

@@ -5,18 +5,20 @@
   .modal-body
     = form.input :units_to_order
 
-    = simple_fields_for @order_article.article do |f|
+    = simple_fields_for :article, @order_article.article do |f|
       = f.input :name
       = f.input :order_number
       = f.input :unit
-    = simple_fields_for @order_article.article_price do |f|
-      = f.input :unit_quantity
-      = f.input :price
-      = f.input :tax
-      = f.input :deposit
-
-    = form.input :update_current_price, as: :boolean
 
+    - if @order_article.article.is_a?(StockArticle)
+      %div.alert Preise von Lagerartikeln können nicht geändert werden!
+    - else
+      = simple_fields_for :article_price, @order_article.article_price do |f|
+        = f.input :unit_quantity
+        = f.input :price
+        = f.input :tax
+        = f.input :deposit
+      = form.input :update_current_price, as: :boolean
   .modal-footer
     = button_tag "Schließen", class: 'btn', data: {dismiss: 'modal'}
     = form.submit class: 'btn btn-primary'