API v1 order_articles endpoints

spec/api/v1/order_articles_spec.rb

@@ -0,0 +1,57 @@
+require 'spec_helper'
+
+# Most routes are tested in the swagger_spec, this tests (non-ransack) parameters.
+describe Api::V1::OrderArticlesController, type: :controller do
+  include ApiOAuth
+  let(:api_scopes) { ['orders:read'] }
+
+  let(:json_order_articles) { json_response['order_articles'] }
+  let(:json_order_article_ids) { json_order_articles.map {|joa| joa["id"] } }
+
+  describe "GET :index" do
+    context "with param q[ordered]" do
+      let(:order) { create(:order, article_count: 4) }
+      let(:order_articles) { order.order_articles }
+      before do
+        order_articles[0].update_attributes! quantity: 0, tolerance: 0, units_to_order: 0
+        order_articles[1].update_attributes! quantity: 1, tolerance: 0, units_to_order: 0
+        order_articles[2].update_attributes! quantity: 0, tolerance: 1, units_to_order: 0
+        order_articles[3].update_attributes! quantity: 0, tolerance: 0, units_to_order: 1
+      end
+
+      it "(unset)" do
+        get :index, params: { foodcoop: 'f' }
+        expect(json_order_articles.count).to eq 4
+      end
+
+      it "all" do
+        get :index, params: { foodcoop: 'f', q: { ordered: 'all' } }
+        expect(json_order_article_ids).to match_array order_articles[1..2].map(&:id)
+      end
+
+      it "supplier" do
+        get :index, params: { foodcoop: 'f', q: { ordered: 'supplier' } }
+        expect(json_order_article_ids).to match_array [order_articles[3].id]
+      end
+
+      it "member" do
+        get :index, params: { foodcoop: 'f', q: { ordered: 'member' } }
+        expect(json_order_articles.count).to eq 0
+      end
+
+      context "when ordered by user" do
+        let(:user) { create(:user, :ordergroup) }
+        let(:go) { create(:group_order, order: order, ordergroup: user.ordergroup) }
+        before do
+          create(:group_order_article, group_order: go, order_article: order_articles[1], quantity: 1)
+          create(:group_order_article, group_order: go, order_article: order_articles[2], tolerance: 0)
+        end
+
+        it "member" do
+          get :index, params: { foodcoop: 'f', q: { ordered: 'member' } }
+          expect(json_order_article_ids).to match_array order_articles[1..2].map(&:id)
+        end
+      end
+    end
+  end
+end

spec/api/v1/swagger_spec.rb

@@ -125,6 +125,21 @@ describe 'API v1', type: :apivore, order: :defined do
       it_handles_invalid_token_and_scope(:get, '/orders')
       it_handles_invalid_token_and_scope(:get, '/orders/{id}', ->{ api_auth({'id' => order.id}) })
     end
+
+    context 'order_articles' do
+      let(:api_scopes) { ['orders:read'] }
+      let!(:order_article) { create(:order, article_count: 1).order_articles.first }
+      let!(:stock_article) { create(:stock_article) }
+      let!(:stock_order_article) { create(:stock_order, article_ids: [stock_article.id]).order_articles.first }
+
+      it { is_expected.to validate(:get, '/order_articles', 200, api_auth) }
+      it { is_expected.to validate(:get, '/order_articles/{id}', 200, api_auth({'id' => order_article.id})) }
+      it { is_expected.to validate(:get, '/order_articles/{id}', 200, api_auth({'id' => stock_order_article.id})) }
+      it { is_expected.to validate(:get, '/order_articles/{id}', 404, api_auth({'id' => Article.last.id + 1})) }
+
+      it_handles_invalid_token_and_scope(:get, '/order_articles')
+      it_handles_invalid_token_and_scope(:get, '/order_articles/{id}', ->{ api_auth({'id' => order_article.id}) })
+    end
   end
 
   # needs to be last context so it is always run at the end

spec/factories/article.rb

@@ -11,14 +11,21 @@ FactoryBot.define do
 
     factory :article do
       sequence(:name) { |n| Faker::Lorem.words(number: rand(2..4)).join(' ') + " ##{n}" }
-      supplier { create :supplier }
-      article_category { create :article_category }
+      supplier
+      article_category
     end
 
     factory :shared_article, class: SharedArticle do
       sequence(:name) { |n| Faker::Lorem.words(number: rand(2..4)).join(' ') + " s##{n}" }
       order_number { Faker::Lorem.characters(number: rand(1..12)) }
-      supplier { create :shared_supplier }
+      shared_supplier
+    end
+
+    factory :stock_article, class: StockArticle do
+      sequence(:name) { |n| Faker::Lorem.words(number: rand(2..4)).join(' ') + " ##{n}" }
+      unit_quantity { 1 }
+      supplier
+      article_category
     end
   end
 

spec/support/api_oauth.rb

@@ -0,0 +1,14 @@
+# Dummy OAuth implementation with +current_user+ and scopes
+module ApiOAuth
+  extend ActiveSupport::Concern
+
+  included do
+    let(:user) { build(:user) }
+    let(:api_scopes) { [] } # empty scopes for stricter testing (in reality this would be default_scopes)
+    let(:api_access_token) { double(:acceptable? => true, :accessible? => true, scopes: api_scopes) }
+    before { allow(controller).to receive(:doorkeeper_token) { api_access_token } }
+    before { allow(controller).to receive(:current_user) { user } }
+
+    let(:json_response) { JSON.parse(response.body) }
+  end
+end