chore: rubocop

chore: fix api test conventions

chore: rubocop -A spec/

chore: more rubocop -A

fix failing test

rubocop fixes

removes helper methods that are in my opinion dead code

more rubocop fixes

rubocop -a --auto-gen-config

db/migrate/20181201000100_create_message_recipients.foodsoft_messages.rb

@@ -14,7 +14,7 @@ class CreateMessageRecipients < ActiveRecord::Migration[4.2]
       t.datetime :read_at
     end
 
-    add_index :message_recipients, [:user_id, :read_at]
+    add_index :message_recipients, %i[user_id read_at]
 
     Message.all.each do |m|
       recipients = YAML.load(m.recipients_ids).map do |r|