chore: rubocop

chore: fix api test conventions

chore: rubocop -A spec/

chore: more rubocop -A

fix failing test

rubocop fixes

removes helper methods that are in my opinion dead code

more rubocop fixes

rubocop -a --auto-gen-config
This commit is contained in:
Philipp Rothmann 2023-05-12 13:01:12 +02:00 committed by Philipp Rothmann
parent f6fb804bbe
commit fb2b4d8a8a
331 changed files with 4263 additions and 4507 deletions

View file

@ -9,14 +9,14 @@ module Colors
end
{
:black => 30,
:red => 31,
:green => 32,
:yellow => 33,
:blue => 34,
:magenta => 35,
:cyan => 36,
:white => 37
black: 30,
red: 31,
green: 32,
yellow: 33,
blue: 34,
magenta: 35,
cyan: 36,
white: 37
}.each do |key, color_code|
define_method key do |text|
colorize(text, color_code)
@ -26,31 +26,31 @@ end
include Colors
namespace :foodsoft do
desc "Setup foodsoft"
desc 'Setup foodsoft'
task :setup_development do
puts yellow "This task will help you get your foodcoop running in development."
puts yellow 'This task will help you get your foodcoop running in development.'
setup_bundler
setup_app_config
setup_development
setup_database
setup_storage
start_mailcatcher
puts yellow "All done! Your foodsoft setup should be running smoothly."
puts yellow 'All done! Your foodsoft setup should be running smoothly.'
start_server
end
desc "Setup foodsoft"
desc 'Setup foodsoft'
task :setup_development_docker do
puts yellow "This task will help you get your foodcoop running in development via docker."
puts yellow 'This task will help you get your foodcoop running in development via docker.'
setup_app_config
setup_development
setup_storage
setup_run_rake_db_setup
puts yellow "All done! Your foodsoft setup should be running smoothly via docker."
puts yellow 'All done! Your foodsoft setup should be running smoothly via docker.'
end
namespace :setup do
desc "Initialize stock configuration"
desc 'Initialize stock configuration'
task :stock_config do
setup_app_config
setup_storage
@ -60,39 +60,39 @@ namespace :foodsoft do
end
def setup_bundler
puts yellow "Installing bundler if not installed..."
puts yellow 'Installing bundler if not installed...'
%x(if [ -z `which bundle` ]; then gem install bundler --no-rdoc --no-ri; fi)
puts yellow "Executing bundle install..."
%x(bundle install)
puts yellow 'Executing bundle install...'
`bundle install`
end
def setup_database
file = 'config/database.yml'
if ENV['DATABASE_URL']
puts blue "DATABASE_URL found, please remember to also set it when running Foodsoft"
puts blue 'DATABASE_URL found, please remember to also set it when running Foodsoft'
return nil
end
return nil if skip?(file)
database = ask("What kind of database do you use?\nOptions:\n(1) MySQL\n(2) SQLite", ["1", "2"])
if database == "1"
puts yellow "Using MySQL..."
%x(cp -p #{Rails.root.join("#{file}.MySQL_SAMPLE")} #{Rails.root.join(file)})
elsif database == "2"
puts yellow "Using SQLite..."
%x(cp -p #{Rails.root.join("#{file}.SQLite_SAMPLE")} #{Rails.root.join(file)})
database = ask("What kind of database do you use?\nOptions:\n(1) MySQL\n(2) SQLite", %w[1 2])
if database == '1'
puts yellow 'Using MySQL...'
`cp -p #{Rails.root.join("#{file}.MySQL_SAMPLE")} #{Rails.root.join(file)}`
elsif database == '2'
puts yellow 'Using SQLite...'
`cp -p #{Rails.root.join("#{file}.SQLite_SAMPLE")} #{Rails.root.join(file)}`
end
reminder(file)
puts blue "IMPORTANT: Edit (rake-generated) config/database.yml with valid username and password for EACH env before continuing!"
finished = ask("Finished?\nOptions:\n(y) Yes", ["y"])
puts blue 'IMPORTANT: Edit (rake-generated) config/database.yml with valid username and password for EACH env before continuing!'
finished = ask("Finished?\nOptions:\n(y) Yes", ['y'])
setup_run_rake_db_setup if finished
end
def setup_run_rake_db_setup
Rake::Task["db:setup"].reenable
db_setup = capture_stdout { Rake::Task["db:setup"].invoke }
Rake::Task['db:setup'].reenable
db_setup = capture_stdout { Rake::Task['db:setup'].invoke }
puts db_setup
end
@ -102,7 +102,7 @@ def setup_app_config
return nil if skip?(file)
puts yellow "Copying #{file}..."
%x(cp -p #{sample} #{Rails.root.join(file)})
`cp -p #{sample} #{Rails.root.join(file)}`
reminder(file)
end
@ -111,7 +111,7 @@ def setup_development
return nil if skip?(file)
puts yellow "Copying #{file}..."
%x(cp -p #{Rails.root.join("#{file}.SAMPLE")} #{Rails.root.join(file)})
`cp -p #{Rails.root.join("#{file}.SAMPLE")} #{Rails.root.join(file)}`
reminder(file)
end
@ -120,18 +120,18 @@ def setup_storage
return nil if skip?(file)
puts yellow "Copying #{file}..."
%x(cp -p #{Rails.root.join("#{file}.SAMPLE")} #{Rails.root.join(file)})
`cp -p #{Rails.root.join("#{file}.SAMPLE")} #{Rails.root.join(file)}`
reminder(file)
end
def start_mailcatcher
return nil if ENV['MAILCATCHER_PORT'] # skip when it has an existing Docker container
mailcatcher = ask("Do you want to start mailcatcher?\nOptions:\n(y) Yes\n(n) No", ["y", "n"])
if mailcatcher === "y"
puts yellow "Starting mailcatcher at http://localhost:1080..."
%x(mailcatcher)
end
mailcatcher = ask("Do you want to start mailcatcher?\nOptions:\n(y) Yes\n(n) No", %w[y n])
return unless mailcatcher === 'y'
puts yellow 'Starting mailcatcher at http://localhost:1080...'
`mailcatcher`
end
def start_server
@ -144,7 +144,7 @@ def ask(question, answers = false)
puts question
input = STDIN.gets.chomp
if input.blank? || (answers && !answers.include?(input))
puts red "Your Input is not valid. Try again!"
puts red 'Your Input is not valid. Try again!'
input = ask(question, answers)
end
input
@ -152,8 +152,11 @@ end
def skip?(file)
output = false
skip = ask(cyan("We found #{file}!\nOptions:\n(1) Skip step\n(2) Force rewrite"), ["1", "2"]) if File.exists?(Rails.root.join(file))
output = true if skip == "1"
if File.exist?(Rails.root.join(file))
skip = ask(cyan("We found #{file}!\nOptions:\n(1) Skip step\n(2) Force rewrite"),
%w[1 2])
end
output = true if skip == '1'
output
end