Foodsoft/foodsoft
1
1
Fork 0
Code Issues 36 Pull requests 5 Projects 1 Releases Wiki Activity

chore: rubocop

Browse source 
chore: fix api test conventions

chore: rubocop -A spec/

chore: more rubocop -A

fix failing test

rubocop fixes

removes helper methods that are in my opinion dead code

more rubocop fixes

rubocop -a --auto-gen-config
This commit is contained in:
Philipp Rothmann 2023-05-12 13:01:12 +02:00 • committed by Philipp Rothmann
parent f6fb804bbe
commit fb2b4d8a8a
331 changed files with 4263 additions and 4507 deletions
Download patch file Download diff file Expand all files Collapse all files

4
plugins/links/app/controllers/admin/links_controller.rb
View file

@ -37,8 +37,8 @@ class Admin::LinksController < Admin::BaseController
link = Link.find(params[:id])
link.destroy!
redirect_to admin_links_path
rescue => error
redirect_to admin_links_path, I18n.t('errors.general_msg', msg: error.message)
rescue StandardError => e
redirect_to admin_links_path, I18n.t('errors.general_msg', msg: e.message)
end
private

10
plugins/links/app/controllers/links_controller.rb
View file

@ -5,9 +5,7 @@ class LinksController < ApplicationController
link = Link.find(params[:id])
url = link.url
if link.workgroup && !current_user.role_admin? && !link.workgroup.member?(current_user)
return deny_access
end
return deny_access if link.workgroup && !current_user.role_admin? && !link.workgroup.member?(current_user)
if link.indirect
uri = URI.parse url
@ -19,11 +17,9 @@ class LinksController < ApplicationController
url = result.header['Location']
unless url
return redirect_to root_url, alert: t('.indirect_no_location')
end
return redirect_to root_url, alert: t('.indirect_no_location') unless url
end
redirect_to url, status: 302
redirect_to url, status: :found
end
end