chore: rubocop

chore: fix api test conventions

chore: rubocop -A spec/

chore: more rubocop -A

fix failing test

rubocop fixes

removes helper methods that are in my opinion dead code

more rubocop fixes

rubocop -a --auto-gen-config

plugins/messages/lib/foodsoft_messages.rb

@@ -1,7 +1,7 @@
-require "foodsoft_messages/engine"
-require "foodsoft_messages/mail_receiver"
-require "foodsoft_messages/user_link"
-require "deface"
+require 'foodsoft_messages/engine'
+require 'foodsoft_messages/mail_receiver'
+require 'foodsoft_messages/user_link'
+require 'deface'
 
 module FoodsoftMessages
   # Return whether messages are used or not.

plugins/messages/lib/foodsoft_messages/engine.rb

@@ -12,15 +12,16 @@ module FoodsoftMessages
           sub_nav.items.insert(i, sub_nav.items.delete_at(-1))
         end
       end
-      unless primary[:admin].nil?
-        sub_nav = primary[:admin].sub_navigation
-        sub_nav.items <<
-          SimpleNavigation::Item.new(primary, :messagegroups, I18n.t('navigation.admin.messagegroups'), context.admin_messagegroups_path)
-        # move to right before config item
-        if i = sub_nav.items.index(sub_nav[:config])
-          sub_nav.items.insert(i, sub_nav.items.delete_at(-1))
-        end
-      end
+      return if primary[:admin].nil?
+
+      sub_nav = primary[:admin].sub_navigation
+      sub_nav.items <<
+        SimpleNavigation::Item.new(primary, :messagegroups, I18n.t('navigation.admin.messagegroups'),
+                                   context.admin_messagegroups_path)
+      # move to right before config item
+      return unless i = sub_nav.items.index(sub_nav[:config])
+
+      sub_nav.items.insert(i, sub_nav.items.delete_at(-1))
     end
 
     def default_foodsoft_config(cfg)

plugins/messages/lib/foodsoft_messages/user_link.rb

@@ -8,7 +8,7 @@ module FoodsoftMessages
             show_user user
           else
             link_to show_user(user), new_message_path('message[mail_to]' => user.id),
-                    :title => I18n.t('helpers.messages.write_message')
+                    title: I18n.t('helpers.messages.write_message')
           end
         end
       end
@@ -18,5 +18,5 @@ end
 
 # modify existing helper
 ActiveSupport.on_load(:after_initialize) do
-  ApplicationHelper.send :include, FoodsoftMessages::UserLink
+  ApplicationHelper.include FoodsoftMessages::UserLink
 end

plugins/messages/lib/foodsoft_messages/version.rb

@@ -1,3 +1,3 @@
 module FoodsoftMessages
-  VERSION = "0.0.1"
+  VERSION = '0.0.1'
 end