chore: rubocop

chore: fix api test conventions

chore: rubocop -A spec/

chore: more rubocop -A

fix failing test

rubocop fixes

removes helper methods that are in my opinion dead code

more rubocop fixes

rubocop -a --auto-gen-config

plugins/printer/lib/foodsoft_printer/engine.rb

@@ -3,18 +3,19 @@ module FoodsoftPrinter
     def navigation(primary, context)
       return unless FoodsoftPrinter.enabled?
 
-      unless primary[:orders].nil?
-        sub_nav = primary[:orders].sub_navigation
-        sub_nav.items <<
-          SimpleNavigation::Item.new(primary, :printer_jobs, I18n.t('navigation.orders.printer_jobs'), context.printer_jobs_path)
-      end
+      return if primary[:orders].nil?
+
+      sub_nav = primary[:orders].sub_navigation
+      sub_nav.items <<
+        SimpleNavigation::Item.new(primary, :printer_jobs, I18n.t('navigation.orders.printer_jobs'),
+                                   context.printer_jobs_path)
     end
 
     def default_foodsoft_config(cfg)
       cfg[:use_printer] = false
     end
 
-    initializer 'foodsoft_printer.order_printer_jobs' do |app|
+    initializer 'foodsoft_printer.order_printer_jobs' do |_app|
       if Rails.configuration.cache_classes
         OrderPrinterJobs.install
       else

plugins/printer/lib/foodsoft_printer/order_printer_jobs.rb

@@ -4,14 +4,14 @@ module FoodsoftPrinter
       base.class_eval do
         has_many :printer_jobs, dependent: :destroy
 
-        alias foodsoft_printer_orig_finish! finish!
+        alias_method :foodsoft_printer_orig_finish!, :finish!
 
         def finish!(user)
           foodsoft_printer_orig_finish!(user)
-          unless finished?
-            printer_jobs.unfinished.each do |job|
-              job.add_update! 'ready'
-            end
+          return if finished?
+
+          printer_jobs.unfinished.each do |job|
+            job.add_update! 'ready'
           end
         end
       end

plugins/printer/lib/foodsoft_printer/version.rb

@@ -1,3 +1,3 @@
 module FoodsoftPrinter
-  VERSION = "0.0.1"
+  VERSION = '0.0.1'
 end