chore: rubocop

chore: fix api test conventions

chore: rubocop -A spec/

chore: more rubocop -A

fix failing test

rubocop fixes

removes helper methods that are in my opinion dead code

more rubocop fixes

rubocop -a --auto-gen-config

plugins/uservoice/foodsoft_uservoice.gemspec

@@ -1,20 +1,21 @@
-$:.push File.expand_path("../lib", __FILE__)
+$:.push File.expand_path('lib', __dir__)
 
 # Maintain your gem's version:
-require "foodsoft_uservoice/version"
+require 'foodsoft_uservoice/version'
 
 # Describe your gem and declare its dependencies:
 Gem::Specification.new do |s|
-  s.name        = "foodsoft_uservoice"
+  s.name        = 'foodsoft_uservoice'
   s.version     = FoodsoftUservoice::VERSION
-  s.authors     = ["wvengen"]
-  s.email       = ["dev-foodsoft@willem.engen.nl"]
-  s.homepage    = "https://github.com/foodcoops/foodsoft"
-  s.summary     = "Uservoice plugin for foodsoft."
-  s.description = "Adds a uservoice feedback button to foodsoft."
+  s.authors     = ['wvengen']
+  s.email       = ['dev-foodsoft@willem.engen.nl']
+  s.homepage    = 'https://github.com/foodcoops/foodsoft'
+  s.summary     = 'Uservoice plugin for foodsoft.'
+  s.description = 'Adds a uservoice feedback button to foodsoft.'
 
-  s.files = Dir["{app,config,db,lib}/**/*"] + ["README.md"]
+  s.files = Dir['{app,config,db,lib}/**/*'] + ['README.md']
 
-  s.add_dependency "rails"
-  s.add_dependency "content_for_in_controllers"
+  s.add_dependency 'rails'
+  s.add_dependency 'content_for_in_controllers'
+  s.metadata['rubygems_mfa_required'] = 'true'
 end

plugins/uservoice/lib/foodsoft_uservoice.rb

@@ -1,5 +1,5 @@
-require "content_for_in_controllers"
-require "foodsoft_uservoice/engine"
+require 'content_for_in_controllers'
+require 'foodsoft_uservoice/engine'
 
 module FoodsoftUservoice
   # enabled when configured, but can still be disabled by use_uservoice option
@@ -19,11 +19,11 @@ module FoodsoftUservoice
 
           # include uservoice javascript
           api_key = FoodsoftConfig[:uservoice]['api_key']
-          js_pre = "UserVoice=window.UserVoice||[];"
+          js_pre = 'UserVoice=window.UserVoice||[];'
           js_load = "var uv=document.createElement('script');uv.type='text/javascript';uv.async=true;uv.src='//widget.uservoice.com/#{view_context.j api_key}.js';var s=document.getElementsByTagName('script')[0];s.parentNode.insertBefore(uv,s);"
 
           # configuration
-          sections = FoodsoftConfig[:uservoice].reject { |k, v| k == 'api_key' }
+          sections = FoodsoftConfig[:uservoice].except('api_key')
           sections.each_pair do |k, v|
             if k == 'identify'
               v['id'] = current_user.try(:id) if v.include?('id')
@@ -48,5 +48,5 @@ module FoodsoftUservoice
 end
 
 ActiveSupport.on_load(:after_initialize) do
-  ApplicationController.send :include, FoodsoftUservoice::LoadUservoice
+  ApplicationController.include FoodsoftUservoice::LoadUservoice
 end

plugins/uservoice/lib/foodsoft_uservoice/version.rb

@@ -1,3 +1,3 @@
 module FoodsoftUservoice
-  VERSION = "0.0.1"
+  VERSION = '0.0.1'
 end