Foodsoft/foodsoft
1
1
Fork 0
Code Issues 36 Pull requests 5 Projects 1 Releases Wiki Activity

chore: rubocop

Browse source 
chore: fix api test conventions

chore: rubocop -A spec/

chore: more rubocop -A

fix failing test

rubocop fixes

removes helper methods that are in my opinion dead code

more rubocop fixes

rubocop -a --auto-gen-config
This commit is contained in:
Philipp Rothmann 2023-05-12 13:01:12 +02:00 • committed by Philipp Rothmann
parent f6fb804bbe
commit fb2b4d8a8a
331 changed files with 4263 additions and 4507 deletions
Download patch file Download diff file Expand all files Collapse all files

19
spec/controllers/home_controller_spec.rb
View file

@ -2,8 +2,8 @@
require 'spec_helper'
describe HomeController, type: :controller do
let(:user) { create :user }
describe HomeController do
let(:user) { create(:user) }
describe 'GET index' do
describe 'NOT logged in' do
@ -45,7 +45,7 @@ describe HomeController, type: :controller do
end
describe 'with ordergroup user' do
let(:og_user) { create :user, :ordergroup }
let(:og_user) { create(:user, :ordergroup) }
before { login og_user }
@ -59,7 +59,7 @@ describe HomeController, type: :controller do
describe 'GET update_profile' do
describe 'with simple user' do
let(:unchanged_attributes) { user.attributes.slice('first_name', 'last_name', 'email') }
let(:changed_attributes) { attributes_for :user }
let(:changed_attributes) { attributes_for(:user) }
let(:invalid_attributes) { { email: 'e.mail.com' } }
before { login user }
@ -80,12 +80,13 @@ describe HomeController, type: :controller do
expect(response).to have_http_status(:redirect)
expect(response).to redirect_to(my_profile_path)
expect(flash[:notice]).to match(/#{I18n.t('home.changes_saved')}/)
expect(user.reload.attributes.slice(:first_name, :last_name, :email)).to eq(changed_attributes.slice('first_name', 'last_name', 'email'))
expect(user.reload.attributes.slice(:first_name, :last_name,
:email)).to eq(changed_attributes.slice('first_name', 'last_name', 'email'))
end
end
describe 'with ordergroup user' do
let(:og_user) { create :user, :ordergroup }
let(:og_user) { create(:user, :ordergroup) }
let(:unchanged_attributes) { og_user.attributes.slice('first_name', 'last_name', 'email') }
let(:changed_attributes) { unchanged_attributes.merge({ ordergroup: { contact_address: 'new Adress 7' } }) }
@ -112,7 +113,7 @@ describe HomeController, type: :controller do
end
describe 'with ordergroup user' do
let(:og_user) { create :user, :ordergroup }
let(:og_user) { create(:user, :ordergroup) }
before { login og_user }
@ -132,13 +133,13 @@ describe HomeController, type: :controller do
get_with_defaults :cancel_membership
end.to raise_error(ActiveRecord::RecordNotFound)
expect do
get_with_defaults :cancel_membership, params: { membership_id: 424242 }
get_with_defaults :cancel_membership, params: { membership_id: 424_242 }
end.to raise_error(ActiveRecord::RecordNotFound)
end
end
describe 'with ordergroup user' do
let(:fin_user) { create :user, :role_finance }
let(:fin_user) { create(:user, :role_finance) }
before { login fin_user }