chore: rubocop

chore: fix api test conventions

chore: rubocop -A spec/

chore: more rubocop -A

fix failing test

rubocop fixes

removes helper methods that are in my opinion dead code

more rubocop fixes

rubocop -a --auto-gen-config

spec/factories/delivery.rb

@@ -2,7 +2,7 @@ require 'factory_bot'
 
 FactoryBot.define do
   factory :delivery do
-    supplier { create :supplier }
+    supplier { create(:supplier) }
     date { Time.now }
   end
 end

spec/factories/group_order.rb

@@ -4,6 +4,6 @@ FactoryBot.define do
   # requires order
   factory :group_order do
     ordergroup { create(:user, groups: [FactoryBot.create(:ordergroup)]).ordergroup }
-    updated_by { create :user }
+    updated_by { create(:user) }
   end
 end

spec/factories/invoice.rb

@@ -3,9 +3,9 @@ require 'factory_bot'
 FactoryBot.define do
   factory :invoice do
     supplier
-    number { rand(1..99999) }
+    number { rand(1..99_999) }
     amount { rand(0.1..26.0).round(2) }
-    created_by { create :user }
+    created_by { create(:user) }
 
     after :create do |invoice|
       invoice.supplier.reload

spec/factories/order.rb

@@ -3,10 +3,10 @@ require 'factory_bot'
 FactoryBot.define do
   factory :order do
     starts { Time.now }
-    supplier { create :supplier, article_count: (article_count.nil? ? true : article_count) }
+    supplier { create(:supplier, article_count: (article_count.nil? ? true : article_count)) }
     article_ids { supplier.articles.map(&:id) unless supplier.nil? }
-    created_by { create :user }
-    updated_by { create :user }
+    created_by { create(:user) }
+    updated_by { create(:user) }
 
     transient do
       article_count { true }

spec/factories/supplier.rb

@@ -10,8 +10,8 @@ FactoryBot.define do
       article_count { 0 }
     end
 
-    before :create do |supplier, evaluator|
-      next if supplier.class == SharedSupplier
+    before :create do |supplier, _evaluator|
+      next if supplier.instance_of?(SharedSupplier)
       next if supplier.supplier_category_id?
 
       supplier.supplier_category = create :supplier_category
@@ -20,7 +20,7 @@ FactoryBot.define do
     after :create do |supplier, evaluator|
       article_count = evaluator.article_count
       article_count = rand(1..99) if article_count == true
-      create_list :article, article_count, supplier: supplier
+      create_list(:article, article_count, supplier: supplier)
     end
 
     factory :shared_supplier, class: 'SharedSupplier'

spec/factories/user.rb

@@ -10,21 +10,21 @@ FactoryBot.define do
     factory :admin do
       sequence(:nick) { |n| "admin#{n}" }
       first_name { 'Administrator' }
-      after :create do |user, evaluator|
-        create :workgroup, role_admin: true, user_ids: [user.id]
+      after :create do |user, _evaluator|
+        create(:workgroup, role_admin: true, user_ids: [user.id])
       end
     end
 
     trait :ordergroup do
-      after :create do |user, evaluator|
-        create :ordergroup, user_ids: [user.id]
+      after :create do |user, _evaluator|
+        create(:ordergroup, user_ids: [user.id])
       end
     end
 
-    [:ordergroup, :finance, :invoices, :article_meta, :suppliers, :pickups, :orders].each do |role|
+    %i[ordergroup finance invoices article_meta suppliers pickups orders].each do |role|
       trait "role_#{role}".to_sym do
-        after :create do |user, evaluator|
-          create :workgroup, "role_#{role}" => true, user_ids: [user.id]
+        after :create do |user, _evaluator|
+          create(:workgroup, "role_#{role}" => true, user_ids: [user.id])
         end
       end
     end
@@ -37,7 +37,7 @@ FactoryBot.define do
       type { 'Workgroup' }
     end
 
-    factory :ordergroup, class: "Ordergroup" do
+    factory :ordergroup, class: 'Ordergroup' do
       type { 'Ordergroup' }
       sequence(:name) { |n| "Order group ##{n}" }
       # workaround to avoid needing to save the ordergroup