chore: rubocop

chore: fix api test conventions

chore: rubocop -A spec/

chore: more rubocop -A

fix failing test

rubocop fixes

removes helper methods that are in my opinion dead code

more rubocop fixes

rubocop -a --auto-gen-config

spec/factories/group_order.rb

@@ -4,6 +4,6 @@ FactoryBot.define do
   # requires order
   factory :group_order do
     ordergroup { create(:user, groups: [FactoryBot.create(:ordergroup)]).ordergroup }
-    updated_by { create :user }
+    updated_by { create(:user) }
   end
 end