chore: rubocop

chore: fix api test conventions

chore: rubocop -A spec/

chore: more rubocop -A

fix failing test

rubocop fixes

removes helper methods that are in my opinion dead code

more rubocop fixes

rubocop -a --auto-gen-config
This commit is contained in:
Philipp Rothmann 2023-05-12 13:01:12 +02:00 committed by Philipp Rothmann
parent f6fb804bbe
commit fb2b4d8a8a
331 changed files with 4263 additions and 4507 deletions

View file

@ -10,8 +10,8 @@ FactoryBot.define do
article_count { 0 }
end
before :create do |supplier, evaluator|
next if supplier.class == SharedSupplier
before :create do |supplier, _evaluator|
next if supplier.instance_of?(SharedSupplier)
next if supplier.supplier_category_id?
supplier.supplier_category = create :supplier_category
@ -20,7 +20,7 @@ FactoryBot.define do
after :create do |supplier, evaluator|
article_count = evaluator.article_count
article_count = rand(1..99) if article_count == true
create_list :article, article_count, supplier: supplier
create_list(:article, article_count, supplier: supplier)
end
factory :shared_supplier, class: 'SharedSupplier'