Foodsoft/foodsoft
1
1
Fork 0
Code Issues 36 Pull requests 5 Projects 1 Releases Wiki Activity

chore: rubocop

Browse source 
chore: fix api test conventions

chore: rubocop -A spec/

chore: more rubocop -A

fix failing test

rubocop fixes

removes helper methods that are in my opinion dead code

more rubocop fixes

rubocop -a --auto-gen-config
This commit is contained in:
Philipp Rothmann 2023-05-12 13:01:12 +02:00 • committed by Philipp Rothmann
parent f6fb804bbe
commit fb2b4d8a8a
331 changed files with 4263 additions and 4507 deletions
Download patch file Download diff file Expand all files Collapse all files

16
spec/factories/user.rb
View file

@ -10,21 +10,21 @@ FactoryBot.define do
factory :admin do
sequence(:nick) { |n| "admin#{n}" }
first_name { 'Administrator' }
after :create do |user, evaluator|
create :workgroup, role_admin: true, user_ids: [user.id]
after :create do |user, _evaluator|
create(:workgroup, role_admin: true, user_ids: [user.id])
end
end
trait :ordergroup do
after :create do |user, evaluator|
create :ordergroup, user_ids: [user.id]
after :create do |user, _evaluator|
create(:ordergroup, user_ids: [user.id])
end
end
[:ordergroup, :finance, :invoices, :article_meta, :suppliers, :pickups, :orders].each do |role|
%i[ordergroup finance invoices article_meta suppliers pickups orders].each do |role|
trait "role_#{role}".to_sym do
after :create do |user, evaluator|
create :workgroup, "role_#{role}" => true, user_ids: [user.id]
after :create do |user, _evaluator|
create(:workgroup, "role_#{role}" => true, user_ids: [user.id])
end
end
end
@ -37,7 +37,7 @@ FactoryBot.define do
type { 'Workgroup' }
end
factory :ordergroup, class: "Ordergroup" do
factory :ordergroup, class: 'Ordergroup' do
type { 'Ordergroup' }
sequence(:name) { |n| "Order group ##{n}" }
# workaround to avoid needing to save the ordergroup