chore: rubocop

chore: fix api test conventions

chore: rubocop -A spec/

chore: more rubocop -A

fix failing test

rubocop fixes

removes helper methods that are in my opinion dead code

more rubocop fixes

rubocop -a --auto-gen-config

spec/integration/session_spec.rb

@@ -1,7 +1,7 @@
 require_relative '../spec_helper'
 
 feature 'the session' do
-  let(:user) { create :user }
+  let(:user) { create(:user) }
 
   describe 'login page' do
     it 'is accessible' do
@@ -11,7 +11,7 @@ feature 'the session' do
 
     it 'logs me in' do
       login user
-      expect(page).to_not have_selector('.alert-error')
+      expect(page).not_to have_selector('.alert-error')
     end
 
     it 'does not log me in with wrong password' do
@@ -21,10 +21,10 @@ feature 'the session' do
 
     it 'can log me in using an email address' do
       visit login_path
-      fill_in 'nick', :with => user.email
-      fill_in 'password', :with => user.password
+      fill_in 'nick', with: user.email
+      fill_in 'password', with: user.password
       find('input[type=submit]').click
-      expect(page).to_not have_selector('.alert-error')
+      expect(page).not_to have_selector('.alert-error')
     end
   end
 end