Foodsoft/foodsoft
1
1
Fork 0
Code Issues 36 Pull requests 5 Projects 1 Releases Wiki Activity

chore: rubocop

Browse source 
chore: fix api test conventions

chore: rubocop -A spec/

chore: more rubocop -A

fix failing test

rubocop fixes

removes helper methods that are in my opinion dead code

more rubocop fixes

rubocop -a --auto-gen-config
This commit is contained in:
Philipp Rothmann 2023-05-12 13:01:12 +02:00 • committed by Philipp Rothmann
parent f6fb804bbe
commit fb2b4d8a8a
331 changed files with 4263 additions and 4507 deletions
Download patch file Download diff file Expand all files Collapse all files

59
spec/models/order_spec.rb
View file

@ -1,14 +1,14 @@
require_relative '../spec_helper'
describe Order do
let!(:ftt) { create :financial_transaction_type }
let(:user) { create :user, groups: [create(:ordergroup)] }
let!(:ftt) { create(:financial_transaction_type) }
let(:user) { create(:user, groups: [create(:ordergroup)]) }
it 'automaticly finishes ended' do
create :order, created_by: user, starts: Date.yesterday, ends: 1.hour.from_now
create :order, created_by: user, starts: Date.yesterday, ends: 1.hour.ago
create :order, created_by: user, starts: Date.yesterday, ends: 1.hour.from_now, end_action: :auto_close
order = create :order, created_by: user, starts: Date.yesterday, ends: 1.hour.ago, end_action: :auto_close
create(:order, created_by: user, starts: Date.yesterday, ends: 1.hour.from_now)
create(:order, created_by: user, starts: Date.yesterday, ends: 1.hour.ago)
create(:order, created_by: user, starts: Date.yesterday, ends: 1.hour.from_now, end_action: :auto_close)
order = create(:order, created_by: user, starts: Date.yesterday, ends: 1.hour.ago, end_action: :auto_close)
Order.finish_ended!
order.reload
@ -19,10 +19,10 @@ describe Order do
end
describe 'state scopes and boolean getters' do
let!(:open_order) { create :order, state: 'open' }
let!(:finished_order) { create :order, state: 'finished' }
let!(:received_order) { create :order, state: 'received' }
let!(:closed_order) { create :order, state: 'closed' }
let!(:open_order) { create(:order, state: 'open') }
let!(:finished_order) { create(:order, state: 'finished') }
let!(:received_order) { create(:order, state: 'received') }
let!(:closed_order) { create(:order, state: 'closed') }
it 'retrieves open orders in the "open" scope' do
expect(Order.open.count).to eq(1)
@ -72,8 +72,9 @@ describe Order do
end
it 'sends mail if min_order_quantity has been reached' do
create :user, groups: [create(:ordergroup)]
create :order, created_by: user, starts: Date.yesterday, ends: 1.hour.ago, end_action: :auto_close_and_send_min_quantity
create(:user, groups: [create(:ordergroup)])
create(:order, created_by: user, starts: Date.yesterday, ends: 1.hour.ago,
end_action: :auto_close_and_send_min_quantity)
Order.finish_ended!
expect(ActionMailer::Base.deliveries.count).to eq 1
@ -84,7 +85,7 @@ describe Order do
end
it 'needs order articles' do
supplier = create :supplier, article_count: 0
supplier = create(:supplier, article_count: 0)
expect(build(:order, supplier: supplier)).to be_invalid
end
@ -93,35 +94,35 @@ describe Order do
end
describe 'with articles' do
let(:order) { create :order }
let(:order) { create(:order) }
it 'is open by default' do expect(order).to be_open end
it 'is not finished by default' do expect(order).to_not be_finished end
it 'is not closed by default' do expect(order).to_not be_closed end
it 'is not finished by default' do expect(order).not_to be_finished end
it 'is not closed by default' do expect(order).not_to be_closed end
it 'has valid order articles' do
order.order_articles.each { |oa| expect(oa).to be_valid }
end
it 'can be finished' do
# TODO randomise user
# TODO: randomise user
order.finish!(user)
expect(order).to_not be_open
expect(order).not_to be_open
expect(order).to be_finished
expect(order).to_not be_closed
expect(order).not_to be_closed
end
it 'can be closed' do
# TODO randomise user
# TODO: randomise user
order.finish!(user)
order.close!(user)
expect(order).to_not be_open
expect(order).not_to be_open
expect(order).to be_closed
end
end
describe 'with a default end date' do
let(:order) { create :order }
let(:order) { create(:order) }
before do
FoodsoftConfig[:order_schedule] = { ends: { recurr: 'FREQ=WEEKLY;BYDAY=MO', time: '9:00' } }
@ -138,10 +139,10 @@ describe Order do
end
describe 'mapped to GroupOrders' do
let!(:user) { create :user, groups: [create(:ordergroup)] }
let!(:order) { create :order }
let!(:order2) { create :order }
let!(:go) { create :group_order, order: order, ordergroup: user.ordergroup }
let!(:user) { create(:user, groups: [create(:ordergroup)]) }
let!(:order) { create(:order) }
let!(:order2) { create(:order) }
let!(:go) { create(:group_order, order: order, ordergroup: user.ordergroup) }
it 'to map a user\'s GroupOrders to a list of Orders' do
orders = Order.ordergroup_group_orders_map(user.ordergroup)
@ -156,10 +157,10 @@ describe Order do
describe 'balancing charges correct amounts' do
let!(:transport) { rand(0.1..26.0).round(2) }
let!(:order) { create :order, article_count: 1 }
let!(:order) { create(:order, article_count: 1) }
let!(:oa) { order.order_articles.first }
let!(:go) { create :group_order, order: order, transport: transport }
let!(:goa) { create :group_order_article, group_order: go, order_article: oa, quantity: 1 }
let!(:go) { create(:group_order, order: order, transport: transport) }
let!(:goa) { create(:group_order_article, group_order: go, order_article: oa, quantity: 1) }
before do
goa.update_quantities(1, 0)