Foodsoft/foodsoft
1
1
Fork 0
Code Issues 36 Pull requests 5 Projects 1 Releases Wiki Activity

chore: rubocop

Browse source 
chore: fix api test conventions

chore: rubocop -A spec/

chore: more rubocop -A

fix failing test

rubocop fixes

removes helper methods that are in my opinion dead code

more rubocop fixes

rubocop -a --auto-gen-config
This commit is contained in:
Philipp Rothmann 2023-05-12 13:01:12 +02:00 • committed by Philipp Rothmann
parent f6fb804bbe
commit fb2b4d8a8a
331 changed files with 4263 additions and 4507 deletions
Download patch file Download diff file Expand all files Collapse all files

92
spec/models/user_spec.rb
View file

@ -2,9 +2,9 @@ require_relative '../spec_helper'
describe User do
it 'is correctly created' do
user = create :user,
user = create(:user,
nick: 'johnnydoe', first_name: 'Johnny', last_name: 'DoeBar',
email: 'johnnydoe@foodcoop.test', phone: '+1234567890'
email: 'johnnydoe@foodcoop.test', phone: '+1234567890')
expect(user.nick).to eq('johnnydoe')
expect(user.first_name).to eq('Johnny')
expect(user.last_name).to eq('DoeBar')
@ -14,7 +14,7 @@ describe User do
end
describe 'does not have the role' do
let(:user) { create :user }
let(:user) { create(:user) }
it 'admin' do expect(user.role_admin?).to be_falsey end
it 'finance' do expect(user.role_finance?).to be_falsey end
@ -24,7 +24,7 @@ describe User do
end
describe do
let(:user) { create :user, password: 'blahblahblah' }
let(:user) { create(:user, password: 'blahblahblah') }
it 'can authenticate with correct password' do
expect(User.authenticate(user.nick, 'blahblahblah')).to be_truthy
@ -74,124 +74,124 @@ describe User do
end
describe 'admin' do
let(:user) { create :admin }
let(:user) { create(:admin) }
it 'default admin role' do expect(user.role_admin?).to be_truthy end
end
describe 'sort correctly' do
it 'by nick' do
user_b = create :user, nick: 'bbb'
user_a = create :user, nick: 'aaa'
user_c = create :user, nick: 'ccc'
user_b = create(:user, nick: 'bbb')
user_a = create(:user, nick: 'aaa')
user_c = create(:user, nick: 'ccc')
expect(User.sort_by_param('nick')).to eq([user_a, user_b, user_c])
end
it 'reverse by nick' do
user_b = create :user, nick: 'bbb'
user_a = create :user, nick: 'aaa'
user_c = create :user, nick: 'ccc'
user_b = create(:user, nick: 'bbb')
user_a = create(:user, nick: 'aaa')
user_c = create(:user, nick: 'ccc')
expect(User.sort_by_param('nick_reverse')).to eq([user_c, user_b, user_a])
end
it 'by name' do
user_b = create :user, first_name: 'aaa', last_name: 'bbb'
user_a = create :user, first_name: 'aaa', last_name: 'aaa'
user_c = create :user, first_name: 'ccc', last_name: 'aaa'
user_b = create(:user, first_name: 'aaa', last_name: 'bbb')
user_a = create(:user, first_name: 'aaa', last_name: 'aaa')
user_c = create(:user, first_name: 'ccc', last_name: 'aaa')
expect(User.sort_by_param('name')).to eq([user_a, user_b, user_c])
end
it 'reverse by name' do
user_b = create :user, first_name: 'aaa', last_name: 'bbb'
user_a = create :user, first_name: 'aaa', last_name: 'aaa'
user_c = create :user, first_name: 'ccc', last_name: 'aaa'
user_b = create(:user, first_name: 'aaa', last_name: 'bbb')
user_a = create(:user, first_name: 'aaa', last_name: 'aaa')
user_c = create(:user, first_name: 'ccc', last_name: 'aaa')
expect(User.sort_by_param('name_reverse')).to eq([user_c, user_b, user_a])
end
it 'by email' do
user_b = create :user, email: 'bbb@dummy.com'
user_a = create :user, email: 'aaa@dummy.com'
user_c = create :user, email: 'ccc@dummy.com'
user_b = create(:user, email: 'bbb@dummy.com')
user_a = create(:user, email: 'aaa@dummy.com')
user_c = create(:user, email: 'ccc@dummy.com')
expect(User.sort_by_param('email')).to eq([user_a, user_b, user_c])
end
it 'reverse by email' do
user_b = create :user, email: 'bbb@dummy.com'
user_a = create :user, email: 'aaa@dummy.com'
user_c = create :user, email: 'ccc@dummy.com'
user_b = create(:user, email: 'bbb@dummy.com')
user_a = create(:user, email: 'aaa@dummy.com')
user_c = create(:user, email: 'ccc@dummy.com')
expect(User.sort_by_param('email_reverse')).to eq([user_c, user_b, user_a])
end
it 'by phone' do
user_b = create :user, phone: 'bbb'
user_a = create :user, phone: 'aaa'
user_c = create :user, phone: 'ccc'
user_b = create(:user, phone: 'bbb')
user_a = create(:user, phone: 'aaa')
user_c = create(:user, phone: 'ccc')
expect(User.sort_by_param('phone')).to eq([user_a, user_b, user_c])
end
it 'reverse by phone' do
user_b = create :user, phone: 'bbb'
user_a = create :user, phone: 'aaa'
user_c = create :user, phone: 'ccc'
user_b = create(:user, phone: 'bbb')
user_a = create(:user, phone: 'aaa')
user_c = create(:user, phone: 'ccc')
expect(User.sort_by_param('phone_reverse')).to eq([user_c, user_b, user_a])
end
it 'by last_activity' do
user_b = create :user, last_activity: 3.days.ago
user_a = create :user, last_activity: 5.days.ago
user_c = create :user, last_activity: Time.now
user_b = create(:user, last_activity: 3.days.ago)
user_a = create(:user, last_activity: 5.days.ago)
user_c = create(:user, last_activity: Time.now)
expect(User.sort_by_param('last_activity')).to eq([user_a, user_b, user_c])
end
it 'reverse by last_activity' do
user_b = create :user, last_activity: 3.days.ago
user_a = create :user, last_activity: 5.days.ago
user_c = create :user, last_activity: Time.now
user_b = create(:user, last_activity: 3.days.ago)
user_a = create(:user, last_activity: 5.days.ago)
user_c = create(:user, last_activity: Time.now)
expect(User.sort_by_param('last_activity_reverse')).to eq([user_c, user_b, user_a])
end
it 'by ordergroup' do
user_b = create :user, groups: [create(:workgroup, name: 'a'), create(:ordergroup, name: 'bb')]
user_a = create :user, groups: [create(:workgroup, name: 'b'), create(:ordergroup, name: 'aa')]
user_c = create :user, groups: [create(:workgroup, name: 'c'), create(:ordergroup, name: 'cc')]
user_b = create(:user, groups: [create(:workgroup, name: 'a'), create(:ordergroup, name: 'bb')])
user_a = create(:user, groups: [create(:workgroup, name: 'b'), create(:ordergroup, name: 'aa')])
user_c = create(:user, groups: [create(:workgroup, name: 'c'), create(:ordergroup, name: 'cc')])
expect(User.sort_by_param('ordergroup')).to eq([user_a, user_b, user_c])
end
it 'reverse by ordergroup' do
user_b = create :user, groups: [create(:workgroup, name: 'a'), create(:ordergroup, name: 'bb')]
user_a = create :user, groups: [create(:workgroup, name: 'b'), create(:ordergroup, name: 'aa')]
user_c = create :user, groups: [create(:workgroup, name: 'c'), create(:ordergroup, name: 'cc')]
user_b = create(:user, groups: [create(:workgroup, name: 'a'), create(:ordergroup, name: 'bb')])
user_a = create(:user, groups: [create(:workgroup, name: 'b'), create(:ordergroup, name: 'aa')])
user_c = create(:user, groups: [create(:workgroup, name: 'c'), create(:ordergroup, name: 'cc')])
expect(User.sort_by_param('ordergroup_reverse')).to eq([user_c, user_b, user_a])
end
it 'and users are only listed once' do
create :user
create(:user)
expect(User.sort_by_param('ordergroup').size).to eq(1)
end
it 'and users belonging to a workgroup are only listed once' do
create :admin
create(:admin)
expect(User.sort_by_param('ordergroup').size).to eq(1)
end
it 'and users belonging to 2 ordergroups are only listed once' do
user = create :user
create :ordergroup, user_ids: [user.id]
create :ordergroup, user_ids: [user.id]
user = create(:user)
create(:ordergroup, user_ids: [user.id])
create(:ordergroup, user_ids: [user.id])
expect(User.sort_by_param('ordergroup').size).to eq(1)
end