chore: rubocop

chore: fix api test conventions

chore: rubocop -A spec/

chore: more rubocop -A

fix failing test

rubocop fixes

removes helper methods that are in my opinion dead code

more rubocop fixes

rubocop -a --auto-gen-config

spec/requests/api/v1/article_categories_controller_spec.rb

@@ -1,6 +1,6 @@
 require 'swagger_helper'
 
-describe 'Article Categories', type: :request do
+describe Api::V1::ArticleCategoriesController do
   include ApiHelper
 
   path '/article_categories' do

spec/requests/api/v1/configs_controller_spec.rb

@@ -1,6 +1,6 @@
 require 'swagger_helper'
 
-describe 'Config', type: :request do
+describe Api::V1::ConfigsController do
   include ApiHelper
 
   path '/config' do

spec/requests/api/v1/financial_transaction_classes_controller_spec.rb

@@ -1,6 +1,6 @@
 require 'swagger_helper'
 
-describe 'Financial Transaction Classes', type: :request do
+describe Api::V1::FinancialTransactionClassesController do
   include ApiHelper
 
   path '/financial_transaction_classes' do

spec/requests/api/v1/financial_transaction_types_controller_spec.rb

@@ -1,6 +1,6 @@
 require 'swagger_helper'
 
-describe 'Financial Transaction types', type: :request do
+describe Api::V1::FinancialTransactionTypesController do
   include ApiHelper
 
   path '/financial_transaction_types' do

spec/requests/api/v1/financial_transactions_controller_spec.rb

@@ -1,10 +1,12 @@
 require 'swagger_helper'
 
-describe 'Financial Transaction', type: :request do
+describe Api::V1::FinancialTransactionsController do
   include ApiHelper
   let!(:finance_user) { create(:user, groups: [create(:workgroup, role_finance: true)]) }
   let!(:api_scopes) { ['finance:read', 'finance:write'] }
-  let(:api_access_token) { create(:oauth2_access_token, resource_owner_id: finance_user.id, scopes: api_scopes&.join(' ')).token }
+  let(:api_access_token) do
+    create(:oauth2_access_token, resource_owner_id: finance_user.id, scopes: api_scopes&.join(' ')).token
+  end
   let(:financial_transaction) { create(:financial_transaction, user: user) }
 
   path '/financial_transactions' do

spec/requests/api/v1/navigations_controller_spec.rb

@@ -1,6 +1,6 @@
 require 'swagger_helper'
 
-describe 'Navigation', type: :request do
+describe Api::V1::NavigationsController do
   include ApiHelper
 
   path '/navigation' do

spec/requests/api/v1/order_articles_controller_spec.rb

@@ -1,6 +1,6 @@
 require 'swagger_helper'
 
-describe 'Order Articles', type: :request do
+describe Api::V1::OrderArticlesController do
   include ApiHelper
 
   path '/order_articles' do

spec/requests/api/v1/orders_controller_spec.rb

@@ -1,6 +1,6 @@
 require 'swagger_helper'
 
-describe 'Orders', type: :request do
+describe Api::V1::OrdersController do
   include ApiHelper
   let(:api_scopes) { ['orders:read'] }
 

spec/requests/api/v1/user/financial_transactions_spec.rb

@@ -1,11 +1,11 @@
 require 'swagger_helper'
 
-describe 'User', type: :request do
+describe 'User' do
   include ApiHelper
 
   let(:api_scopes) { ['finance:user'] }
-  let(:user) { create :user, groups: [create(:ordergroup)] }
-  let(:other_user2) { create :user }
+  let(:user) { create(:user, groups: [create(:ordergroup)]) }
+  let(:other_user2) { create(:user) }
   let(:ft) { create(:financial_transaction, user: user, ordergroup: user.ordergroup) }
 
   before do
@@ -27,7 +27,9 @@ describe 'User', type: :request do
         }
       }
 
-      let(:financial_transaction) { { amount: 3, financial_transaction_type_id: create(:financial_transaction_type).id, note: 'lirum larum' } }
+      let(:financial_transaction) do
+        { amount: 3, financial_transaction_type_id: create(:financial_transaction_type).id, note: 'lirum larum' }
+      end
 
       response '200', 'success' do
         schema type: :object, properties: {

spec/requests/api/v1/user/group_order_articles_spec.rb

@@ -1,15 +1,15 @@
 require 'swagger_helper'
 
-describe 'User', type: :request do
+describe 'User' do
   include ApiHelper
 
   let(:api_scopes) { ['group_orders:user'] }
-  let(:user) { create :user, groups: [create(:ordergroup)] }
-  let(:other_user2) { create :user }
+  let(:user) { create(:user, groups: [create(:ordergroup)]) }
+  let(:other_user2) { create(:user) }
   let(:order) { create(:order, article_count: 4) }
   let(:order_articles) { order.order_articles }
-  let(:group_order) { create :group_order, ordergroup: user.ordergroup, order_id: order.id }
-  let(:goa) { create :group_order_article, group_order: group_order, order_article: order_articles.first }
+  let(:group_order) { create(:group_order, ordergroup: user.ordergroup, order_id: order.id) }
+  let(:goa) { create(:group_order_article, group_order: group_order, order_article: order_articles.first) }
 
   before do
     goa
@@ -134,11 +134,12 @@ describe 'User', type: :request do
 
       response 401, 'not logged-in' do
         schema '$ref' => '#/components/schemas/Error401'
-        let(:Authorization) { 'abc' }
+        let(:Authorization) { 'abc' } # rubocop:disable  RSpec/VariableName
         run_test!
       end
 
-      response 403, 'user has no ordergroup, order not open, is below minimum balance, has not enough apple points, or missing scope' do
+      response 403,
+               'user has no ordergroup, order not open, is below minimum balance, has not enough apple points, or missing scope' do
         let(:api_scopes) { ['none'] }
         schema '$ref' => '#/components/schemas/Error403'
         run_test!
@@ -180,7 +181,8 @@ describe 'User', type: :request do
 
       it_handles_invalid_token_with_id
 
-      response 403, 'user has no ordergroup, order not open, is below minimum balance, has not enough apple points, or missing scope' do
+      response 403,
+               'user has no ordergroup, order not open, is below minimum balance, has not enough apple points, or missing scope' do
         let(:api_scopes) { ['none'] }
         schema '$ref' => '#/components/schemas/Error403'
         run_test!

spec/requests/api/v1/user/users_spec.rb

@@ -1,6 +1,6 @@
 require 'swagger_helper'
 
-describe 'User', type: :request do
+describe 'User' do
   include ApiHelper
 
   path '/user' do
@@ -8,9 +8,9 @@ describe 'User', type: :request do
       tags 'User'
       produces 'application/json'
       let(:api_scopes) { ['user:read'] }
-      let(:other_user1) { create :user }
-      let(:user) { create :user }
-      let(:other_user2) { create :user }
+      let(:other_user1) { create(:user) }
+      let(:user) { create(:user) }
+      let(:other_user2) { create(:user) }
 
       response '200', 'success' do
         schema type: :object,
@@ -52,7 +52,7 @@ describe 'User', type: :request do
     get 'financial summary about the currently logged-in user' do
       tags 'User', 'Financial Transaction'
       produces 'application/json'
-      let(:user) { create :user, :ordergroup }
+      let(:user) { create(:user, :ordergroup) }
       let(:api_scopes) { ['finance:user'] }
       FinancialTransactionClass.create(name: 'TestTransaction')