Testabdeckung erhöhen #8

Open
opened 2022-09-08 12:15:20 +02:00 by tk · 1 comment
Owner
  1) Auth concern protected/private methods #deny_access redirects to root_url
     # Temporarily skipped with xit
     # ./spec/controllers/concerns/auth_concern_spec.rb:65
  2) Auth concern protected/private methods #login_and_redirect_to_return_to redirects to already set target
     # Temporarily skipped with xit
     # ./spec/controllers/concerns/auth_concern_spec.rb:80
  • mention it in pr to be fixed / refactored in seperate pr?

  3) ArticlesController#sync updates particles from spreadsheet
     # Temporarily skipped with xit
     # ./spec/controllers/articles_controller_spec.rb:186
  4) ArticlesController#update_synchronized does not update articles if article with same name exists
     # Temporarily skipped with xit
     # ./spec/controllers/articles_controller_spec.rb:240
  • balancing_controller_test.rb TODO

  • Einzelne PRs erstellen

    • Gems + home_controller.rb
    • login_controller.rb
    • finance/balancing_controller.rb
      finance/base_controller.rb
    • application_controller.rb
    • articles_controller.rb
    • concerns/auth_concern.rb
* [x] Model tests PR https://github.com/foodcoops/foodsoft/pull/966 * [ ] Controller Tests https://github.com/foodcoops/foodsoft/pull/970 * [x] fix rubocop * [x] `/auth_concern_spec.rb:83:16: C: RSpec/NamedSubject: Name your test subject if you need to reference it explicitly.` * [x] ``` 1) Auth concern protected/private methods #deny_access redirects to root_url # Temporarily skipped with xit # ./spec/controllers/concerns/auth_concern_spec.rb:65 ``` * [x] ``` 2) Auth concern protected/private methods #login_and_redirect_to_return_to redirects to already set target # Temporarily skipped with xit # ./spec/controllers/concerns/auth_concern_spec.rb:80 ``` * [x] mention it in pr to be fixed / refactored in seperate pr? ``` 3) ArticlesController#sync updates particles from spreadsheet # Temporarily skipped with xit # ./spec/controllers/articles_controller_spec.rb:186 ``` * [x] ``` 4) ArticlesController#update_synchronized does not update articles if article with same name exists # Temporarily skipped with xit # ./spec/controllers/articles_controller_spec.rb:240 ``` * [x] balancing_controller_test.rb TODO * Einzelne PRs erstellen * [x] Gems + home_controller.rb * [ ] login_controller.rb * [ ] finance/balancing_controller.rb finance/base_controller.rb * [ ] application_controller.rb * [ ] articles_controller.rb * [ ] concerns/auth_concern.rb
tk added this to the Tests milestone 2022-09-08 12:15:20 +02:00
philipp self-assigned this 2022-11-07 12:27:00 +01:00
philipp added this to the Kanban project 2022-11-21 11:32:20 +01:00
Owner

Controller Tests brauchen einen Rewrite, damit sie nicht mehr das Plugin verwenden und idiomatischer sind und die Controller boundries nicht überschreiten

Controller Tests brauchen einen Rewrite, damit sie nicht mehr das Plugin verwenden und idiomatischer sind und die Controller boundries nicht überschreiten
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Foodsoft/foodsoft#8
No description provided.