From cd824c2bf274931a3b46b1f49b480130a3a99efa Mon Sep 17 00:00:00 2001 From: Daniel Date: Thu, 30 Nov 2023 19:21:46 +0100 Subject: [PATCH] small dir improvements --- src/dirmanager.py | 4 ++-- src/runner.py | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/dirmanager.py b/src/dirmanager.py index c210d25..b5228bf 100644 --- a/src/dirmanager.py +++ b/src/dirmanager.py @@ -30,12 +30,12 @@ class DirManager: ) @property - def OUTPUT(self): + def OUTPUT_DIR(self): return self._output_dir @property def SESSION(self): - return self._output_dir / f"test-{self.session_id}" + return self.OUTPUT_DIR / f"test-{self.session_id}" @property def RECORDS(self): diff --git a/src/runner.py b/src/runner.py index 1e2cc6f..f069eda 100644 --- a/src/runner.py +++ b/src/runner.py @@ -117,13 +117,14 @@ class Runner: command_arguments.append("--env_file") command_arguments.append(str(self.dotenv_path)) + # set root dir for tests output (used in DirManager). this is our custom argument command_arguments.append("--output_dir") - command_arguments.append(str(self.DIRS.OUTPUT)) + command_arguments.append(str(self.DIRS.OUTPUT_DIR)) command_arguments.append("--session_id") command_arguments.append(self.session_id) - # artifacts dir + # artifacts dir from pytest # warning: https://github.com/microsoft/playwright-pytest/issues/111 # --output only works with the given context and page fixture # folder needs to be unique! traces will not appear, if every pytest run has same output dir