From 0abcf540bb7c9696673b21cb1ce0d759a3c2dc72 Mon Sep 17 00:00:00 2001 From: Moritz Date: Tue, 20 Jan 2026 15:58:15 +0100 Subject: [PATCH] refactor: Replace length/1 with empty list comparison Replace expensive length/1 calls with direct list comparison to fix Credo warnings about performance --- lib/mv_web/live/member_live/form.ex | 2 +- test/mv/membership/import/member_csv_test.exs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/mv_web/live/member_live/form.ex b/lib/mv_web/live/member_live/form.ex index c0b034e..f07be75 100644 --- a/lib/mv_web/live/member_live/form.ex +++ b/lib/mv_web/live/member_live/form.ex @@ -403,7 +403,7 @@ defmodule MvWeb.MemberLive.Form do # Checks if form has any errors defp has_form_errors?(form) do case Map.get(form, :errors) do - errors when is_list(errors) and length(errors) > 0 -> true + errors when is_list(errors) and errors != [] -> true _ -> false end end diff --git a/test/mv/membership/import/member_csv_test.exs b/test/mv/membership/import/member_csv_test.exs index b5af238..98943d5 100644 --- a/test/mv/membership/import/member_csv_test.exs +++ b/test/mv/membership/import/member_csv_test.exs @@ -404,7 +404,7 @@ defmodule Mv.Membership.Import.MemberCSVTest do assert chunk_result.inserted == 0 assert chunk_result.failed == 10 - assert length(chunk_result.errors) == 0 + assert chunk_result.errors == [] end test "error capping with mixed success and failure" do