diff --git a/lib/mv_web/live/join_request_live/show.ex b/lib/mv_web/live/join_request_live/show.ex index 2aab87d..cdc6521 100644 --- a/lib/mv_web/live/join_request_live/show.ex +++ b/lib/mv_web/live/join_request_live/show.ex @@ -222,9 +222,9 @@ defmodule MvWeb.JoinRequestLive.Show do defp field_row(assigns) do ~H""" -
- {@label}: - +
+
{@label}:
+
<%= if @value && @value != "" do %> {@value} <% else %> @@ -232,8 +232,8 @@ defmodule MvWeb.JoinRequestLive.Show do {@empty_text || gettext("Not specified")} <% end %> - -
+ + """ end diff --git a/test/mv_web/live/join_request_live/show_test.exs b/test/mv_web/live/join_request_live/show_test.exs index 35e87dc..5497d22 100644 --- a/test/mv_web/live/join_request_live/show_test.exs +++ b/test/mv_web/live/join_request_live/show_test.exs @@ -63,9 +63,9 @@ defmodule MvWeb.JoinRequestLive.ShowTest do {:ok, view, _html} = live(conn, "/join_requests/#{join_request.id}") - assert has_element?(view, "span", "#{custom_field.name}:") - assert has_element?(view, "span", "Alice Example") - refute has_element?(view, "span", "#{custom_field.id}:") + assert has_element?(view, "dt", "#{custom_field.name}:") + assert has_element?(view, "dd", "Alice Example") + refute has_element?(view, "dt", "#{custom_field.id}:") end end end