From 1dd68bcaf222a986d9dcbc36352d79bec5bb6219 Mon Sep 17 00:00:00 2001 From: carla Date: Tue, 23 Dec 2025 18:08:31 +0100 Subject: [PATCH] feat: coherent required boolean handling --- lib/membership/member.ex | 3 ++- lib/mv_web/live/member_live/form.ex | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/membership/member.ex b/lib/membership/member.ex index ae53116..ad13439 100644 --- a/lib/membership/member.ex +++ b/lib/membership/member.ex @@ -782,7 +782,8 @@ defmodule Mv.Membership.Member do missing_names = Enum.map_join(sorted_missing_fields, ", ", & &1.name) {:error, - field: :custom_field_values, message: "Required custom fields missing: #{missing_names}"} + field: :custom_field_values, + message: Gettext.dgettext(MvWeb.Gettext, "default", "Required custom fields missing: %{fields}", fields: missing_names)} end # Helper function to check if a value is present for a given custom field type diff --git a/lib/mv_web/live/member_live/form.ex b/lib/mv_web/live/member_live/form.ex index dc32824..3378504 100644 --- a/lib/mv_web/live/member_live/form.ex +++ b/lib/mv_web/live/member_live/form.ex @@ -144,8 +144,7 @@ defmodule MvWeb.MemberLive.Form do field={value_form[:value]} label={cf.name} type={custom_field_input_type(cf.value_type)} - required={if cf.value_type == :boolean, do: false, else: cf.required} - aria-required={if cf.required, do: "true", else: nil} + required={cf.required} />