From 2ddd22078dbcc93aabe3e7212d1958b8c0dbb841 Mon Sep 17 00:00:00 2001
From: Moritz <moritz.m@local-it.org>
Date: Tue, 3 Feb 2026 17:16:08 +0100
Subject: [PATCH] Sidebar: use PagePaths, add testid for Administration

Gate menu items via PagePaths; add data-testid=sidebar-administration
for stable tests. menu_group accepts optional testid attr.
---
 lib/mv_web/components/layouts/sidebar.ex | 33 +++++++++++++-----------
 1 file changed, 18 insertions(+), 15 deletions(-)

diff --git a/lib/mv_web/components/layouts/sidebar.ex b/lib/mv_web/components/layouts/sidebar.ex
index 19f5547..26c0d7a 100644
--- a/lib/mv_web/components/layouts/sidebar.ex
+++ b/lib/mv_web/components/layouts/sidebar.ex
@@ -4,6 +4,8 @@ defmodule MvWeb.Layouts.Sidebar do
   """
   use MvWeb, :html
 
+  alias MvWeb.PagePaths
+
   attr :current_user, :map, default: nil, doc: "The current user"
   attr :club_name, :string, required: true, doc: "The name of the club"
   attr :mobile, :boolean, default: false, doc: "Whether this is mobile view"
@@ -70,7 +72,7 @@ defmodule MvWeb.Layouts.Sidebar do
   defp sidebar_menu(assigns) do
     ~H"""
     <ul class="menu flex-1 w-full p-2" role="menubar">
-      <%= if can_access_page?(@current_user, "/members") do %>
+      <%= if can_access_page?(@current_user, PagePaths.members()) do %>
         <.menu_item
           href={~p"/members"}
           icon="hero-users"
@@ -78,7 +80,7 @@ defmodule MvWeb.Layouts.Sidebar do
         />
       <% end %>
 
-      <%= if can_access_page?(@current_user, "/membership_fee_types") do %>
+      <%= if can_access_page?(@current_user, PagePaths.membership_fee_types()) do %>
         <.menu_item
           href={~p"/membership_fee_types"}
           icon="hero-currency-euro"
@@ -87,23 +89,27 @@ defmodule MvWeb.Layouts.Sidebar do
       <% end %>
 
       <%= if admin_menu_visible?(@current_user) do %>
-        <.menu_group icon="hero-cog-6-tooth" label={gettext("Administration")}>
-          <%= if can_access_page?(@current_user, "/users") do %>
+        <.menu_group
+          icon="hero-cog-6-tooth"
+          label={gettext("Administration")}
+          testid="sidebar-administration"
+        >
+          <%= if can_access_page?(@current_user, PagePaths.users()) do %>
             <.menu_subitem href={~p"/users"} label={gettext("Users")} />
           <% end %>
-          <%= if can_access_page?(@current_user, "/groups") do %>
+          <%= if can_access_page?(@current_user, PagePaths.groups()) do %>
             <.menu_subitem href={~p"/groups"} label={gettext("Groups")} />
           <% end %>
-          <%= if can_access_page?(@current_user, "/admin/roles") do %>
+          <%= if can_access_page?(@current_user, PagePaths.admin_roles()) do %>
             <.menu_subitem href={~p"/admin/roles"} label={gettext("Roles")} />
           <% end %>
-          <%= if can_access_page?(@current_user, "/membership_fee_settings") do %>
+          <%= if can_access_page?(@current_user, PagePaths.membership_fee_settings()) do %>
             <.menu_subitem
               href={~p"/membership_fee_settings"}
               label={gettext("Fee Settings")}
             />
           <% end %>
-          <%= if can_access_page?(@current_user, "/settings") do %>
+          <%= if can_access_page?(@current_user, PagePaths.settings()) do %>
             <.menu_subitem href={~p"/settings"} label={gettext("Settings")} />
           <% end %>
         </.menu_group>
@@ -113,11 +119,7 @@ defmodule MvWeb.Layouts.Sidebar do
   end
 
   defp admin_menu_visible?(user) do
-    Enum.any?(admin_page_paths(), &can_access_page?(user, &1))
-  end
-
-  defp admin_page_paths do
-    ["/users", "/groups", "/admin/roles", "/membership_fee_settings", "/settings"]
+    Enum.any?(PagePaths.admin_menu_paths(), &can_access_page?(user, &1))
   end
 
   attr :href, :string, required: true, doc: "Navigation path"
@@ -142,12 +144,13 @@ defmodule MvWeb.Layouts.Sidebar do
 
   attr :icon, :string, required: true, doc: "Heroicon name for the menu group"
   attr :label, :string, required: true, doc: "Menu group label"
+  attr :testid, :string, default: nil, doc: "data-testid for stable test selectors"
   slot :inner_block, required: true, doc: "Submenu items"
 
   defp menu_group(assigns) do
     ~H"""
     <!-- Expanded Mode: Always open div structure -->
-    <li role="none" class="expanded-menu-group">
+    <li role="none" class="expanded-menu-group" data-testid={@testid}>
       <div
         class="flex items-center gap-3"
         role="group"
@@ -161,7 +164,7 @@ defmodule MvWeb.Layouts.Sidebar do
       </ul>
     </li>
     <!-- Collapsed Mode: Dropdown -->
-    <div class="collapsed-menu-group dropdown dropdown-right">
+    <div class="collapsed-menu-group dropdown dropdown-right" data-testid={@testid}>
       <button
         type="button"
         tabindex="0"