From 3d50b49436c861a5b4fc54d1baa8a0930bc20579 Mon Sep 17 00:00:00 2001
From: Moritz <moritz.m@local-it.org>
Date: Tue, 16 Jun 2026 15:20:18 +0200
Subject: [PATCH] refactor(vereinfacht): reuse EmailSync.Loader for
 linked-member lookup

---
 .../sync_linked_member_after_user_change.ex   | 20 ++-----------------
 1 file changed, 2 insertions(+), 18 deletions(-)

diff --git a/lib/mv/vereinfacht/changes/sync_linked_member_after_user_change.ex b/lib/mv/vereinfacht/changes/sync_linked_member_after_user_change.ex
index 4465690..79f8c47 100644
--- a/lib/mv/vereinfacht/changes/sync_linked_member_after_user_change.ex
+++ b/lib/mv/vereinfacht/changes/sync_linked_member_after_user_change.ex
@@ -10,10 +10,7 @@ defmodule Mv.Vereinfacht.Changes.SyncLinkedMemberAfterUserChange do
   use Ash.Resource.Change
 
   require Logger
-  alias Mv.Helpers
-  alias Mv.Helpers.SystemActor
-  alias Mv.Membership
-  alias Mv.Membership.Member
+  alias Mv.EmailSync.Loader
 
   @impl true
   def change(changeset, _opts, _context) do
@@ -32,7 +29,7 @@ defmodule Mv.Vereinfacht.Changes.SyncLinkedMemberAfterUserChange do
   end
 
   defp sync_linked_member_after_transaction(_changeset, {:ok, user}) do
-    case load_linked_member(user) do
+    case Loader.get_linked_member(user) do
       nil ->
         {:ok, user}
 
@@ -55,17 +52,4 @@ defmodule Mv.Vereinfacht.Changes.SyncLinkedMemberAfterUserChange do
   end
 
   defp sync_linked_member_after_transaction(_changeset, result), do: result
-
-  defp load_linked_member(%{member_id: nil}), do: nil
-  defp load_linked_member(%{member_id: ""}), do: nil
-
-  defp load_linked_member(user) do
-    actor = SystemActor.get_system_actor()
-    opts = Helpers.ash_actor_opts(actor)
-
-    case Ash.get(Member, user.member_id, [domain: Membership] ++ opts) do
-      {:ok, %Member{} = member} -> member
-      _ -> nil
-    end
-  end
 end