From 3f551c5f8d47695f23b094f3100c73b6815478c0 Mon Sep 17 00:00:00 2001
From: carla <carla@local-it.org>
Date: Mon, 2 Feb 2026 09:49:13 +0100
Subject: [PATCH] feat: add configs for impor tlimits

---
 config/config.exs                       |  6 ++++
 lib/mv/config.ex                        | 46 +++++++++++++++++++++++++
 lib/mv_web/live/global_settings_live.ex |  7 ++--
 3 files changed, 55 insertions(+), 4 deletions(-)

diff --git a/config/config.exs b/config/config.exs
index cc338b2..6dfb1d1 100644
--- a/config/config.exs
+++ b/config/config.exs
@@ -51,6 +51,12 @@ config :mv,
   generators: [timestamp_type: :utc_datetime],
   ash_domains: [Mv.Membership, Mv.Accounts, Mv.MembershipFees, Mv.Authorization]
 
+# CSV Import configuration
+config :mv, csv_import: [
+  max_file_size_mb: 10,
+  max_rows: 1000
+]
+
 # Configures the endpoint
 config :mv, MvWeb.Endpoint,
   url: [host: "localhost"],
diff --git a/lib/mv/config.ex b/lib/mv/config.ex
index 5e6ba90..edf8428 100644
--- a/lib/mv/config.ex
+++ b/lib/mv/config.ex
@@ -21,4 +21,50 @@ defmodule Mv.Config do
   def sql_sandbox? do
     Application.get_env(:mv, :sql_sandbox, false)
   end
+
+  @doc """
+  Returns the maximum file size for CSV imports in bytes.
+
+  Reads the `max_file_size_mb` value from the CSV import configuration
+  and converts it to bytes.
+
+  ## Returns
+
+    - Maximum file size in bytes (default: 10_485_760 bytes = 10 MB)
+
+  ## Examples
+
+      iex> Mv.Config.csv_import_max_file_size_bytes()
+      10_485_760
+  """
+  @spec csv_import_max_file_size_bytes() :: non_neg_integer()
+  def csv_import_max_file_size_bytes do
+    max_file_size_mb = get_csv_import_config(:max_file_size_mb, 10)
+    max_file_size_mb * 1024 * 1024
+  end
+
+  @doc """
+  Returns the maximum number of rows allowed in CSV imports.
+
+  Reads the `max_rows` value from the CSV import configuration.
+
+  ## Returns
+
+    - Maximum number of rows (default: 1000)
+
+  ## Examples
+
+      iex> Mv.Config.csv_import_max_rows()
+      1000
+  """
+  @spec csv_import_max_rows() :: pos_integer()
+  def csv_import_max_rows do
+    get_csv_import_config(:max_rows, 1000)
+  end
+
+  # Helper function to get CSV import config values
+  defp get_csv_import_config(key, default) do
+    Application.get_env(:mv, :csv_import, [])
+    |> Keyword.get(key, default)
+  end
 end
diff --git a/lib/mv_web/live/global_settings_live.ex b/lib/mv_web/live/global_settings_live.ex
index bd0036b..aa41cd5 100644
--- a/lib/mv_web/live/global_settings_live.ex
+++ b/lib/mv_web/live/global_settings_live.ex
@@ -54,8 +54,6 @@ defmodule MvWeb.GlobalSettingsLive do
   on_mount {MvWeb.LiveHelpers, :ensure_user_role_loaded}
 
   # CSV Import configuration constants
-  # 10 MB
-  @max_file_size_bytes 10_485_760
   @max_errors 50
 
   @impl true
@@ -82,7 +80,7 @@ defmodule MvWeb.GlobalSettingsLive do
       |> allow_upload(:csv_file,
         accept: ~w(.csv),
         max_entries: 1,
-        max_file_size: @max_file_size_bytes,
+        max_file_size: Config.csv_import_max_file_size_bytes(),
         auto_upload: true
       )
 
@@ -409,7 +407,8 @@ defmodule MvWeb.GlobalSettingsLive do
   # Processes CSV upload and starts import
   defp process_csv_upload(socket) do
     with {:ok, content} <- consume_and_read_csv(socket),
-         {:ok, import_state} <- MemberCSV.prepare(content) do
+         {:ok, import_state} <-
+           MemberCSV.prepare(content, max_rows: Config.csv_import_max_rows()) do
       start_import(socket, import_state)
     else
       {:error, reason} when is_binary(reason) ->