From 46af6bbbed95706c88dc83b4a0f8da7dcecf3868 Mon Sep 17 00:00:00 2001
From: Moritz <moritz.m@local-it.org>
Date: Mon, 22 Dec 2025 17:19:24 +0100
Subject: [PATCH] Add required validation and error display for interval field

Show required asterisk and validation errors when interval is not selected
---
 .../live/membership_fee_type_live/form.ex     | 25 ++++++++++++++++---
 1 file changed, 22 insertions(+), 3 deletions(-)

diff --git a/lib/mv_web/live/membership_fee_type_live/form.ex b/lib/mv_web/live/membership_fee_type_live/form.ex
index 4054dfb..f3a4e9f 100644
--- a/lib/mv_web/live/membership_fee_type_live/form.ex
+++ b/lib/mv_web/live/membership_fee_type_live/form.ex
@@ -49,14 +49,24 @@ defmodule MvWeb.MembershipFeeTypeLive.Form do
 
         <div class="form-control">
           <label class="label">
-            <span class="label-text font-semibold">{gettext("Interval")}</span>
+            <span class="label-text font-semibold">
+              {gettext("Interval")}
+              <span
+                :if={is_nil(@membership_fee_type)}
+                class="text-red-700 tooltip tooltip-right"
+                data-tip={gettext("This field cannot be empty")}
+              >*</span>
+            </span>
           </label>
           <select
-            class="select select-bordered w-full"
+            class={[
+              "select select-bordered w-full",
+              @form.errors[:interval] && "select-error"
+            ]}
             disabled={!is_nil(@membership_fee_type)}
             name="membership_fee_type[interval]"
             id="membership-fee-type-form_interval"
-            phx-change="validate"
+            required={is_nil(@membership_fee_type)}
           >
             <option value="">{gettext("Select interval")}</option>
             <option
@@ -86,6 +96,15 @@ defmodule MvWeb.MembershipFeeTypeLive.Form do
               {gettext("Yearly")}
             </option>
           </select>
+          <%= if @form.errors[:interval] do %>
+            <%= for error <- List.wrap(@form.errors[:interval]) do %>
+              <% {msg, _opts} = if is_tuple(error), do: error, else: {error, []} %>
+              <p class="mt-1.5 flex gap-2 items-center text-sm text-error">
+                <.icon name="hero-exclamation-circle" class="size-5" />
+                {msg}
+              </p>
+            <% end %>
+          <% end %>
           <%= if !is_nil(@membership_fee_type) do %>
             <label class="label">
               <span class="label-text-alt text-base-content/60">