From 46fb12c3f48a26e2f9f186e29a5aced3b39fa6a0 Mon Sep 17 00:00:00 2001
From: Moritz <moritz.m@local-it.org>
Date: Thu, 18 Dec 2025 14:38:51 +0100
Subject: [PATCH] Add German translations and fix Credo warnings

Add translations for 'Current Cycle Payment Status' and 'Last Cycle
Payment Status'. Replace length/1 with Enum.empty?/1 in seeds tests
to fix Credo warnings.
---
 priv/gettext/de/LC_MESSAGES/default.po | 14 ++++++++++++--
 priv/gettext/default.pot               |  7 ++++++-
 priv/gettext/en/LC_MESSAGES/default.po | 14 ++++++++++++--
 test/seeds_test.exs                    |  6 +++---
 4 files changed, 33 insertions(+), 8 deletions(-)

diff --git a/priv/gettext/de/LC_MESSAGES/default.po b/priv/gettext/de/LC_MESSAGES/default.po
index c211172..0bebadd 100644
--- a/priv/gettext/de/LC_MESSAGES/default.po
+++ b/priv/gettext/de/LC_MESSAGES/default.po
@@ -1808,8 +1808,13 @@ msgstr ""
 
 #: lib/mv_web/live/member_live/index.html.heex
 #, elixir-autogen, elixir-format
-msgid "Show Last/Current Cycle Payment Status"
-msgstr ""
+msgid "Current Cycle Payment Status"
+msgstr "Aktueller Zyklus Zahlungsstatus"
+
+#: lib/mv_web/live/member_live/index.html.heex
+#, elixir-autogen, elixir-format
+msgid "Last Cycle Payment Status"
+msgstr "Letzter Zyklus Zahlungsstatus"
 
 #~ #: lib/mv_web/live/components/payment_filter_component.ex
 #~ #, elixir-autogen, elixir-format
@@ -1894,6 +1899,11 @@ msgstr ""
 #~ msgid "Quarterly Interval - Joining Period Excluded"
 #~ msgstr "Vierteljährliches Intervall – Beitrittszeitraum nicht einbezogen"
 
+#~ #: lib/mv_web/live/member_live/index.html.heex
+#~ #, elixir-autogen, elixir-format
+#~ msgid "Show Last/Current Cycle Payment Status"
+#~ msgstr ""
+
 #~ #: lib/mv_web/live/member_live/index.html.heex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Show current cycle"
diff --git a/priv/gettext/default.pot b/priv/gettext/default.pot
index 1744ae5..550dcc5 100644
--- a/priv/gettext/default.pot
+++ b/priv/gettext/default.pot
@@ -1809,5 +1809,10 @@ msgstr ""
 
 #: lib/mv_web/live/member_live/index.html.heex
 #, elixir-autogen, elixir-format
-msgid "Show Last/Current Cycle Payment Status"
+msgid "Current Cycle Payment Status"
+msgstr ""
+
+#: lib/mv_web/live/member_live/index.html.heex
+#, elixir-autogen, elixir-format
+msgid "Last Cycle Payment Status"
 msgstr ""
diff --git a/priv/gettext/en/LC_MESSAGES/default.po b/priv/gettext/en/LC_MESSAGES/default.po
index 54e2ab4..87f9019 100644
--- a/priv/gettext/en/LC_MESSAGES/default.po
+++ b/priv/gettext/en/LC_MESSAGES/default.po
@@ -1809,8 +1809,13 @@ msgstr ""
 
 #: lib/mv_web/live/member_live/index.html.heex
 #, elixir-autogen, elixir-format
-msgid "Show Last/Current Cycle Payment Status"
-msgstr ""
+msgid "Current Cycle Payment Status"
+msgstr "Current Cycle Payment Status"
+
+#: lib/mv_web/live/member_live/index.html.heex
+#, elixir-autogen, elixir-format
+msgid "Last Cycle Payment Status"
+msgstr "Last Cycle Payment Status"
 
 #~ #: lib/mv_web/live/components/payment_filter_component.ex
 #~ #, elixir-autogen, elixir-format
@@ -1916,6 +1921,11 @@ msgstr ""
 #~ msgid "Quarterly Interval - Joining Period Excluded"
 #~ msgstr ""
 
+#~ #: lib/mv_web/live/member_live/index.html.heex
+#~ #, elixir-autogen, elixir-format
+#~ msgid "Show Last/Current Cycle Payment Status"
+#~ msgstr ""
+
 #~ #: lib/mv_web/live/member_live/index.html.heex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Show current cycle"
diff --git a/test/seeds_test.exs b/test/seeds_test.exs
index 1d75453..c28eab9 100644
--- a/test/seeds_test.exs
+++ b/test/seeds_test.exs
@@ -56,7 +56,7 @@ defmodule Mv.SeedsTest do
       members_without_fee_type =
         Enum.filter(members, fn member -> member.membership_fee_type_id == nil end)
 
-      assert length(members_without_fee_type) > 0,
+      assert not Enum.empty?(members_without_fee_type),
              "At least one member should have no membership fee type assigned"
     end
 
@@ -78,7 +78,7 @@ defmodule Mv.SeedsTest do
       Enum.each(fee_types, fn fee_type ->
         members_for_type = Map.get(members_by_fee_type, fee_type.id, [])
 
-        assert length(members_for_type) > 0,
+        assert not Enum.empty?(members_for_type),
                "Membership fee type #{fee_type.name} should have at least one member assigned"
       end)
     end
@@ -95,7 +95,7 @@ defmodule Mv.SeedsTest do
         |> Enum.filter(&(&1.membership_fee_type_id != nil))
 
       # At least one member should have cycles
-      assert length(members_with_fee_types) > 0,
+      assert not Enum.empty?(members_with_fee_types),
              "At least one member should have a membership fee type"
 
       # Check that cycles exist and have various statuses