From 5352a635c6a8584e0df24a46e5210b2818813b02 Mon Sep 17 00:00:00 2001
From: Moritz <moritz.m@local-it.org>
Date: Tue, 2 Jun 2026 11:33:14 +0200
Subject: [PATCH] refactor(release): bind discarded results of side-effecting
 release tasks

---
 lib/mv/release.ex | 53 +++++++++++++++++++++++++----------------------
 1 file changed, 28 insertions(+), 25 deletions(-)

diff --git a/lib/mv/release.ex b/lib/mv/release.ex
index 116b276..5db4751 100644
--- a/lib/mv/release.ex
+++ b/lib/mv/release.ex
@@ -22,7 +22,7 @@ defmodule Mv.Release do
   require Logger
 
   def migrate do
-    load_app()
+    _ = load_app()
 
     for repo <- repos() do
       {:ok, _, _} = Ecto.Migrator.with_repo(repo, &Ecto.Migrator.run(&1, :up, all: true))
@@ -75,14 +75,14 @@ defmodule Mv.Release do
       dev_path = Path.join(priv, "repo/seeds_dev.exs")
 
       prev = Code.compiler_options()
-      Code.compiler_options(ignore_module_conflict: true)
+      _ = Code.compiler_options(ignore_module_conflict: true)
 
       try do
-        Code.eval_file(bootstrap_path)
+        _ = Code.eval_file(bootstrap_path)
         IO.puts("✅ Bootstrap seeds completed.")
 
         if System.get_env("RUN_DEV_SEEDS") == "true" do
-          Code.eval_file(dev_path)
+          _ = Code.eval_file(dev_path)
           IO.puts("✅ Dev seeds completed.")
         end
       after
@@ -92,7 +92,7 @@ defmodule Mv.Release do
   end
 
   def rollback(repo, version) do
-    load_app()
+    _ = load_app()
     {:ok, _, _} = Ecto.Migrator.with_repo(repo, &Ecto.Migrator.run(&1, :down, to: version))
   end
 
@@ -139,10 +139,11 @@ defmodule Mv.Release do
       {:ok, %Role{} = admin_role} ->
         case get_user_by_email(email) do
           {:ok, %User{} = user} ->
-            user
-            |> Ash.Changeset.for_update(:update, %{})
-            |> Ash.Changeset.manage_relationship(:role, admin_role, type: :append_and_remove)
-            |> Ash.update!(authorize?: false)
+            _ =
+              user
+              |> Ash.Changeset.for_update(:update, %{})
+              |> Ash.Changeset.manage_relationship(:role, admin_role, type: :append_and_remove)
+              |> Ash.update!(authorize?: false)
 
             :ok
 
@@ -189,15 +190,16 @@ defmodule Mv.Release do
   defp create_admin_user(email, password, admin_role) do
     case Accounts.create_user(%{email: email}, authorize?: false) do
       {:ok, user} ->
-        user
-        |> Ash.Changeset.for_update(:admin_set_password, %{password: password})
-        |> Ash.update!(authorize?: false)
-        |> then(fn u ->
-          u
-          |> Ash.Changeset.for_update(:update, %{})
-          |> Ash.Changeset.manage_relationship(:role, admin_role, type: :append_and_remove)
+        _ =
+          user
+          |> Ash.Changeset.for_update(:admin_set_password, %{password: password})
           |> Ash.update!(authorize?: false)
-        end)
+          |> then(fn u ->
+            u
+            |> Ash.Changeset.for_update(:update, %{})
+            |> Ash.Changeset.manage_relationship(:role, admin_role, type: :append_and_remove)
+            |> Ash.update!(authorize?: false)
+          end)
 
         :ok
 
@@ -207,15 +209,16 @@ defmodule Mv.Release do
   end
 
   defp update_admin_user(user, password, admin_role) do
-    user
-    |> Ash.Changeset.for_update(:admin_set_password, %{password: password})
-    |> Ash.update!(authorize?: false)
-    |> then(fn u ->
-      u
-      |> Ash.Changeset.for_update(:update, %{})
-      |> Ash.Changeset.manage_relationship(:role, admin_role, type: :append_and_remove)
+    _ =
+      user
+      |> Ash.Changeset.for_update(:admin_set_password, %{password: password})
       |> Ash.update!(authorize?: false)
-    end)
+      |> then(fn u ->
+        u
+        |> Ash.Changeset.for_update(:update, %{})
+        |> Ash.Changeset.manage_relationship(:role, admin_role, type: :append_and_remove)
+        |> Ash.update!(authorize?: false)
+      end)
 
     :ok
   end