From 54d96136b749acf72dcc11ba8bf569ca1b9e10bd Mon Sep 17 00:00:00 2001
From: Simon <s.thiessen@local-it.org>
Date: Fri, 16 Jan 2026 17:16:06 +0100
Subject: [PATCH] fix: link/button semantics

---
 assets/css/app.css                       | 9 +++++++--
 lib/mv_web/components/layouts/sidebar.ex | 8 ++++----
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/assets/css/app.css b/assets/css/app.css
index 7e6699d..3c2e93b 100644
--- a/assets/css/app.css
+++ b/assets/css/app.css
@@ -237,7 +237,8 @@
 
 .sidebar .menu > li > a,
 .sidebar .menu > li > button,
-.sidebar .menu > div.collapsed-menu-group > a {
+.sidebar .menu > li.expanded-menu-group > div,
+.sidebar .menu > div.collapsed-menu-group > button {
   @apply transition-all duration-300;
   padding-left: 14px;
 }
@@ -247,12 +248,16 @@
    - Keep padding-left at 14px so icons stay centered under logo */
 [data-sidebar-expanded="false"] .sidebar .menu > li > a,
 [data-sidebar-expanded="false"] .sidebar .menu > li > button,
-[data-sidebar-expanded="false"] .sidebar .menu > div.collapsed-menu-group > a {
+[data-sidebar-expanded="false"] .sidebar .menu > li.expanded-menu-group > div,
+[data-sidebar-expanded="false"] .sidebar .menu > div.collapsed-menu-group > button {
   @apply gap-0;
   padding-left: 14px;
   padding-right: 14px; /* Center icon horizontally in 64px sidebar */
 }
 
+
+
+
 /* ============================================
    Footer Button Alignment - Left Aligned in Collapsed State
    ============================================ */
diff --git a/lib/mv_web/components/layouts/sidebar.ex b/lib/mv_web/components/layouts/sidebar.ex
index 962e720..33319d4 100644
--- a/lib/mv_web/components/layouts/sidebar.ex
+++ b/lib/mv_web/components/layouts/sidebar.ex
@@ -81,7 +81,7 @@ defmodule MvWeb.Layouts.Sidebar do
         icon="hero-currency-euro"
         label={gettext("Fee Types")}
       />
-      
+
     <!-- Nested Admin Menu -->
       <.menu_group icon="hero-cog-6-tooth" label={gettext("Administration")}>
         <.menu_subitem href={~p"/users"} label={gettext("Users")} />
@@ -138,17 +138,17 @@ defmodule MvWeb.Layouts.Sidebar do
     </li>
     <!-- Collapsed Mode: Dropdown -->
     <div class="collapsed-menu-group dropdown dropdown-right">
-      <.link
+      <button
         type="button"
         tabindex="0"
-        class="flex items-center gap-3 p-2 rounded-lg hover:bg-base-300 tooltip tooltip-right focus:outline-none focus:ring-2 focus:ring-primary focus:ring-offset-2"
+        class="flex items-center gap-3  px-2 py-1.5  rounded-selector hover:bg-base-300 tooltip tooltip-right focus:outline-none focus:ring-2 focus:ring-primary focus:ring-offset-2 cursor-pointer"
         role="menuitem"
         data-tip={@label}
         aria-haspopup="menu"
         aria-label={@label}
       >
         <.icon name={@icon} class="size-5 shrink-0" aria-hidden="true" />
-      </.link>
+      </button>
       <ul
         class="dropdown-content menu bg-base-100 rounded-box shadow-lg z-50 min-w-48 p-2 focus:outline-none"
         role="menu"