From 569d88ccdf50f89320aee94d2c4cd918133c809e Mon Sep 17 00:00:00 2001 From: Moritz Date: Fri, 12 Dec 2025 19:06:08 +0100 Subject: [PATCH] docs: document require_atomic? false in MembershipFeeType actions --- lib/membership_fees/membership_fee_type.ex | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/membership_fees/membership_fee_type.ex b/lib/membership_fees/membership_fee_type.ex index f96920d..01ae625 100644 --- a/lib/membership_fees/membership_fee_type.ex +++ b/lib/membership_fees/membership_fee_type.ex @@ -45,6 +45,8 @@ defmodule Mv.MembershipFees.MembershipFeeType do update :update do primary? true + # require_atomic? false because validation queries (member/cycle counts) are not atomic + # DB constraints serve as the final safeguard if data changes between validation and update require_atomic? false # Note: interval is NOT in accept list - it's immutable after creation accept [:name, :amount, :description] @@ -52,6 +54,9 @@ defmodule Mv.MembershipFees.MembershipFeeType do destroy :destroy do primary? true + + # require_atomic? false because validation queries (member/cycle/settings counts) are not atomic + # DB constraints serve as the final safeguard if data changes between validation and delete require_atomic? false end end