diff --git a/lib/mv_web/live/member_field_live/form_component.ex b/lib/mv_web/live/member_field_live/form_component.ex
new file mode 100644
index 0000000..a9985cb
--- /dev/null
+++ b/lib/mv_web/live/member_field_live/form_component.ex
@@ -0,0 +1,445 @@
+defmodule MvWeb.MemberFieldLive.FormComponent do
+ @moduledoc """
+ LiveComponent form for editing member field properties (embedded in settings).
+
+ ## Features
+ - Edit member field properties (name, value type, description, immutable, required, show in overview)
+ - Display member field information from Member Resource
+ - Restrict editing for email field (only show_in_overview can be changed)
+ - Real-time validation
+ - Updates Settings.member_field_visibility
+
+ ## Props
+ - `member_field` - The member field atom to edit (e.g., :first_name, :email)
+ - `settings` - The current Settings resource
+ - `on_save` - Callback function to call when form is saved
+ - `on_cancel` - Callback function to call when form is cancelled
+ """
+ use MvWeb, :live_component
+
+ alias Mv.Membership
+ alias MvWeb.Translations.MemberFields
+ alias MvWeb.Translations.FieldTypes
+
+ @required_fields [:first_name, :last_name, :email]
+
+ @impl true
+ def render(assigns) do
+ assigns =
+ assigns
+ |> assign(:field_attributes, get_field_attributes(assigns.member_field))
+ |> assign(:is_email_field?, assigns.member_field == :email)
+ |> assign(:field_label, MemberFields.label(assigns.member_field))
+
+ ~H"""
+
+
+
+ <.button
+ type="button"
+ phx-click="cancel"
+ phx-target={@myself}
+ aria-label={gettext("Back to member field overview")}
+ >
+ <.icon name="hero-arrow-left" class="w-4 h-4" />
+
+
+ """
+ end
+
+ @impl true
+ def update(assigns, socket) do
+ {:ok,
+ socket
+ |> assign(assigns)
+ |> assign_form()}
+ end
+
+ @impl true
+ def handle_event("validate", %{"member_field" => member_field_params}, socket) do
+ # For member fields, we only validate show_in_overview
+ # Other fields are read-only or derived from the Member Resource
+ form = socket.assigns.form
+
+ updated_params =
+ member_field_params
+ |> Map.put("show_in_overview", parse_boolean(member_field_params["show_in_overview"]))
+ |> Map.put("name", form.source["name"])
+ |> Map.put("value_type", form.source["value_type"])
+ |> Map.put("description", form.source["description"])
+ |> Map.put("immutable", form.source["immutable"])
+ |> Map.put("required", form.source["required"])
+
+ updated_form =
+ form
+ |> Map.put(:value, updated_params)
+ |> Map.put(:errors, [])
+
+ {:noreply, assign(socket, form: updated_form)}
+ end
+
+ @impl true
+ def handle_event("save", %{"member_field" => member_field_params}, socket) do
+ # Only show_in_overview can be changed for member fields
+ show_in_overview = parse_boolean(member_field_params["show_in_overview"])
+
+ # Get current visibility config and update only the current field
+ current_visibility = socket.assigns.settings.member_field_visibility || %{}
+ field_string = Atom.to_string(socket.assigns.member_field)
+
+ # Normalize keys to strings
+ normalized_visibility =
+ Enum.reduce(current_visibility, %{}, fn
+ {key, value}, acc when is_atom(key) ->
+ Map.put(acc, Atom.to_string(key), value)
+
+ {key, value}, acc when is_binary(key) ->
+ Map.put(acc, key, value)
+ end)
+
+ # Update the specific field
+ updated_visibility = Map.put(normalized_visibility, field_string, show_in_overview)
+
+ # Update settings with new visibility
+ case Membership.update_member_field_visibility(
+ socket.assigns.settings,
+ updated_visibility
+ ) do
+ {:ok, _updated_settings} ->
+ socket.assigns.on_save.(socket.assigns.member_field, "update")
+ {:noreply, socket}
+
+ {:error, error} ->
+ # Add error to form
+ form =
+ socket.assigns.form
+ |> Map.put(:errors, [
+ %{field: :show_in_overview, message: format_error(error)}
+ ])
+
+ {:noreply, assign(socket, form: form)}
+ end
+ end
+
+ @impl true
+ def handle_event("cancel", _params, socket) do
+ socket.assigns.on_cancel.()
+ {:noreply, socket}
+ end
+
+ # Helper functions
+
+ defp assign_form(%{assigns: %{member_field: member_field, settings: settings}} = socket) do
+ field_attributes = get_field_attributes(member_field)
+ visibility_config = settings.member_field_visibility || %{}
+ normalized_config = normalize_visibility_config(visibility_config)
+ show_in_overview = Map.get(normalized_config, member_field, true)
+
+ # Create a manual form structure with string keys
+ form_data = %{
+ "name" => MemberFields.label(member_field),
+ "value_type" => format_value_type(field_attributes.value_type),
+ "description" => field_attributes.description || "",
+ "immutable" => field_attributes.immutable,
+ "required" => field_attributes.required,
+ "show_in_overview" => show_in_overview
+ }
+
+ form = to_form(form_data, as: "member_field")
+
+ assign(socket, form: form)
+ end
+
+ defp get_field_attributes(field) when is_atom(field) do
+ # Get attribute info from Member Resource
+ case Ash.Resource.Info.attribute(Mv.Membership.Member, field) do
+ nil ->
+ # Fallback for fields not in resource (shouldn't happen with Constants)
+ %{
+ value_type: :string,
+ description: nil,
+ immutable: field == :email,
+ required: field in @required_fields
+ }
+
+ attribute ->
+ %{
+ value_type: attribute.type,
+ description: nil,
+ immutable: field == :email,
+ required: not attribute.allow_nil?
+ }
+ end
+ end
+
+ defp format_value_type(type) when is_atom(type) do
+ type_string = to_string(type)
+
+ # Check if it's an Ash type module (e.g., Ash.Type.String or Elixir.Ash.Type.String)
+ if String.contains?(type_string, "Ash.Type.") do
+ # Extract the base type name from Ash type modules
+ # e.g., "Elixir.Ash.Type.String" -> "String" -> :string
+ type_name =
+ type_string
+ |> String.split(".")
+ |> List.last()
+ |> String.downcase()
+
+ try do
+ type_atom = String.to_existing_atom(type_name)
+ FieldTypes.label(type_atom)
+ rescue
+ ArgumentError ->
+ # Fallback if atom doesn't exist
+ FieldTypes.label(:string)
+ end
+ else
+ # It's already an atom like :string, :boolean, :date
+ FieldTypes.label(type)
+ end
+ end
+
+ defp format_value_type(type) do
+ # Fallback for unknown types
+ to_string(type)
+ end
+
+ defp normalize_visibility_config(config) when is_map(config) do
+ Enum.reduce(config, %{}, fn
+ {key, value}, acc when is_atom(key) ->
+ Map.put(acc, key, value)
+
+ {key, value}, acc when is_binary(key) ->
+ try do
+ atom_key = String.to_existing_atom(key)
+ Map.put(acc, atom_key, value)
+ rescue
+ ArgumentError ->
+ acc
+ end
+
+ _, acc ->
+ acc
+ end)
+ end
+
+ defp normalize_visibility_config(_), do: %{}
+
+ defp parse_boolean(value) when is_boolean(value), do: value
+ defp parse_boolean("true"), do: true
+ defp parse_boolean("false"), do: false
+ defp parse_boolean(1), do: true
+ defp parse_boolean(0), do: false
+ defp parse_boolean(_), do: false
+
+ defp format_error(%Ash.Error.Invalid{} = error) do
+ Ash.ErrorKind.message(error)
+ end
+
+ defp format_error(error) do
+ inspect(error)
+ end
+end
diff --git a/lib/mv_web/live/member_field_live/index_component.ex b/lib/mv_web/live/member_field_live/index_component.ex
index 61c6578..7422f5a 100644
--- a/lib/mv_web/live/member_field_live/index_component.ex
+++ b/lib/mv_web/live/member_field_live/index_component.ex
@@ -6,12 +6,14 @@ defmodule MvWeb.MemberFieldLive.IndexComponent do
- List all member fields from Mv.Constants.member_fields()
- Display show_in_overview status as badge (Yes/No)
- Display required status for required fields (first_name, last_name, email)
- - Toggle show_in_overview flag for each field
+ - Edit member field properties (expandable form like custom fields)
- Updates Settings.member_field_visibility
"""
use MvWeb, :live_component
alias Mv.Membership
+ alias MvWeb.Translations.MemberFields
+ alias MvWeb.Translations.FieldTypes
@required_fields [:first_name, :last_name, :email]
@@ -24,123 +26,123 @@ defmodule MvWeb.MemberFieldLive.IndexComponent do
~H"""
- <.form_section title={gettext("Memberdata")}>
-
- {gettext(
- "These fields are neccessary for MILA to handle member identification and payment calculations in the future. Thus you cannot delete these fields but hide them in the member overview."
- )}
-
+
+ {gettext(
+ "These fields are neccessary for MILA to handle member identification and payment calculations in the future. Thus you cannot delete these fields but hide them in the member overview."
+ )}
+
- <.table id="member_fields" rows={@member_fields}>
- <:col :let={{_field_name, field_data}} label={gettext("Field Name")}>
- {format_field_name(field_data.field)}
-
+ <%!-- Show form when editing --%>
+