From 68261fa72a6972585ce904150bba9e2b2edb4e2e Mon Sep 17 00:00:00 2001
From: Moritz <moritz.m@local-it.org>
Date: Fri, 12 Dec 2025 18:09:15 +0100
Subject: [PATCH] fix: improve accessibility - WCAG 2 AA contrast and select
 label

---
 lib/mv_web/live/membership_fee_settings_live.ex | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/lib/mv_web/live/membership_fee_settings_live.ex b/lib/mv_web/live/membership_fee_settings_live.ex
index fd1d41e..070b730 100644
--- a/lib/mv_web/live/membership_fee_settings_live.ex
+++ b/lib/mv_web/live/membership_fee_settings_live.ex
@@ -87,15 +87,17 @@ defmodule MvWeb.MembershipFeeSettingsLive do
             >
               <%!-- Default Membership Fee Type --%>
               <fieldset class="fieldset">
-                <label class="label">
+                <label for="default_membership_fee_type_id" class="label">
                   <span class="label-text font-semibold">
                     {gettext("Default Membership Fee Type")}
                   </span>
                 </label>
                 <select
+                  id="default_membership_fee_type_id"
                   name="settings[default_membership_fee_type_id]"
                   class="select select-bordered w-full"
                   phx-debounce="blur"
+                  aria-label={gettext("Default Membership Fee Type")}
                 >
                   <option value="">{gettext("None (no default)")}</option>
                   <option
@@ -219,21 +221,21 @@ defmodule MvWeb.MembershipFeeSettingsLive do
       <h3 class="font-semibold text-sm">{@title}</h3>
       <div class="bg-base-300 rounded-lg p-3 text-sm space-y-1">
         <p>
-          <span class="text-base-content/60">{gettext("Joining date")}:</span>
+          <span class="text-base-content/80">{gettext("Joining date")}:</span>
           <span class="font-mono">{@joining_date}</span>
         </p>
         <p>
-          <span class="text-base-content/60">{gettext("Membership fee start")}:</span>
-          <span class="font-mono font-semibold text-primary">{@start_date}</span>
+          <span class="text-base-content/80">{gettext("Membership fee start")}:</span>
+          <span class="font-mono font-semibold text-base-content">{@start_date}</span>
         </p>
         <p>
-          <span class="text-base-content/60">{gettext("Generated cycles")}:</span>
+          <span class="text-base-content/80">{gettext("Generated cycles")}:</span>
           <span class="font-mono">
             {Enum.join(@periods, ", ")}
           </span>
         </p>
       </div>
-      <p class="text-xs text-base-content/60 italic">→ {@note}</p>
+      <p class="text-xs text-base-content/80 italic">→ {@note}</p>
     </div>
     """
   end