From 634b21d1bcabb2a5bd0fde7a171456a1e6387acd Mon Sep 17 00:00:00 2001
From: Renovate Bot
Date: Mon, 1 Jun 2026 00:05:40 +0000
Subject: [PATCH 01/23] chore(deps): update ghcr.io/sebadob/rauthy docker tag
to v0.35.2
---
docker-compose.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docker-compose.yml b/docker-compose.yml
index 512626b..a985b86 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -25,7 +25,7 @@ services:
rauthy:
container_name: rauthy-dev
- image: ghcr.io/sebadob/rauthy:0.35.1
+ image: ghcr.io/sebadob/rauthy:0.35.2
environment:
- LOCAL_TEST=true
- SMTP_URL=mailcrab
From 1fb6ba814ab92dd8180b44f8fd0ae1ed7cc552c7 Mon Sep 17 00:00:00 2001
From: Renovate Bot
Date: Mon, 1 Jun 2026 00:05:43 +0000
Subject: [PATCH 02/23] chore(deps): update dependency just to v1.51.0
---
.tool-versions | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.tool-versions b/.tool-versions
index e72ed5f..cf63238 100644
--- a/.tool-versions
+++ b/.tool-versions
@@ -1,3 +1,3 @@
elixir 1.18.3-otp-27
erlang 27.3.4
-just 1.50.0
+just 1.51.0
From 5c5fd567496c2028bb3aea1ede53f3c1bfc7cb39 Mon Sep 17 00:00:00 2001
From: Moritz
Date: Wed, 3 Jun 2026 01:54:49 +0200
Subject: [PATCH 03/23] fix(export): emit date custom-field values as ISO-8601
for re-import
---
.../custom_field_value_formatter.ex | 12 ++++++---
.../custom_field_value_formatter_test.exs | 27 +++++++++++++++++++
2 files changed, 35 insertions(+), 4 deletions(-)
create mode 100644 test/mv/membership/custom_field_value_formatter_test.exs
diff --git a/lib/mv/membership/custom_field_value_formatter.ex b/lib/mv/membership/custom_field_value_formatter.ex
index 9709353..9ba9c42 100644
--- a/lib/mv/membership/custom_field_value_formatter.ex
+++ b/lib/mv/membership/custom_field_value_formatter.ex
@@ -4,13 +4,13 @@ defmodule Mv.Membership.CustomFieldValueFormatter do
Same logic as the member overview Formatter but without Gettext or web helpers,
so it can be used from the Membership context. For boolean: "Yes"/"No";
- for date: European format (dd.mm.yyyy).
+ for date: ISO-8601 (YYYY-MM-DD) so exported values can be re-imported.
"""
@doc """
Formats a custom field value for plain text (e.g. CSV).
Handles nil, Ash.Union, JSONB map, and direct values. Uses custom_field.value_type
- for typing. Boolean -> "Yes"/"No", Date -> dd.mm.yyyy.
+ for typing. Boolean -> "Yes"/"No", Date -> ISO-8601 (YYYY-MM-DD).
"""
def format_custom_field_value(nil, _custom_field), do: ""
@@ -18,6 +18,10 @@ defmodule Mv.Membership.CustomFieldValueFormatter do
format_value_by_type(value, type, custom_field)
end
+ def format_custom_field_value(%Date{} = value, custom_field) do
+ format_value_by_type(value, :date, custom_field)
+ end
+
def format_custom_field_value(value, custom_field) when is_map(value) do
type = Map.get(value, "type") || Map.get(value, "_union_type")
val = Map.get(value, "value") || Map.get(value, "_union_value")
@@ -41,12 +45,12 @@ defmodule Mv.Membership.CustomFieldValueFormatter do
defp format_value_by_type(value, :boolean, _), do: to_string(value)
defp format_value_by_type(%Date{} = date, :date, _) do
- Calendar.strftime(date, "%d.%m.%Y")
+ Date.to_iso8601(date)
end
defp format_value_by_type(value, :date, _) when is_binary(value) do
case Date.from_iso8601(value) do
- {:ok, date} -> Calendar.strftime(date, "%d.%m.%Y")
+ {:ok, date} -> Date.to_iso8601(date)
_ -> value
end
end
diff --git a/test/mv/membership/custom_field_value_formatter_test.exs b/test/mv/membership/custom_field_value_formatter_test.exs
new file mode 100644
index 0000000..515fa7c
--- /dev/null
+++ b/test/mv/membership/custom_field_value_formatter_test.exs
@@ -0,0 +1,27 @@
+defmodule Mv.Membership.CustomFieldValueFormatterTest do
+ use ExUnit.Case, async: true
+
+ alias Mv.Membership.CustomFieldValueFormatter
+
+ describe "format_custom_field_value/2 for :date" do
+ test "formats an Ash.Union date value as ISO-8601" do
+ union = %Ash.Union{value: ~D[2024-03-15], type: :date}
+
+ assert CustomFieldValueFormatter.format_custom_field_value(union, %{value_type: :date}) ==
+ "2024-03-15"
+ end
+
+ test "formats a direct Date value as ISO-8601" do
+ assert CustomFieldValueFormatter.format_custom_field_value(~D[2024-03-15], %{
+ value_type: :date
+ }) == "2024-03-15"
+ end
+
+ test "formats an already-stored ISO-8601 string date as ISO-8601" do
+ union = %Ash.Union{value: "2024-03-15", type: :date}
+
+ assert CustomFieldValueFormatter.format_custom_field_value(union, %{value_type: :date}) ==
+ "2024-03-15"
+ end
+ end
+end
From 95c7bf7a15c21359497567efc735a4a6d9af8806 Mon Sep 17 00:00:00 2001
From: Moritz
Date: Wed, 3 Jun 2026 02:01:09 +0200
Subject: [PATCH 04/23] feat(import): recognize group and fee-type columns and
always ignore fee-status
---
lib/mv/membership/import/header_mapper.ex | 97 +++++++++--
.../membership/import/header_mapper_test.exs | 164 ++++++++++++++++++
2 files changed, 250 insertions(+), 11 deletions(-)
diff --git a/lib/mv/membership/import/header_mapper.ex b/lib/mv/membership/import/header_mapper.ex
index d96d96e..3047944 100644
--- a/lib/mv/membership/import/header_mapper.ex
+++ b/lib/mv/membership/import/header_mapper.ex
@@ -47,10 +47,10 @@ defmodule Mv.Membership.Import.HeaderMapper do
"e-mail"
iex> HeaderMapper.build_maps(["Email", "First Name"], [])
- {:ok, %{member: %{email: 0, first_name: 1}, custom: %{}, unknown: []}}
+ {:ok, %{member: %{email: 0, first_name: 1}, custom: %{}, unknown: [], ignored: [], groups_column_index: nil, fee_type_column_index: nil}}
iex> HeaderMapper.build_maps(["Email", "CustomField"], [%{id: "cf1", name: "CustomField"}])
- {:ok, %{member: %{email: 0}, custom: %{"cf1" => 1}, unknown: []}}
+ {:ok, %{member: %{email: 0}, custom: %{"cf1" => 1}, unknown: [], ignored: [], groups_column_index: nil, fee_type_column_index: nil}}
"""
@type column_map :: %{atom() => non_neg_integer()}
@@ -60,6 +60,31 @@ defmodule Mv.Membership.Import.HeaderMapper do
# Required member fields
@required_member_fields [:email]
+ # Fee-status header variants that must never be imported (computed/read-only field).
+ # Stored already-normalized; checked before member, custom, groups, and fee-type mapping.
+ # Maintain this list when new locale translations for fee-status are added.
+ @ignored_normalized [
+ "membershipfeestatus",
+ "mitgliedsbeitragsstatus",
+ "bezahlstatus"
+ ]
+
+ # Normalized header variants for the groups column. The column is resolved to
+ # group associations during import; it is never a member or custom field.
+ @groups_column_normalized [
+ "groups",
+ "gruppen",
+ "gruppe"
+ ]
+
+ # Normalized header variants for the membership fee-type column. The column is
+ # resolved to a MembershipFeeType during import; it is never a member or custom field.
+ @fee_type_column_normalized [
+ "membershipfeetype",
+ "feetype",
+ "beitragsart"
+ ]
+
# Canonical member fields with their raw variants
# These will be normalized at runtime when building the lookup map
@member_field_variants_raw %{
@@ -239,30 +264,79 @@ defmodule Mv.Membership.Import.HeaderMapper do
## Returns
- - `{:ok, %{member: column_map, custom: custom_field_map, unknown: unknown_headers}}` on success
+ - `{:ok, %{member: column_map, custom: custom_field_map, unknown: unknown_headers,
+ ignored: [non_neg_integer], groups_column_index: non_neg_integer | nil,
+ fee_type_column_index: non_neg_integer | nil}}` on success
- `{:error, reason}` on error (missing required field, duplicate headers)
+ The `ignored` list holds the indices of fee-status columns (computed/read-only),
+ which are never mapped to member or custom fields.
+
## Examples
iex> build_maps(["Email", "First Name"], [])
- {:ok, %{member: %{email: 0, first_name: 1}, custom: %{}, unknown: []}}
+ {:ok, %{member: %{email: 0, first_name: 1}, custom: %{}, unknown: [], ignored: [], groups_column_index: nil, fee_type_column_index: nil}}
iex> build_maps(["Email", "CustomField"], [%{id: "cf1", name: "CustomField"}])
- {:ok, %{member: %{email: 0}, custom: %{"cf1" => 1}, unknown: []}}
+ {:ok, %{member: %{email: 0}, custom: %{"cf1" => 1}, unknown: [], ignored: [], groups_column_index: nil, fee_type_column_index: nil}}
"""
@spec build_maps([String.t()], [map()]) ::
- {:ok, %{member: column_map(), custom: custom_field_map(), unknown: unknown_headers()}}
+ {:ok,
+ %{
+ member: column_map(),
+ custom: custom_field_map(),
+ unknown: unknown_headers(),
+ ignored: [non_neg_integer()],
+ groups_column_index: non_neg_integer() | nil,
+ fee_type_column_index: non_neg_integer() | nil
+ }}
| {:error, String.t()}
def build_maps(headers, custom_fields) when is_list(headers) and is_list(custom_fields) do
- with {:ok, member_map, unknown_after_member} <- build_member_map(headers),
+ ignored = ignored_indices(headers)
+ groups_column_index = first_matching_index(headers, @groups_column_normalized)
+ fee_type_column_index = first_matching_index(headers, @fee_type_column_normalized)
+
+ reserved =
+ [groups_column_index, fee_type_column_index | ignored]
+ |> Enum.reject(&is_nil/1)
+ |> MapSet.new()
+
+ with {:ok, member_map, unknown_after_member} <- build_member_map(headers, reserved),
{:ok, custom_map, unknown_after_custom} <-
build_custom_field_map(headers, unknown_after_member, custom_fields, member_map) do
unknown = Enum.map(unknown_after_custom, &Enum.at(headers, &1))
- {:ok, %{member: member_map, custom: custom_map, unknown: unknown}}
+
+ {:ok,
+ %{
+ member: member_map,
+ custom: custom_map,
+ unknown: unknown,
+ ignored: ignored,
+ groups_column_index: groups_column_index,
+ fee_type_column_index: fee_type_column_index
+ }}
end
end
+ # Returns the index of the first header whose normalized form is in `variants`,
+ # or nil if none match.
+ defp first_matching_index(headers, variants) do
+ headers
+ |> Enum.with_index()
+ |> Enum.find_value(fn {header, index} ->
+ if normalize_header(header) in variants, do: index
+ end)
+ end
+
+ # Returns the column indices whose normalized header is in the fee-status ignore list.
+ defp ignored_indices(headers) do
+ headers
+ |> Enum.with_index()
+ |> Enum.filter(fn {header, _index} -> normalize_header(header) in @ignored_normalized end)
+ |> Enum.map(fn {_header, index} -> index end)
+ end
+
# --- Private Functions ---
# Transliterates German umlauts and special characters
@@ -304,13 +378,14 @@ defmodule Mv.Membership.Import.HeaderMapper do
|> String.replace(" ", "")
end
- # Builds member field column map
- defp build_member_map(headers) do
+ # Builds member field column map, skipping reserved (e.g. ignored) indices.
+ defp build_member_map(headers, reserved) do
result =
headers
|> Enum.with_index()
|> Enum.reduce_while({%{}, []}, fn {header, index}, {acc_map, acc_unknown} ->
- normalized = normalize_header(header)
+ normalized =
+ if MapSet.member?(reserved, index), do: "", else: normalize_header(header)
case process_member_header(header, index, normalized, acc_map, %{}) do
{:error, reason} ->
diff --git a/test/mv/membership/import/header_mapper_test.exs b/test/mv/membership/import/header_mapper_test.exs
index 2f4fcad..f5519d8 100644
--- a/test/mv/membership/import/header_mapper_test.exs
+++ b/test/mv/membership/import/header_mapper_test.exs
@@ -1,5 +1,6 @@
defmodule Mv.Membership.Import.HeaderMapperTest do
use ExUnit.Case, async: true
+ use ExUnitProperties
alias Mv.Membership.Import.HeaderMapper
@@ -272,4 +273,167 @@ defmodule Mv.Membership.Import.HeaderMapperTest do
assert unknown == []
end
end
+
+ describe "build_maps/2 fee-status ignore list" do
+ test "places fee-status variants in ignored, not member or custom map" do
+ headers = ["email", "Bezahlstatus"]
+
+ assert {:ok, result} = HeaderMapper.build_maps(headers, [])
+
+ assert result.member[:email] == 0
+ assert result.custom == %{}
+ assert result.ignored == [1]
+ refute Map.has_key?(result.member, :bezahlstatus)
+ end
+
+ test "ignores membership_fee_status snake-case variant" do
+ headers = ["email", "membership_fee_status"]
+
+ assert {:ok, result} = HeaderMapper.build_maps(headers, [])
+
+ assert result.ignored == [1]
+ assert result.custom == %{}
+ end
+
+ test "ignores German Mitgliedsbeitragsstatus variant" do
+ headers = ["email", "Mitgliedsbeitragsstatus"]
+
+ assert {:ok, result} = HeaderMapper.build_maps(headers, [])
+
+ assert result.ignored == [1]
+ end
+
+ test "fee-status takes priority over a same-named custom field" do
+ headers = ["email", "Bezahlstatus"]
+ custom_fields = [%{id: "cf1", name: "Bezahlstatus"}]
+
+ assert {:ok, result} = HeaderMapper.build_maps(headers, custom_fields)
+
+ assert result.ignored == [1]
+ assert result.custom == %{}
+ end
+
+ test "result carries groups_column_index and fee_type_column_index keys" do
+ assert {:ok, result} = HeaderMapper.build_maps(["email"], [])
+
+ assert Map.has_key?(result, :groups_column_index)
+ assert Map.has_key?(result, :fee_type_column_index)
+ end
+ end
+
+ describe "build_maps/2 groups column detection" do
+ test "detects German Gruppen variant and excludes it from member/custom maps" do
+ headers = ["email", "Gruppen"]
+
+ assert {:ok, result} = HeaderMapper.build_maps(headers, [])
+
+ assert result.groups_column_index == 1
+ assert result.custom == %{}
+ assert result.unknown == []
+ refute Map.has_key?(result.member, :gruppen)
+ end
+
+ test "detects English Groups variant" do
+ headers = ["email", "Groups"]
+
+ assert {:ok, result} = HeaderMapper.build_maps(headers, [])
+
+ assert result.groups_column_index == 1
+ end
+
+ test "detects singular Gruppe and lowercase groups variants" do
+ assert {:ok, %{groups_column_index: 1}} = HeaderMapper.build_maps(["email", "Gruppe"], [])
+ assert {:ok, %{groups_column_index: 1}} = HeaderMapper.build_maps(["email", "groups"], [])
+ end
+
+ test "groups column takes priority over a same-named custom field" do
+ headers = ["email", "Gruppen"]
+ custom_fields = [%{id: "cf1", name: "Gruppen"}]
+
+ assert {:ok, result} = HeaderMapper.build_maps(headers, custom_fields)
+
+ assert result.groups_column_index == 1
+ assert result.custom == %{}
+ end
+
+ test "groups_column_index is nil when no groups column present" do
+ assert {:ok, %{groups_column_index: nil}} = HeaderMapper.build_maps(["email"], [])
+ end
+ end
+
+ describe "build_maps/2 fee-type column detection" do
+ test "detects German Beitragsart variant and excludes it from member/custom maps" do
+ headers = ["email", "Beitragsart"]
+
+ assert {:ok, result} = HeaderMapper.build_maps(headers, [])
+
+ assert result.fee_type_column_index == 1
+ assert result.custom == %{}
+ assert result.unknown == []
+ end
+
+ test "detects English fee type variants" do
+ assert {:ok, %{fee_type_column_index: 1}} =
+ HeaderMapper.build_maps(["email", "Fee Type"], [])
+
+ assert {:ok, %{fee_type_column_index: 1}} =
+ HeaderMapper.build_maps(["email", "fee type"], [])
+
+ assert {:ok, %{fee_type_column_index: 1}} =
+ HeaderMapper.build_maps(["email", "fee_type"], [])
+
+ assert {:ok, %{fee_type_column_index: 1}} =
+ HeaderMapper.build_maps(["email", "membership_fee_type"], [])
+ end
+
+ test "fee-type column takes priority over a same-named custom field" do
+ headers = ["email", "Beitragsart"]
+ custom_fields = [%{id: "cf1", name: "Beitragsart"}]
+
+ assert {:ok, result} = HeaderMapper.build_maps(headers, custom_fields)
+
+ assert result.fee_type_column_index == 1
+ assert result.custom == %{}
+ end
+
+ test "fee_type_column_index is nil when no fee-type column present" do
+ assert {:ok, %{fee_type_column_index: nil}} = HeaderMapper.build_maps(["email"], [])
+ end
+
+ test "detects groups and fee-type columns together" do
+ headers = ["email", "Gruppen", "Beitragsart"]
+
+ assert {:ok, result} = HeaderMapper.build_maps(headers, [])
+
+ assert result.groups_column_index == 1
+ assert result.fee_type_column_index == 2
+ assert result.member[:email] == 0
+ assert result.custom == %{}
+ assert result.unknown == []
+ end
+ end
+
+ describe "build_maps/2 fee-status ignore property" do
+ property "every fee-status variant is ignored, never member or custom" do
+ check all(
+ variant <-
+ StreamData.member_of([
+ "Membership Fee Status",
+ "membership_fee_status",
+ "Mitgliedsbeitragsstatus",
+ "Bezahlstatus",
+ " Bezahlstatus ",
+ "BEZAHLSTATUS"
+ ])
+ ) do
+ custom_fields = [%{id: "cf1", name: variant}]
+
+ assert {:ok, result} = HeaderMapper.build_maps(["email", variant], custom_fields)
+
+ assert result.ignored == [1]
+ assert result.custom == %{}
+ refute Map.has_key?(result.member, :bezahlstatus)
+ end
+ end
+ end
end
From aaffd7b91c2330611eb951c3923c356a65b37288 Mon Sep 17 00:00:00 2001
From: Renovate Bot
Date: Wed, 3 Jun 2026 00:06:34 +0000
Subject: [PATCH 05/23] chore(deps): update postgres docker tag to v18.4
---
docker-compose.prod.yml | 2 +-
docker-compose.yml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docker-compose.prod.yml b/docker-compose.prod.yml
index 37f9552..98d4053 100644
--- a/docker-compose.prod.yml
+++ b/docker-compose.prod.yml
@@ -33,7 +33,7 @@ services:
restart: unless-stopped
db-prod:
- image: postgres:18.3-alpine
+ image: postgres:18.4-alpine
container_name: mv-prod-db
environment:
POSTGRES_USER: postgres
diff --git a/docker-compose.yml b/docker-compose.yml
index 01a0bd2..aeb16ec 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -4,7 +4,7 @@ networks:
services:
db:
- image: postgres:18.3-alpine
+ image: postgres:18.4-alpine
environment:
POSTGRES_USER: postgres
POSTGRES_PASSWORD: postgres
From a4a34cab3a4b4ce366d84ef000421f8ab6bc443c Mon Sep 17 00:00:00 2001
From: Moritz
Date: Wed, 3 Jun 2026 02:10:33 +0200
Subject: [PATCH 06/23] feat(import): resolve import group and fee-type names
against existing records
---
lib/mv/membership/import/column_resolver.ex | 258 ++++++++++++++++++
.../import/column_resolver_query_test.exs | 72 +++++
.../import/column_resolver_test.exs | 227 +++++++++++++++
3 files changed, 557 insertions(+)
create mode 100644 lib/mv/membership/import/column_resolver.ex
create mode 100644 test/mv/membership/import/column_resolver_query_test.exs
create mode 100644 test/mv/membership/import/column_resolver_test.exs
diff --git a/lib/mv/membership/import/column_resolver.ex b/lib/mv/membership/import/column_resolver.ex
new file mode 100644
index 0000000..2edb540
--- /dev/null
+++ b/lib/mv/membership/import/column_resolver.ex
@@ -0,0 +1,258 @@
+defmodule Mv.Membership.Import.ColumnResolver do
+ @moduledoc """
+ Read-only resolution of CSV import columns against the database.
+
+ Given the `HeaderMapper.build_maps/2` result, the raw numbered rows, and an
+ actor, `resolve/3` determines:
+
+ - which group names in the groups column already exist (`groups_found`) and
+ which would have to be created (`groups_to_create`);
+ - a small set of preview rows for the mapping preview UI.
+
+ No database writes happen here; the resolver only reads. Group creation and
+ member-group assignment happen during processing via `create_or_find_group/3`.
+
+ This module has no Phoenix or web dependencies.
+ """
+
+ require Logger
+
+ alias Mv.Membership.Import.HeaderMapper
+
+ @preview_row_limit 3
+
+ @type numbered_row :: {pos_integer(), [String.t()]}
+
+ @type resolution :: %{
+ groups_found: [%{id: String.t(), name: String.t()}],
+ groups_to_create: [String.t()],
+ fee_type_map: %{String.t() => String.t()},
+ fee_type_warnings: [String.t()],
+ has_empty_fee_type_cells?: boolean(),
+ preview_rows: [[String.t()]]
+ }
+
+ @doc """
+ Resolves the group and fee-type columns of an import against the database and
+ extracts preview rows.
+
+ Returns a map with `:groups_found`, `:groups_to_create`, `:fee_type_map`,
+ `:fee_type_warnings`, `:has_empty_fee_type_cells?`, and `:preview_rows`.
+ """
+ @spec resolve(map(), [numbered_row()], term()) :: resolution()
+ def resolve(header_maps, rows, actor) do
+ %{
+ groups_found: groups_found,
+ groups_to_create: groups_to_create
+ } = resolve_groups(header_maps, rows, actor)
+
+ %{
+ fee_type_map: fee_type_map,
+ fee_type_warnings: fee_type_warnings,
+ has_empty_fee_type_cells?: has_empty_fee_type_cells?
+ } = resolve_fee_types(header_maps, rows, actor)
+
+ %{
+ groups_found: groups_found,
+ groups_to_create: groups_to_create,
+ fee_type_map: fee_type_map,
+ fee_type_warnings: fee_type_warnings,
+ has_empty_fee_type_cells?: has_empty_fee_type_cells?,
+ preview_rows: preview_rows(rows)
+ }
+ end
+
+ defp resolve_groups(%{groups_column_index: nil}, _rows, _actor) do
+ %{groups_found: [], groups_to_create: []}
+ end
+
+ defp resolve_groups(%{groups_column_index: index}, rows, actor) do
+ existing_groups = list_groups(actor)
+ lookup = build_group_lookup(existing_groups)
+
+ names = unique_group_names(rows, index)
+
+ {found, to_create} =
+ Enum.reduce(names, {[], []}, fn name, {found, to_create} ->
+ case Map.get(lookup, normalize_name(name)) do
+ nil -> {found, [name | to_create]}
+ group -> {[%{id: group.id, name: group.name} | found], to_create}
+ end
+ end)
+
+ %{groups_found: Enum.reverse(found), groups_to_create: Enum.reverse(to_create)}
+ end
+
+ defp resolve_fee_types(%{fee_type_column_index: nil}, _rows, _actor) do
+ %{fee_type_map: %{}, fee_type_warnings: [], has_empty_fee_type_cells?: false}
+ end
+
+ defp resolve_fee_types(%{fee_type_column_index: index}, rows, actor) do
+ lookup = build_fee_type_lookup(actor)
+
+ cells = Enum.map(rows, fn {_line, values} -> Enum.at(values, index) end)
+
+ has_empty? = Enum.any?(cells, &blank?/1)
+
+ {fee_type_map, warnings} =
+ cells
+ |> Enum.reject(&blank?/1)
+ |> Enum.uniq_by(&normalize_fee_type_name/1)
+ |> Enum.reduce({%{}, []}, fn name, {map, warnings} ->
+ case Map.get(lookup, normalize_fee_type_name(name)) do
+ nil -> {map, [String.trim(name) | warnings]}
+ id -> {Map.put(map, normalize_fee_type_name(name), id), warnings}
+ end
+ end)
+
+ %{
+ fee_type_map: fee_type_map,
+ fee_type_warnings: Enum.reverse(warnings),
+ has_empty_fee_type_cells?: has_empty?
+ }
+ end
+
+ @doc """
+ Normalizes a fee-type name using the same rules as CSV header normalization
+ (trim, lowercase, transliterate, drop hyphens and whitespace).
+ """
+ @spec normalize_fee_type_name(String.t() | nil) :: String.t()
+ def normalize_fee_type_name(name) when is_binary(name), do: HeaderMapper.normalize_header(name)
+ def normalize_fee_type_name(_), do: ""
+
+ defp build_fee_type_lookup(actor) do
+ actor
+ |> list_fee_types()
+ |> Enum.reduce(%{}, fn fee_type, acc ->
+ normalized = normalize_fee_type_name(fee_type.name)
+
+ if Map.has_key?(acc, normalized) do
+ Logger.warning(
+ "Multiple membership fee types normalize to #{inspect(normalized)}; using the first match for CSV import."
+ )
+
+ acc
+ else
+ Map.put(acc, normalized, fee_type.id)
+ end
+ end)
+ end
+
+ defp list_fee_types(actor) do
+ Mv.MembershipFees.list_membership_fee_types!(actor: actor)
+ end
+
+ defp blank?(nil), do: true
+ defp blank?(value) when is_binary(value), do: String.trim(value) == ""
+ defp blank?(_), do: false
+
+ @doc """
+ Finds an existing group by name (case-insensitive) or creates it.
+
+ Looks first in the pre-fetched `groups` list, then in the database (to catch
+ groups created earlier in the same import), and only creates a new group when
+ none is found. This keeps group resolution idempotent across re-imports.
+ """
+ @spec create_or_find_group(String.t(), [Mv.Membership.Group.t()], term()) ::
+ {:ok, Mv.Membership.Group.t()} | {:error, term()}
+ def create_or_find_group(name, groups, actor) when is_binary(name) do
+ trimmed = String.trim(name)
+ normalized = normalize_name(trimmed)
+
+ case find_group_in_list(groups, normalized) do
+ nil -> find_or_create_group(trimmed, normalized, actor)
+ group -> {:ok, group}
+ end
+ end
+
+ defp find_group_in_list(groups, normalized) do
+ Enum.find(groups, fn group -> normalize_name(group.name) == normalized end)
+ end
+
+ defp find_or_create_group(trimmed, normalized, actor) do
+ case fetch_group_by_normalized_name(normalized, actor) do
+ nil -> create_group(trimmed, normalized, actor)
+ group -> {:ok, group}
+ end
+ end
+
+ # Normalizes the Ash code-interface return to a two-shape result.
+ #
+ # On a create failure the group may have been created concurrently by another
+ # import session between our read and our write (the DB unique index is the
+ # final arbiter, and the name validation is fail-open). Re-fetch by normalized
+ # name and link to the existing group rather than failing the row.
+ defp create_group(name, normalized, actor) do
+ case Mv.Membership.create_group(%{name: name}, actor: actor) do
+ {:ok, %Mv.Membership.Group{} = group} ->
+ {:ok, group}
+
+ {:error, reason} ->
+ case fetch_group_by_normalized_name(normalized, actor) do
+ nil -> {:error, reason}
+ group -> {:ok, group}
+ end
+ end
+ end
+
+ # Fetches a single group by case-insensitive name using a name-filtered query
+ # rather than reading the whole groups table. `normalized` is the trimmed,
+ # lower-cased name; the DB comparison uses LOWER(name) consistent with the
+ # Group resource's case-insensitive uniqueness constraint.
+ defp fetch_group_by_normalized_name(normalized, actor) do
+ require Ash.Query
+
+ Mv.Membership.Group
+ |> Ash.Query.filter(fragment("LOWER(?) = ?", name, ^normalized))
+ |> Ash.read(actor: actor, domain: Mv.Membership)
+ |> case do
+ {:ok, [group | _]} -> group
+ _ -> nil
+ end
+ end
+
+ @doc """
+ Splits a raw groups-cell value into trimmed, non-empty group names.
+ """
+ @spec split_group_names(String.t() | nil) :: [String.t()]
+ def split_group_names(nil), do: []
+
+ def split_group_names(cell) when is_binary(cell) do
+ cell
+ |> String.split(",")
+ |> Enum.map(&String.trim/1)
+ |> Enum.reject(&(&1 == ""))
+ end
+
+ defp unique_group_names(rows, index) do
+ rows
+ |> Enum.flat_map(fn {_line, values} ->
+ values
+ |> Enum.at(index)
+ |> split_group_names()
+ end)
+ |> Enum.uniq_by(&normalize_name/1)
+ end
+
+ defp preview_rows(rows) do
+ rows
+ |> Enum.take(@preview_row_limit)
+ |> Enum.map(fn {_line, values} -> values end)
+ end
+
+ defp list_groups(actor) do
+ Mv.Membership.list_groups!(actor: actor)
+ end
+
+ defp build_group_lookup(groups) do
+ Enum.reduce(groups, %{}, fn group, acc ->
+ Map.put(acc, normalize_name(group.name), group)
+ end)
+ end
+
+ # Case-insensitive comparison consistent with the Group resource's
+ # case-insensitive name uniqueness.
+ defp normalize_name(name) when is_binary(name) do
+ name |> String.trim() |> String.downcase()
+ end
+end
diff --git a/test/mv/membership/import/column_resolver_query_test.exs b/test/mv/membership/import/column_resolver_query_test.exs
new file mode 100644
index 0000000..7ac1fee
--- /dev/null
+++ b/test/mv/membership/import/column_resolver_query_test.exs
@@ -0,0 +1,72 @@
+defmodule Mv.Membership.Import.ColumnResolverQueryTest do
+ # async: false — attaches a global telemetry handler to inspect emitted SQL.
+ use Mv.DataCase, async: false
+
+ alias Mv.Membership.Import.ColumnResolver
+
+ setup do
+ %{actor: Mv.Helpers.SystemActor.get_system_actor()}
+ end
+
+ describe "create_or_find_group/3 group lookup is name-filtered (no full-table scan)" do
+ test "resolving a new name absent from the snapshot queries by name, not the whole table",
+ %{actor: actor} do
+ # Populate the table so a full-table read would be costly and observable.
+ for n <- 1..20, do: Mv.Fixtures.group_fixture(%{name: "Existing #{n}"})
+
+ queries =
+ capture_group_select_queries(fn ->
+ # The name is absent from the (empty) snapshot, forcing a DB lookup
+ # before the create attempt. That lookup must filter by name.
+ assert {:ok, group} = ColumnResolver.create_or_find_group("New One", [], actor)
+ assert group.name == "New One"
+ end)
+
+ # No SELECT against the groups table issued during resolution may be an
+ # unfiltered full-table scan. The pre-create existence check must filter by
+ # name (carry a WHERE predicate).
+ refute Enum.any?(queries, &unfiltered_groups_select?/1),
+ "expected no unfiltered groups table scan, got:\n#{Enum.join(queries, "\n")}"
+ end
+ end
+
+ defp capture_group_select_queries(fun) do
+ test_pid = self()
+ handler_id = "test-group-query-#{System.unique_integer([:positive])}"
+
+ :telemetry.attach(
+ handler_id,
+ [:mv, :repo, :query],
+ fn _event, _measurements, metadata, _config ->
+ sql = metadata[:query] || ""
+
+ if String.contains?(sql, "SELECT") and String.contains?(sql, "\"groups\"") do
+ send(test_pid, {:group_query, sql})
+ end
+ end,
+ nil
+ )
+
+ try do
+ fun.()
+ after
+ :telemetry.detach(handler_id)
+ end
+
+ collect_group_queries([])
+ end
+
+ defp collect_group_queries(acc) do
+ receive do
+ {:group_query, sql} -> collect_group_queries([sql | acc])
+ after
+ 0 -> Enum.reverse(acc)
+ end
+ end
+
+ # An unfiltered groups SELECT reads the whole table: it selects FROM "groups"
+ # with no WHERE clause at all. A name-filtered lookup carries a WHERE predicate.
+ defp unfiltered_groups_select?(sql) do
+ String.contains?(sql, "FROM \"groups\"") and not String.contains?(sql, "WHERE")
+ end
+end
diff --git a/test/mv/membership/import/column_resolver_test.exs b/test/mv/membership/import/column_resolver_test.exs
new file mode 100644
index 0000000..43b4288
--- /dev/null
+++ b/test/mv/membership/import/column_resolver_test.exs
@@ -0,0 +1,227 @@
+defmodule Mv.Membership.Import.ColumnResolverTest do
+ use Mv.DataCase, async: true
+ use ExUnitProperties
+
+ alias Mv.Membership.Import.ColumnResolver
+
+ setup do
+ %{actor: Mv.Helpers.SystemActor.get_system_actor()}
+ end
+
+ defp fee_type_fixture(name, actor) do
+ {:ok, fee_type} =
+ Mv.MembershipFees.create_membership_fee_type(
+ %{name: name, amount: Decimal.new("10.00"), interval: :yearly},
+ actor: actor
+ )
+
+ fee_type
+ end
+
+ defp header_maps(overrides) do
+ Map.merge(
+ %{
+ member: %{email: 0},
+ custom: %{},
+ unknown: [],
+ ignored: [],
+ groups_column_index: nil,
+ fee_type_column_index: nil
+ },
+ overrides
+ )
+ end
+
+ describe "resolve/3 group classification" do
+ test "splits group names into found (existing) and to_create (missing)", %{actor: actor} do
+ existing = Mv.Fixtures.group_fixture(%{name: "Orchester"})
+
+ maps = header_maps(%{member: %{email: 0}, groups_column_index: 1})
+
+ rows = [
+ {2, ["a@example.com", "Orchester"]},
+ {3, ["b@example.com", "Neues Ensemble"]}
+ ]
+
+ result = ColumnResolver.resolve(maps, rows, actor)
+
+ assert Enum.any?(result.groups_found, &(&1.name == "Orchester" and &1.id == existing.id))
+ assert "Neues Ensemble" in result.groups_to_create
+ refute "Orchester" in result.groups_to_create
+ end
+
+ test "groups_found and groups_to_create are empty when no groups column", %{actor: actor} do
+ maps = header_maps(%{})
+ rows = [{2, ["a@example.com"]}]
+
+ result = ColumnResolver.resolve(maps, rows, actor)
+
+ assert result.groups_found == []
+ assert result.groups_to_create == []
+ end
+ end
+
+ describe "resolve/3 preview rows" do
+ test "returns up to 3 preview rows", %{actor: actor} do
+ maps = header_maps(%{})
+
+ rows = [
+ {2, ["a@example.com"]},
+ {3, ["b@example.com"]},
+ {4, ["c@example.com"]},
+ {5, ["d@example.com"]}
+ ]
+
+ result = ColumnResolver.resolve(maps, rows, actor)
+
+ assert length(result.preview_rows) == 3
+ assert result.preview_rows == [["a@example.com"], ["b@example.com"], ["c@example.com"]]
+ end
+
+ test "returns fewer preview rows when file has fewer data rows", %{actor: actor} do
+ maps = header_maps(%{})
+ rows = [{2, ["a@example.com"]}]
+
+ result = ColumnResolver.resolve(maps, rows, actor)
+
+ assert result.preview_rows == [["a@example.com"]]
+ end
+ end
+
+ describe "resolve/3 fee-type resolution" do
+ test "maps known fee-type names to their id by normalized name", %{actor: actor} do
+ standard = fee_type_fixture("Standard", actor)
+
+ maps = header_maps(%{fee_type_column_index: 1})
+ rows = [{2, ["a@example.com", "Standard"]}]
+
+ result = ColumnResolver.resolve(maps, rows, actor)
+
+ assert result.fee_type_map["standard"] == standard.id
+ assert result.fee_type_warnings == []
+ end
+
+ test "records a warning for an unknown fee-type name", %{actor: actor} do
+ maps = header_maps(%{fee_type_column_index: 1})
+ rows = [{2, ["a@example.com", "Nonexistent Type"]}]
+
+ result = ColumnResolver.resolve(maps, rows, actor)
+
+ assert "Nonexistent Type" in result.fee_type_warnings
+ end
+
+ test "sets has_empty_fee_type_cells? when a fee-type cell is blank", %{actor: actor} do
+ fee_type_fixture("Standard", actor)
+
+ maps = header_maps(%{fee_type_column_index: 1})
+
+ rows = [
+ {2, ["a@example.com", "Standard"]},
+ {3, ["b@example.com", " "]}
+ ]
+
+ result = ColumnResolver.resolve(maps, rows, actor)
+
+ assert result.has_empty_fee_type_cells? == true
+ end
+
+ test "has_empty_fee_type_cells? is false when all cells filled", %{actor: actor} do
+ fee_type_fixture("Standard", actor)
+
+ maps = header_maps(%{fee_type_column_index: 1})
+ rows = [{2, ["a@example.com", "Standard"]}]
+
+ result = ColumnResolver.resolve(maps, rows, actor)
+
+ assert result.has_empty_fee_type_cells? == false
+ end
+
+ test "fee-type resolution defaults are empty when no fee-type column", %{actor: actor} do
+ maps = header_maps(%{})
+ rows = [{2, ["a@example.com"]}]
+
+ result = ColumnResolver.resolve(maps, rows, actor)
+
+ assert result.fee_type_map == %{}
+ assert result.fee_type_warnings == []
+ assert result.has_empty_fee_type_cells? == false
+ end
+ end
+
+ describe "create_or_find_group/3" do
+ test "creates a new group when none exists", %{actor: actor} do
+ assert {:ok, group} = ColumnResolver.create_or_find_group("Brand New Group", [], actor)
+ assert group.name == "Brand New Group"
+ end
+
+ test "returns the existing group from the pre-fetched list without creating", %{actor: actor} do
+ existing = Mv.Fixtures.group_fixture(%{name: "Existing Group"})
+ before_count = length(Mv.Membership.list_groups!(actor: actor))
+
+ assert {:ok, group} =
+ ColumnResolver.create_or_find_group("Existing Group", [existing], actor)
+
+ assert group.id == existing.id
+ assert length(Mv.Membership.list_groups!(actor: actor)) == before_count
+ end
+
+ test "resolves to a group created concurrently after the snapshot was taken",
+ %{actor: actor} do
+ # Simulates a concurrent import session: the group name is absent from the
+ # caller's pre-fetched snapshot, but the group now exists in the DB. The
+ # resolver must link to the existing group, never error or duplicate it.
+ stale_snapshot = []
+ _concurrently_created = Mv.Fixtures.group_fixture(%{name: "Concurrent Group"})
+ before_count = length(Mv.Membership.list_groups!(actor: actor))
+
+ assert {:ok, group} =
+ ColumnResolver.create_or_find_group("Concurrent Group", stale_snapshot, actor)
+
+ assert group.name == "Concurrent Group"
+ assert length(Mv.Membership.list_groups!(actor: actor)) == before_count
+ end
+
+ property "is idempotent: same names never create duplicate groups", %{actor: actor} do
+ check all(
+ names <-
+ StreamData.list_of(
+ StreamData.string(:alphanumeric, min_length: 1, max_length: 20),
+ min_length: 1,
+ max_length: 5
+ ),
+ max_runs: 25
+ ) do
+ names = Enum.map(names, &("grp-" <> &1))
+
+ existing = Mv.Membership.list_groups!(actor: actor)
+ first_ids = resolve_all(names, existing, actor)
+
+ existing_after = Mv.Membership.list_groups!(actor: actor)
+ second_ids = resolve_all(names, existing_after, actor)
+
+ # Same name always resolves to the same group id across both passes.
+ assert first_ids == second_ids
+
+ # No duplicate groups exist for any of the names (case-insensitive).
+ all_groups = Mv.Membership.list_groups!(actor: actor)
+
+ for name <- Enum.uniq_by(names, &String.downcase/1) do
+ matching =
+ Enum.filter(all_groups, fn g ->
+ String.downcase(g.name) == String.downcase(name)
+ end)
+
+ assert length(matching) == 1
+ end
+ end
+ end
+ end
+
+ defp resolve_all(names, existing, actor) do
+ Enum.map(names, fn name ->
+ {:ok, group} = ColumnResolver.create_or_find_group(name, existing, actor)
+ {String.downcase(name), group.id}
+ end)
+ |> Map.new()
+ end
+end
From 00e1624ee4cf13828538843efeb1ee7e3f134463 Mon Sep 17 00:00:00 2001
From: Moritz
Date: Wed, 3 Jun 2026 02:15:54 +0200
Subject: [PATCH 07/23] feat(import): assign groups and fee types to imported
members, creating missing groups
---
lib/mv/membership/import/header_mapper.ex | 15 +-
lib/mv/membership/import/member_csv.ex | 265 +++++++++++++++---
priv/gettext/de/LC_MESSAGES/default.po | 13 +-
priv/gettext/default.pot | 10 +
priv/gettext/en/LC_MESSAGES/default.po | 13 +-
test/mv/membership/import/member_csv_test.exs | 252 +++++++++++++++++
6 files changed, 517 insertions(+), 51 deletions(-)
diff --git a/lib/mv/membership/import/header_mapper.ex b/lib/mv/membership/import/header_mapper.ex
index 3047944..eb8bb04 100644
--- a/lib/mv/membership/import/header_mapper.ex
+++ b/lib/mv/membership/import/header_mapper.ex
@@ -29,12 +29,21 @@ defmodule Mv.Membership.Import.HeaderMapper do
Supports English and German header variants (e.g. "Email" / "E-Mail", "Join Date" / "Beitrittsdatum").
+ ## Special columns
+
+ - **groups** – Many-to-many relationship (through member_groups). Recognized via the
+ `groups_column_index` key (headers `Groups`, `Gruppen`, `Gruppe`). Comma-separated
+ names are resolved during processing; missing groups are auto-created.
+ - **membership_fee_type** – Recognized via the `fee_type_column_index` key (headers
+ `Fee Type`, `fee_type`, `membership_fee_type`, `Beitragsart`). Names are matched to
+ existing fee types; unknown names fall back to the default fee type.
+
## Fields not supported for import
- **membership_fee_status** – Computed (calculation from membership fee cycles). Not stored;
- cannot be set via CSV. Export can include it.
- - **groups** – Many-to-many relationship (through member_groups). Import would require
- resolving group names/slugs to IDs and creating associations; not in current import scope.
+ cannot be set via CSV. Export can include it. Fee-status header variants
+ (`Membership Fee Status`, `Bezahlstatus`, `Mitgliedsbeitragsstatus`) are explicitly
+ placed in the `ignored` list and never mapped.
## Custom Field Detection
diff --git a/lib/mv/membership/import/member_csv.ex b/lib/mv/membership/import/member_csv.ex
index dda1d04..d0ab74b 100644
--- a/lib/mv/membership/import/member_csv.ex
+++ b/lib/mv/membership/import/member_csv.ex
@@ -6,7 +6,7 @@ defmodule Mv.Membership.Import.MemberCSV do
This module provides the core API for CSV member import functionality:
- `prepare/2` - Parses and validates CSV content, returns import state
- - `process_chunk/3` - Processes a chunk of rows and creates members
+ - `process_chunk/4` - Processes a chunk of rows and creates members
## Error Handling
@@ -22,10 +22,18 @@ defmodule Mv.Membership.Import.MemberCSV do
- `column_map` - Map of canonical field names to column indices
- `custom_field_map` - Map of custom field names to column indices
- `warnings` - List of warning messages (e.g., unknown custom field columns)
+ - `headers` - The raw CSV header row
+ - `ignored` - Header names of ignored (fee-status) columns
+ - `groups_column_index` / `fee_type_column_index` - Indices for resolved columns (or nil)
+ - `groups_found` / `groups_to_create` - Existing and to-be-created groups from the preview
+ - `fee_type_map` - Normalized fee-type name to id, for matched fee types
+ - `fee_type_warnings` - Unmatched fee-type names surfaced in the preview
+ - `has_empty_fee_type_cells?` - Whether any fee-type cell is blank (default applies)
+ - `preview_rows` - Up to 3 sample data rows for the mapping preview
## Chunk Results
- The `chunk_result` returned by `process_chunk/3` contains:
+ The `chunk_result` returned by `process_chunk/4` contains:
- `inserted` - Number of successfully created members
- `failed` - Number of failed member creations
- `errors` - List of `%MemberCSV.Error{}` structs (capped at 50 per import)
@@ -37,7 +45,9 @@ defmodule Mv.Membership.Import.MemberCSV do
# Process first chunk
chunk = Enum.at(import_state.chunks, 0)
- {:ok, result} = MemberCSV.process_chunk(chunk, import_state.column_map)
+
+ {:ok, result} =
+ MemberCSV.process_chunk(chunk, import_state.column_map, import_state.custom_field_map, [])
"""
defmodule Error do
@@ -66,16 +76,28 @@ defmodule Mv.Membership.Import.MemberCSV do
custom_field_lookup: %{
String.t() => %{id: String.t(), value_type: atom(), name: String.t()}
},
- warnings: list(String.t())
+ warnings: list(String.t()),
+ headers: list(String.t()),
+ ignored: list(String.t()),
+ groups_column_index: non_neg_integer() | nil,
+ fee_type_column_index: non_neg_integer() | nil,
+ groups_found: list(%{id: String.t(), name: String.t()}),
+ groups_to_create: list(String.t()),
+ fee_type_map: %{String.t() => String.t()},
+ fee_type_warnings: list(String.t()),
+ has_empty_fee_type_cells?: boolean(),
+ preview_rows: list(list(String.t()))
}
@type chunk_result :: %{
inserted: non_neg_integer(),
failed: non_neg_integer(),
errors: list(Error.t()),
- errors_truncated?: boolean()
+ errors_truncated?: boolean(),
+ warnings: list(String.t())
}
+ alias Mv.Membership.Import.ColumnResolver
alias Mv.Membership.Import.CsvParser
alias Mv.Membership.Import.HeaderMapper
@@ -139,13 +161,27 @@ defmodule Mv.Membership.Import.MemberCSV do
# Build custom field lookup for efficient value processing
custom_field_lookup = build_custom_field_lookup(custom_fields)
+ # Resolve DB-backed columns (groups, fee types) read-only for the preview.
+ resolution = ColumnResolver.resolve(maps, rows, actor)
+ ignored_headers = Enum.map(maps.ignored, &Enum.at(headers, &1))
+
{:ok,
%{
chunks: chunks,
column_map: maps.member,
custom_field_map: maps.custom,
custom_field_lookup: custom_field_lookup,
- warnings: warnings
+ warnings: warnings,
+ headers: headers,
+ ignored: ignored_headers,
+ groups_column_index: maps.groups_column_index,
+ fee_type_column_index: maps.fee_type_column_index,
+ groups_found: resolution.groups_found,
+ groups_to_create: resolution.groups_to_create,
+ fee_type_map: resolution.fee_type_map,
+ fee_type_warnings: resolution.fee_type_warnings,
+ has_empty_fee_type_cells?: resolution.has_empty_fee_type_cells?,
+ preview_rows: resolution.preview_rows
}}
end
end
@@ -180,7 +216,7 @@ defmodule Mv.Membership.Import.MemberCSV do
end)
case HeaderMapper.build_maps(headers, custom_field_maps) do
- {:ok, %{member: member_map, custom: custom_map, unknown: unknown}} ->
+ {:ok, %{unknown: unknown} = maps} ->
# Build warnings for unknown custom field columns
warnings =
unknown
@@ -197,7 +233,7 @@ defmodule Mv.Membership.Import.MemberCSV do
)
end)
- {:ok, %{member: member_map, custom: custom_map}, warnings}
+ {:ok, maps, warnings}
{:error, reason} ->
{:error, reason}
@@ -250,9 +286,20 @@ defmodule Mv.Membership.Import.MemberCSV do
Map.put(acc, custom_field_id, value)
end)
- %{member: member_map, custom: custom_map}
+ %{
+ member: member_map,
+ custom: custom_map,
+ fee_type: cell_at(row_tuple, tuple_size, maps.fee_type_column_index),
+ groups: cell_at(row_tuple, tuple_size, maps.groups_column_index)
+ }
end
+ # Returns the raw cell at the given index, or nil if the column is absent.
+ defp cell_at(_row_tuple, _size, nil), do: nil
+
+ defp cell_at(row_tuple, size, index) when index < size, do: elem(row_tuple, index)
+ defp cell_at(_row_tuple, _size, _index), do: ""
+
@doc """
Processes a chunk of CSV rows and creates members.
@@ -268,12 +315,18 @@ defmodule Mv.Membership.Import.MemberCSV do
- `chunk_rows_with_lines` - List of tuples `{csv_line_number, row_map}` where:
- `csv_line_number` - Physical line number in CSV (1-based)
- `row_map` - Map with `:member` and `:custom` keys containing field values
- - `column_map` - Map of canonical field names (atoms) to column indices (for reference)
- - `custom_field_map` - Map of custom field IDs (strings) to column indices (for reference)
+ - `column_map` - Unused; kept for backward-compatible call sites. Field values are
+ read from each row's pre-built `:member`/`:custom` maps, not from this argument.
+ - `custom_field_map` - Unused; kept for backward-compatible call sites (see above).
- `opts` - Optional keyword list for processing options:
- `:custom_field_lookup` - Map of custom field IDs to metadata (default: `%{}`)
- `:existing_error_count` - Number of errors already collected in previous chunks (default: `0`)
- `:max_errors` - Maximum number of errors to collect per import overall (default: `50`)
+ - `:actor` - Actor used for all writes (default: the system actor)
+ - `:fee_type_map` - Map of normalized fee-type name to fee-type id, used to resolve
+ each row's fee-type cell (default: `%{}`)
+ - `:groups_found` - List of pre-fetched `Group` structs seeding in-memory group
+ resolution; the snapshot grows as groups are auto-created (default: `[]`)
## Error Capping
@@ -312,27 +365,49 @@ defmodule Mv.Membership.Import.MemberCSV do
existing_error_count = Keyword.get(opts, :existing_error_count, 0)
max_errors = Keyword.get(opts, :max_errors, @default_max_errors)
actor = Keyword.get(opts, :actor, SystemActor.get_system_actor())
+ fee_type_map = Keyword.get(opts, :fee_type_map, %{})
+ groups_found = Keyword.get(opts, :groups_found, [])
- {inserted, failed, errors, _collected_error_count, truncated?} =
- Enum.reduce(chunk_rows_with_lines, {0, 0, [], 0, false}, fn {line_number, row_map},
- {acc_inserted, acc_failed,
- acc_errors, acc_error_count,
- acc_truncated?} ->
+ base_row_opts = %{
+ custom_field_lookup: custom_field_lookup,
+ fee_type_map: fee_type_map,
+ actor: actor
+ }
+
+ {inserted, failed, errors, _collected_error_count, truncated?, warnings, _groups_acc} =
+ Enum.reduce(chunk_rows_with_lines, {0, 0, [], 0, false, [], groups_found}, fn {line_number,
+ row_map},
+ {acc_inserted,
+ acc_failed,
+ acc_errors,
+ acc_error_count,
+ acc_truncated?,
+ acc_warnings,
+ acc_groups} ->
current_error_count = existing_error_count + acc_error_count
+ row_opts = Map.put(base_row_opts, :groups_found, acc_groups)
- case process_row(row_map, line_number, custom_field_lookup, actor) do
- {:ok, _member} ->
- update_inserted(
- {acc_inserted, acc_failed, acc_errors, acc_error_count, acc_truncated?}
- )
+ case process_row(row_map, line_number, row_opts) do
+ {:ok, _member, row_warnings, new_groups} ->
+ {new_inserted, new_failed, new_errors, new_error_count, new_truncated?} =
+ update_inserted(
+ {acc_inserted, acc_failed, acc_errors, acc_error_count, acc_truncated?}
+ )
- {:error, error} ->
- handle_row_error(
- {acc_inserted, acc_failed, acc_errors, acc_error_count, acc_truncated?},
- error,
- current_error_count,
- max_errors
- )
+ {new_inserted, new_failed, new_errors, new_error_count, new_truncated?,
+ acc_warnings ++ row_warnings, new_groups}
+
+ {:error, error, new_groups} ->
+ {new_inserted, new_failed, new_errors, new_error_count, new_truncated?} =
+ handle_row_error(
+ {acc_inserted, acc_failed, acc_errors, acc_error_count, acc_truncated?},
+ error,
+ current_error_count,
+ max_errors
+ )
+
+ {new_inserted, new_failed, new_errors, new_error_count, new_truncated?, acc_warnings,
+ new_groups}
end
end)
@@ -341,7 +416,8 @@ defmodule Mv.Membership.Import.MemberCSV do
inserted: inserted,
failed: failed,
errors: Enum.reverse(errors),
- errors_truncated?: truncated?
+ errors_truncated?: truncated?,
+ warnings: warnings
}}
end
@@ -505,18 +581,27 @@ defmodule Mv.Membership.Import.MemberCSV do
defp gettext_error_message(_), do: gettext("Email is invalid.")
- # Processes a single row and creates member with custom field values
+ # Processes a single row and creates member with custom field values.
+ # On success returns {:ok, member, warnings, groups}; warnings carry non-fatal
+ # notices such as an unresolved fee-type name. The returned groups list is the
+ # accumulated in-memory group snapshot (seeded from the chunk, grown with any
+ # group created while linking this row) so later rows reuse it instead of
+ # re-reading the whole Group table per row.
defp process_row(
row_map,
line_number,
- custom_field_lookup,
- actor
+ %{
+ custom_field_lookup: custom_field_lookup,
+ fee_type_map: fee_type_map,
+ groups_found: groups_found,
+ actor: actor
+ } = _row_opts
) do
# Validate row before database insertion
case validate_row(row_map, line_number, []) do
{:error, error} ->
# Return validation error immediately, no DB insert attempted
- {:error, error}
+ {:error, error, groups_found}
{:ok, %{member: trimmed_member_attrs, custom: custom_attrs}} ->
# Prepare custom field values for Ash
@@ -524,20 +609,119 @@ defmodule Mv.Membership.Import.MemberCSV do
{:error, validation_errors} ->
# Custom field validation errors - return first error
first_error = List.first(validation_errors)
- {:error, %Error{csv_line_number: line_number, field: nil, message: first_error}}
+
+ {:error, %Error{csv_line_number: line_number, field: nil, message: first_error},
+ groups_found}
{:ok, custom_field_values} ->
- create_member_with_custom_fields(
- trimmed_member_attrs,
+ {fee_attrs, warnings} =
+ resolve_fee_type_attrs(Map.get(row_map, :fee_type), fee_type_map)
+
+ create_member_and_assign_groups(
+ Map.merge(trimmed_member_attrs, fee_attrs),
custom_field_values,
+ Map.get(row_map, :groups),
+ groups_found,
line_number,
- actor
+ actor,
+ warnings
)
end
end
rescue
e ->
- {:error, %Error{csv_line_number: line_number, field: nil, message: Exception.message(e)}}
+ {:error, %Error{csv_line_number: line_number, field: nil, message: Exception.message(e)},
+ groups_found}
+ end
+
+ # Creates the member, then assigns groups as a post-creation step. A group
+ # assignment failure fails the row (the member was already created, but the
+ # row is reported as failed so the operator can act on it).
+ defp create_member_and_assign_groups(
+ member_attrs,
+ custom_field_values,
+ groups_cell,
+ groups_found,
+ line_number,
+ actor,
+ warnings
+ ) do
+ case create_member_with_custom_fields(
+ member_attrs,
+ custom_field_values,
+ line_number,
+ actor,
+ warnings
+ ) do
+ {:ok, member, member_warnings} ->
+ assign_groups(member, groups_cell, groups_found, line_number, actor, member_warnings)
+
+ {:error, error} ->
+ {:error, error, groups_found}
+ end
+ end
+
+ # Assigns the member to all groups listed in the cell, creating missing groups.
+ # Returns the (possibly grown) group snapshot so the caller can reuse it.
+ defp assign_groups(member, groups_cell, groups_found, line_number, actor, warnings) do
+ names = ColumnResolver.split_group_names(groups_cell)
+
+ Enum.reduce_while(names, {:ok, member, warnings, groups_found}, fn name,
+ {:ok, _m, _w, acc_groups} ->
+ case link_member_to_group(member, name, acc_groups, actor) do
+ {:ok, group} ->
+ {:cont, {:ok, member, warnings, add_group(acc_groups, group)}}
+
+ {:error, reason} ->
+ {:halt,
+ {:error,
+ %Error{
+ csv_line_number: line_number,
+ field: nil,
+ message: gettext("Group assignment failed: %{reason}", reason: inspect(reason))
+ }, acc_groups}}
+ end
+ end)
+ end
+
+ defp add_group(groups, group) do
+ if Enum.any?(groups, &(&1.id == group.id)), do: groups, else: [group | groups]
+ end
+
+ defp link_member_to_group(member, name, groups_found, actor) do
+ with {:ok, group} <- ColumnResolver.create_or_find_group(name, groups_found, actor),
+ {:ok, _member_group} <-
+ Mv.Membership.create_member_group(
+ %{member_id: member.id, group_id: group.id},
+ actor: actor
+ ) do
+ {:ok, group}
+ end
+ end
+
+ # Resolves the fee-type cell into member attrs plus optional warnings.
+ # Empty cell -> default fee type (SetDefaultMembershipFeeType), no warning.
+ # Matched name -> membership_fee_type_id attr.
+ # Unmatched name -> no attr (default applies), warning naming the value.
+ defp resolve_fee_type_attrs(nil, _fee_type_map), do: {%{}, []}
+
+ defp resolve_fee_type_attrs(cell, fee_type_map) when is_binary(cell) do
+ trimmed = String.trim(cell)
+
+ if trimmed == "" do
+ {%{}, []}
+ else
+ case Map.get(fee_type_map, ColumnResolver.normalize_fee_type_name(trimmed)) do
+ nil ->
+ {%{},
+ [
+ gettext("Fee type '%{name}' not found; using the default fee type.", name: trimmed)
+ ]}
+
+ fee_type_id ->
+ {%{membership_fee_type_id: fee_type_id}, []}
+ end
+ end
end
# Creates a member with custom field values, handling errors appropriately
@@ -545,7 +729,8 @@ defmodule Mv.Membership.Import.MemberCSV do
trimmed_member_attrs,
custom_field_values,
line_number,
- actor
+ actor,
+ warnings
) do
# Convert empty strings to nil for date fields so Ash accepts them
member_attrs = sanitize_date_fields(trimmed_member_attrs)
@@ -565,7 +750,7 @@ defmodule Mv.Membership.Import.MemberCSV do
case Mv.Membership.create_member(final_attrs, actor: actor) do
{:ok, member} ->
- {:ok, member}
+ {:ok, member, warnings}
{:error, %Ash.Error.Invalid{} = error} ->
# Extract email from final_attrs for better error messages
diff --git a/priv/gettext/de/LC_MESSAGES/default.po b/priv/gettext/de/LC_MESSAGES/default.po
index 81d91f7..9fa6cd4 100644
--- a/priv/gettext/de/LC_MESSAGES/default.po
+++ b/priv/gettext/de/LC_MESSAGES/default.po
@@ -3968,7 +3968,12 @@ msgstr "Zeitraum"
msgid "To"
msgstr "Bis"
-#~ #: lib/mv_web/live/group_live/show.ex
-#~ #, elixir-autogen, elixir-format
-#~ msgid "No members selected."
-#~ msgstr "Keine Mitglieder ausgewählt."
+#: lib/mv/membership/import/member_csv.ex
+#, elixir-autogen, elixir-format
+msgid "Fee type '%{name}' not found; using the default fee type."
+msgstr "Beitragsart '%{name}' nicht gefunden; Standard-Beitragsart wird verwendet."
+
+#: lib/mv/membership/import/member_csv.ex
+#, elixir-autogen, elixir-format
+msgid "Group assignment failed: %{reason}"
+msgstr "Gruppenzuordnung fehlgeschlagen: %{reason}"
diff --git a/priv/gettext/default.pot b/priv/gettext/default.pot
index 5e9abca..c961420 100644
--- a/priv/gettext/default.pot
+++ b/priv/gettext/default.pot
@@ -3967,3 +3967,13 @@ msgstr ""
#, elixir-autogen, elixir-format
msgid "To"
msgstr ""
+
+#: lib/mv/membership/import/member_csv.ex
+#, elixir-autogen, elixir-format
+msgid "Fee type '%{name}' not found; using the default fee type."
+msgstr ""
+
+#: lib/mv/membership/import/member_csv.ex
+#, elixir-autogen, elixir-format
+msgid "Group assignment failed: %{reason}"
+msgstr ""
diff --git a/priv/gettext/en/LC_MESSAGES/default.po b/priv/gettext/en/LC_MESSAGES/default.po
index 1ae6a49..58aeead 100644
--- a/priv/gettext/en/LC_MESSAGES/default.po
+++ b/priv/gettext/en/LC_MESSAGES/default.po
@@ -3968,7 +3968,12 @@ msgstr ""
msgid "To"
msgstr ""
-#~ #: lib/mv_web/live/group_live/show.ex
-#~ #, elixir-autogen, elixir-format, fuzzy
-#~ msgid "No members selected."
-#~ msgstr ""
+#: lib/mv/membership/import/member_csv.ex
+#, elixir-autogen, elixir-format
+msgid "Fee type '%{name}' not found; using the default fee type."
+msgstr ""
+
+#: lib/mv/membership/import/member_csv.ex
+#, elixir-autogen, elixir-format
+msgid "Group assignment failed: %{reason}"
+msgstr ""
diff --git a/test/mv/membership/import/member_csv_test.exs b/test/mv/membership/import/member_csv_test.exs
index b4a099a..0701a92 100644
--- a/test/mv/membership/import/member_csv_test.exs
+++ b/test/mv/membership/import/member_csv_test.exs
@@ -1,5 +1,6 @@
defmodule Mv.Membership.Import.MemberCSVTest do
use Mv.DataCase, async: true
+ use ExUnitProperties
alias Mv.Membership.Import.MemberCSV
@@ -899,4 +900,255 @@ defmodule Mv.Membership.Import.MemberCSVTest do
assert import_state.chunks != []
end
end
+
+ describe "prepare/2 column resolution integration" do
+ setup do
+ %{actor: Mv.Helpers.SystemActor.get_system_actor()}
+ end
+
+ test "exposes resolver output keys in import_state", %{actor: actor} do
+ csv_content = "email\njohn@example.com"
+
+ assert {:ok, import_state} = MemberCSV.prepare(csv_content, actor: actor)
+
+ assert Map.has_key?(import_state, :ignored)
+ assert Map.has_key?(import_state, :groups_to_create)
+ assert Map.has_key?(import_state, :fee_type_map)
+ assert Map.has_key?(import_state, :fee_type_warnings)
+ assert Map.has_key?(import_state, :has_empty_fee_type_cells?)
+ assert Map.has_key?(import_state, :preview_rows)
+ end
+
+ test "fee-status column is reported as ignored, not as a custom field", %{actor: actor} do
+ {:ok, _custom_field} =
+ Mv.Membership.CustomField
+ |> Ash.Changeset.for_create(:create, %{name: "Bezahlstatus", value_type: :string})
+ |> Ash.create(actor: actor)
+
+ csv_content = "email;Bezahlstatus\njohn@example.com;paid"
+
+ assert {:ok, import_state} = MemberCSV.prepare(csv_content, actor: actor)
+
+ assert import_state.ignored == ["Bezahlstatus"]
+ assert import_state.custom_field_map == %{}
+ end
+
+ test "preview rows are limited to 3", %{actor: actor} do
+ csv_content = "email\na@example.com\nb@example.com\nc@example.com\nd@example.com"
+
+ assert {:ok, import_state} = MemberCSV.prepare(csv_content, actor: actor)
+
+ assert length(import_state.preview_rows) == 3
+ end
+ end
+
+ describe "process_chunk/4 fee-type assignment" do
+ setup do
+ actor = Mv.Helpers.SystemActor.get_system_actor()
+
+ {:ok, fee_type} =
+ Mv.MembershipFees.create_membership_fee_type(
+ %{name: "Premium", amount: Decimal.new("25.00"), interval: :yearly},
+ actor: actor
+ )
+
+ %{actor: actor, fee_type: fee_type}
+ end
+
+ test "sets membership_fee_type_id when fee-type cell matches a known type", %{
+ actor: actor,
+ fee_type: fee_type
+ } do
+ chunk = [
+ {2, %{member: %{email: "fee-known@example.com"}, custom: %{}, fee_type: "Premium"}}
+ ]
+
+ opts = [
+ actor: actor,
+ fee_type_map: %{"premium" => fee_type.id}
+ ]
+
+ assert {:ok, result} = MemberCSV.process_chunk(chunk, %{email: 0}, %{}, opts)
+ assert result.inserted == 1
+
+ member =
+ Mv.Membership.list_members!(actor: actor)
+ |> Enum.find(&(&1.email == "fee-known@example.com"))
+
+ assert member.membership_fee_type_id == fee_type.id
+ end
+
+ test "adds a warning when the fee-type name is unknown", %{actor: actor} do
+ chunk = [
+ {2, %{member: %{email: "fee-unknown@example.com"}, custom: %{}, fee_type: "Ghost Type"}}
+ ]
+
+ opts = [actor: actor, fee_type_map: %{}]
+
+ assert {:ok, result} = MemberCSV.process_chunk(chunk, %{email: 0}, %{}, opts)
+ assert result.inserted == 1
+ assert Enum.any?(result.warnings, &(&1 =~ "Ghost Type"))
+ end
+
+ test "uses the default fee type when the fee-type cell is empty", %{
+ actor: actor,
+ fee_type: fee_type
+ } do
+ {:ok, settings} = Mv.Membership.get_settings()
+
+ {:ok, _settings} =
+ Mv.Membership.update_settings(
+ settings,
+ %{default_membership_fee_type_id: fee_type.id},
+ actor: actor
+ )
+
+ chunk = [{2, %{member: %{email: "fee-empty@example.com"}, custom: %{}, fee_type: ""}}]
+
+ opts = [actor: actor, fee_type_map: %{}]
+
+ assert {:ok, result} = MemberCSV.process_chunk(chunk, %{email: 0}, %{}, opts)
+ assert result.inserted == 1
+
+ member =
+ Mv.Membership.list_members!(actor: actor)
+ |> Enum.find(&(&1.email == "fee-empty@example.com"))
+
+ # Default fee type assigned via SetDefaultMembershipFeeType.
+ assert member.membership_fee_type_id == fee_type.id
+ end
+ end
+
+ describe "process_chunk/4 group assignment" do
+ setup do
+ %{actor: Mv.Helpers.SystemActor.get_system_actor()}
+ end
+
+ defp group_names_for(email, actor) do
+ member =
+ Mv.Membership.list_members!(actor: actor)
+ |> Enum.find(&(&1.email == email))
+
+ member = Ash.load!(member, :groups, actor: actor)
+ member.groups |> Enum.map(& &1.name) |> Enum.sort()
+ end
+
+ test "assigns member to an existing group", %{actor: actor} do
+ existing = Mv.Fixtures.group_fixture(%{name: "Orchester"})
+
+ chunk = [
+ {2, %{member: %{email: "g-existing@example.com"}, custom: %{}, groups: "Orchester"}}
+ ]
+
+ opts = [actor: actor, groups_found: [existing]]
+
+ assert {:ok, result} = MemberCSV.process_chunk(chunk, %{email: 0}, %{}, opts)
+ assert result.inserted == 1
+
+ assert group_names_for("g-existing@example.com", actor) == ["Orchester"]
+
+ # No new group was created.
+ orchester = Enum.filter(Mv.Membership.list_groups!(actor: actor), &(&1.name == "Orchester"))
+ assert length(orchester) == 1
+ end
+
+ test "auto-creates an unknown group and assigns the member", %{actor: actor} do
+ chunk = [
+ {2, %{member: %{email: "g-new@example.com"}, custom: %{}, groups: "Frische Gruppe"}}
+ ]
+
+ opts = [actor: actor, groups_found: []]
+
+ assert {:ok, result} = MemberCSV.process_chunk(chunk, %{email: 0}, %{}, opts)
+ assert result.inserted == 1
+
+ assert group_names_for("g-new@example.com", actor) == ["Frische Gruppe"]
+ assert Enum.any?(Mv.Membership.list_groups!(actor: actor), &(&1.name == "Frische Gruppe"))
+ end
+
+ test "handles multiple comma-separated groups", %{actor: actor} do
+ chunk = [
+ {2, %{member: %{email: "g-multi@example.com"}, custom: %{}, groups: "Orchester, Chor"}}
+ ]
+
+ opts = [actor: actor, groups_found: []]
+
+ assert {:ok, result} = MemberCSV.process_chunk(chunk, %{email: 0}, %{}, opts)
+ assert result.inserted == 1
+
+ assert group_names_for("g-multi@example.com", actor) == ["Chor", "Orchester"]
+ end
+
+ test "does not re-read the group table once per row for a repeated novel name",
+ %{actor: actor} do
+ rows =
+ for i <- 1..10 do
+ {i + 1,
+ %{member: %{email: "g-nplus1-#{i}@example.com"}, custom: %{}, groups: "Shared Group"}}
+ end
+
+ group_read_count = Agent.start_link(fn -> 0 end) |> elem(1)
+ test_pid = self()
+
+ # process_chunk runs synchronously in this test process, so the telemetry
+ # handler (invoked in the query-executing process) sees self() == test_pid.
+ # Filtering on the pid keeps concurrent tests' group queries out of the count.
+ handler = fn _event, _measurements, metadata, _config ->
+ if self() == test_pid and metadata[:source] == "groups" and
+ is_binary(metadata[:query]) and String.starts_with?(metadata.query, "SELECT") do
+ Agent.update(group_read_count, &(&1 + 1))
+ end
+ end
+
+ handler_id = "test-group-read-counter-#{System.unique_integer([:positive])}"
+ :telemetry.attach(handler_id, [:mv, :repo, :query], handler, nil)
+
+ assert {:ok, %{inserted: 10}} =
+ MemberCSV.process_chunk(rows, %{email: 0}, %{}, actor: actor, groups_found: [])
+
+ reads = Agent.get(group_read_count, & &1)
+ :telemetry.detach(handler_id)
+
+ # The novel group is created on the first row and reused in memory for the
+ # remaining nine. Without accumulation each row triggers a fresh full-table
+ # read, scaling linearly with the row count.
+ assert reads <= 3,
+ "Expected the group table read at most a few times, got #{reads} reads for 10 rows (N+1)."
+ end
+
+ test "empty groups cell leaves the member without group assignment", %{actor: actor} do
+ chunk = [{2, %{member: %{email: "g-empty@example.com"}, custom: %{}, groups: " "}}]
+ opts = [actor: actor, groups_found: []]
+
+ assert {:ok, result} = MemberCSV.process_chunk(chunk, %{email: 0}, %{}, opts)
+ assert result.inserted == 1
+ assert result.errors == []
+
+ assert group_names_for("g-empty@example.com", actor) == []
+ end
+
+ property "re-importing the same groups does not create duplicates", %{actor: actor} do
+ check all(
+ name <- StreamData.string(:alphanumeric, min_length: 1, max_length: 15),
+ max_runs: 15
+ ) do
+ group_name = "dup-" <> name
+ email1 = "dup-#{System.unique_integer([:positive])}@example.com"
+ email2 = "dup-#{System.unique_integer([:positive])}@example.com"
+ opts = [actor: actor, groups_found: []]
+
+ chunk1 = [{2, %{member: %{email: email1}, custom: %{}, groups: group_name}}]
+ chunk2 = [{2, %{member: %{email: email2}, custom: %{}, groups: group_name}}]
+
+ assert {:ok, %{inserted: 1}} = MemberCSV.process_chunk(chunk1, %{email: 0}, %{}, opts)
+ assert {:ok, %{inserted: 1}} = MemberCSV.process_chunk(chunk2, %{email: 0}, %{}, opts)
+
+ matching =
+ Mv.Membership.list_groups!(actor: actor)
+ |> Enum.filter(&(String.downcase(&1.name) == String.downcase(group_name)))
+
+ assert length(matching) == 1
+ end
+ end
+ end
end
From a93dd9d5350be73960eeeb8be593c8dbb26512d4 Mon Sep 17 00:00:00 2001
From: Moritz
Date: Wed, 3 Jun 2026 02:21:36 +0200
Subject: [PATCH 08/23] feat(import): serve dynamic CSV import templates
reflecting current custom fields
---
.../controllers/import_template_controller.ex | 120 ++++++++++++++++++
lib/mv_web/live/import_live/components.ex | 12 +-
lib/mv_web/router.ex | 4 +
.../import_template_controller_test.exs | 104 +++++++++++++++
test/mv_web/live/import_live_test.exs | 11 +-
5 files changed, 238 insertions(+), 13 deletions(-)
create mode 100644 lib/mv_web/controllers/import_template_controller.ex
create mode 100644 test/mv_web/controllers/import_template_controller_test.exs
diff --git a/lib/mv_web/controllers/import_template_controller.ex b/lib/mv_web/controllers/import_template_controller.ex
new file mode 100644
index 0000000..f040c7a
--- /dev/null
+++ b/lib/mv_web/controllers/import_template_controller.ex
@@ -0,0 +1,120 @@
+defmodule MvWeb.ImportTemplateController do
+ @moduledoc """
+ Serves CSV import templates generated on the fly from the current custom fields.
+
+ Two actions provide an English (`en/2`) and a German (`de/2`) template. Each
+ template has a single header row listing the standard member columns followed
+ by every existing custom field name (exact match, as the import expects), plus
+ the importable groups and fee-type columns. A single placeholder example row is
+ included to illustrate the format.
+
+ Both actions require the same authorization as the import page
+ (`can?(:create, Member)`); unauthorized requests are rejected.
+ """
+ use MvWeb, :controller
+
+ alias Mv.Authorization.Actor
+ alias Mv.Membership.Member
+ alias Mv.Membership.MembersCSV
+ alias MvWeb.Authorization
+
+ # Standard member columns in template order, with their English and German headers
+ # and a placeholder example value. Groups and fee type are importable extras.
+ @columns [
+ {"first name", "Vorname", "John", "Max"},
+ {"last name", "Nachname", "Doe", "Mustermann"},
+ {"email", "E-Mail", "john.doe@example.com", "max.mustermann@example.com"},
+ {"country", "Land", "Germany", "Deutschland"},
+ {"city", "Stadt", "Berlin", "Berlin"},
+ {"street", "Straße", "Main Street", "Hauptstraße"},
+ {"house number", "Hausnummer", "1a", "12"},
+ {"postal_code", "PLZ", "12345", "10115"},
+ {"join_date", "Beitrittsdatum", "2020-01-15", "2020-01-15"},
+ {"exit_date", "Austrittsdatum", "", ""},
+ {"notes", "Notizen", "", ""},
+ {"membership_fee_start_date", "Beitragsbeginn", "", ""},
+ {"Groups", "Gruppen", "", ""},
+ {"Fee Type", "Beitragsart", "", ""}
+ ]
+
+ @spec en(Plug.Conn.t(), map()) :: Plug.Conn.t()
+ def en(conn, _params) do
+ serve_template(conn, :en, "member_import_en.csv")
+ end
+
+ @spec de(Plug.Conn.t(), map()) :: Plug.Conn.t()
+ def de(conn, _params) do
+ serve_template(conn, :de, "member_import_de.csv")
+ end
+
+ defp serve_template(conn, locale, filename) do
+ actor = current_actor(conn)
+
+ if Authorization.can?(actor, :create, Member) do
+ csv = build_csv(locale, actor)
+
+ send_download(conn, {:binary, csv},
+ filename: filename,
+ content_type: "text/csv; charset=utf-8"
+ )
+ else
+ return_forbidden(conn)
+ end
+ end
+
+ defp build_csv(locale, actor) do
+ custom_field_names = custom_field_names(actor)
+
+ header =
+ Enum.map(@columns, &header_for(&1, locale)) ++ custom_field_names
+
+ example =
+ Enum.map(@columns, &example_for(&1, locale)) ++ Enum.map(custom_field_names, fn _ -> "" end)
+
+ [csv_row(header), csv_row(example)]
+ |> Enum.join("\n")
+ end
+
+ defp header_for({en, _de, _ex_en, _ex_de}, :en), do: en
+ defp header_for({_en, de, _ex_en, _ex_de}, :de), do: de
+
+ defp example_for({_en, _de, ex_en, _ex_de}, :en), do: ex_en
+ defp example_for({_en, _de, _ex_en, ex_de}, :de), do: ex_de
+
+ defp custom_field_names(actor) do
+ Mv.Membership.list_custom_fields!(actor: actor)
+ |> Enum.map(& &1.name)
+ end
+
+ # Serializes a row using the semicolon delimiter (the import auto-detects it),
+ # quoting any field that contains a delimiter, quote, or newline.
+ defp csv_row(fields) do
+ Enum.map_join(fields, ";", &escape_field/1)
+ end
+
+ # Neutralizes spreadsheet formula triggers (the same guard the export writer
+ # applies) before RFC 4180 quoting, so a custom-field name like
+ # `=HYPERLINK(...)` is not evaluated when the template is opened.
+ defp escape_field(field) do
+ field = field |> to_string() |> MembersCSV.safe_cell()
+
+ if String.contains?(field, [";", "\"", "\n", "\r"]) do
+ "\"" <> String.replace(field, "\"", "\"\"") <> "\""
+ else
+ field
+ end
+ end
+
+ defp current_actor(conn) do
+ conn.assigns[:current_user]
+ |> Actor.ensure_loaded()
+ end
+
+ defp return_forbidden(conn) do
+ conn
+ |> put_status(403)
+ |> put_resp_content_type("application/json")
+ |> json(%{error: "Forbidden"})
+ |> halt()
+ end
+end
diff --git a/lib/mv_web/live/import_live/components.ex b/lib/mv_web/live/import_live/components.ex
index 3bf10cb..eacc263 100644
--- a/lib/mv_web/live/import_live/components.ex
+++ b/lib/mv_web/live/import_live/components.ex
@@ -44,20 +44,12 @@ defmodule MvWeb.ImportLive.Components do
-
- <.link
- href={~p"/templates/member_import_en.csv"}
- download="member_import_en.csv"
- class="link link-primary"
- >
+ <.link href={~p"/admin/import/template/en"} class="link link-primary">
{gettext("English Template")}
-
- <.link
- href={~p"/templates/member_import_de.csv"}
- download="member_import_de.csv"
- class="link link-primary"
- >
+ <.link href={~p"/admin/import/template/de"} class="link link-primary">
{gettext("German Template")}
diff --git a/lib/mv_web/router.ex b/lib/mv_web/router.ex
index 64036c9..bc2ab30 100644
--- a/lib/mv_web/router.ex
+++ b/lib/mv_web/router.ex
@@ -102,6 +102,10 @@ defmodule MvWeb.Router do
# Import (Admin only)
live "/admin/import", ImportLive
+ # Dynamic CSV import templates (admin only; generated from current custom fields)
+ get "/admin/import/template/en", ImportTemplateController, :en
+ get "/admin/import/template/de", ImportTemplateController, :de
+
post "/members/export.csv", MemberExportController, :export
post "/members/export.pdf", MemberPdfExportController, :export
post "/set_locale", LocaleController, :set_locale
diff --git a/test/mv_web/controllers/import_template_controller_test.exs b/test/mv_web/controllers/import_template_controller_test.exs
new file mode 100644
index 0000000..5799938
--- /dev/null
+++ b/test/mv_web/controllers/import_template_controller_test.exs
@@ -0,0 +1,104 @@
+defmodule MvWeb.ImportTemplateControllerTest do
+ use MvWeb.ConnCase, async: true
+
+ setup %{conn: conn} do
+ actor = Mv.Helpers.SystemActor.get_system_actor()
+
+ {:ok, custom_field} =
+ Mv.Membership.CustomField
+ |> Ash.Changeset.for_create(:create, %{name: "Lieblingsfarbe", value_type: :string})
+ |> Ash.create(actor: actor)
+
+ %{conn: conn, custom_field: custom_field}
+ end
+
+ describe "authenticated EN template" do
+ setup %{conn: conn} do
+ admin = Mv.Fixtures.user_with_role_fixture("admin")
+ %{conn: MvWeb.ConnCase.conn_with_password_user(conn, admin)}
+ end
+
+ test "returns CSV with English headers and current custom fields", %{conn: conn} do
+ conn = get(conn, ~p"/admin/import/template/en")
+
+ assert response_content_type(conn, :csv) =~ "text/csv"
+ body = response(conn, 200)
+
+ header = body |> String.split("\n") |> List.first()
+ assert header =~ "email"
+ # EN headers use the canonical English variant from HeaderMapper, not the
+ # underscore form, so the template stays faithful to the documented variant list.
+ assert header =~ "first name"
+ assert header =~ "last name"
+ refute header =~ "first_name"
+ assert header =~ "house number"
+ refute header =~ "house_number"
+ assert header =~ "Lieblingsfarbe"
+
+ assert get_resp_header(conn, "content-disposition")
+ |> Enum.any?(&(&1 =~ "member_import_en.csv"))
+ end
+
+ test "neutralizes formula-injection in a custom field header", %{conn: conn} do
+ actor = Mv.Helpers.SystemActor.get_system_actor()
+
+ {:ok, _} =
+ Mv.Membership.CustomField
+ |> Ash.Changeset.for_create(:create, %{
+ name: "=cmd|'/c calc'!A1",
+ value_type: :string
+ })
+ |> Ash.create(actor: actor)
+
+ conn = get(conn, ~p"/admin/import/template/en")
+ body = response(conn, 200)
+ header = body |> String.split("\n") |> List.first()
+
+ # The dangerous cell must be prefixed with a single quote so spreadsheet
+ # software does not evaluate it as a formula, matching the export writer.
+ refute header =~ ~r/(^|;)=cmd/
+ assert header =~ "'=cmd|'/c calc'!A1"
+ end
+ end
+
+ describe "authenticated DE template" do
+ setup %{conn: conn} do
+ admin = Mv.Fixtures.user_with_role_fixture("admin")
+ %{conn: MvWeb.ConnCase.conn_with_password_user(conn, admin)}
+ end
+
+ test "returns CSV with German headers and current custom fields", %{conn: conn} do
+ conn = get(conn, ~p"/admin/import/template/de")
+
+ body = response(conn, 200)
+ header = body |> String.split("\n") |> List.first()
+
+ assert header =~ "E-Mail"
+ assert header =~ "Vorname"
+ assert header =~ "Lieblingsfarbe"
+
+ assert get_resp_header(conn, "content-disposition")
+ |> Enum.any?(&(&1 =~ "member_import_de.csv"))
+ end
+ end
+
+ describe "authorization" do
+ @tag role: :unauthenticated
+ test "unauthenticated request does not receive a CSV", %{conn: conn} do
+ conn = get(conn, ~p"/admin/import/template/en")
+
+ refute conn.status == 200
+ refute get_resp_header(conn, "content-type") |> Enum.any?(&(&1 =~ "text/csv"))
+ refute to_string(conn.resp_body) =~ "email"
+ end
+
+ @tag role: :member
+ test "user without import permission is forbidden", %{conn: conn} do
+ conn = get(conn, ~p"/admin/import/template/en")
+
+ refute conn.status == 200
+ refute get_resp_header(conn, "content-type") |> Enum.any?(&(&1 =~ "text/csv"))
+ refute to_string(conn.resp_body) =~ "email"
+ end
+ end
+end
diff --git a/test/mv_web/live/import_live_test.exs b/test/mv_web/live/import_live_test.exs
index 09ec02c..7b4dd40 100644
--- a/test/mv_web/live/import_live_test.exs
+++ b/test/mv_web/live/import_live_test.exs
@@ -240,10 +240,15 @@ defmodule MvWeb.ImportLiveTest do
assert has_element?(view, "[data-testid='start-import-button']")
end
- test "template links and file input are present", %{conn: conn} do
+ test "template links point to the dynamic import template routes", %{conn: conn} do
+ {:ok, view, _html} = live(conn, ~p"/admin/import")
+ assert has_element?(view, "a[href='/admin/import/template/en']")
+ assert has_element?(view, "a[href='/admin/import/template/de']")
+ refute has_element?(view, "a[href*='/templates/member_import_en.csv']")
+ end
+
+ test "file input is present", %{conn: conn} do
{:ok, view, _html} = live(conn, ~p"/admin/import")
- assert has_element?(view, "a[href*='/templates/member_import_en.csv']")
- assert has_element?(view, "a[href*='/templates/member_import_de.csv']")
assert has_element?(view, "label[for='csv_file']")
assert has_element?(view, "#csv_file_help")
assert has_element?(view, "[data-testid='csv-upload-form'] input[type='file']")
From 68a1a9530adc4c0afa573d65cac4b8ab65dab8d0 Mon Sep 17 00:00:00 2001
From: Moritz
Date: Wed, 3 Jun 2026 02:25:50 +0200
Subject: [PATCH 09/23] feat(import): confirm column mapping in a preview
before importing members
---
lib/mv/membership/import/header_mapper.ex | 4 +-
lib/mv_web/live/import_live.ex | 55 ++++-
lib/mv_web/live/import_live/components.ex | 209 +++++++++++++++-
priv/gettext/de/LC_MESSAGES/default.po | 109 ++++++++-
priv/gettext/default.pot | 109 ++++++++-
priv/gettext/en/LC_MESSAGES/default.po | 109 ++++++++-
.../live/import_live/components_test.exs | 31 +++
test/mv_web/live/import_live_test.exs | 228 ++++++++++++++++--
8 files changed, 816 insertions(+), 38 deletions(-)
create mode 100644 test/mv_web/live/import_live/components_test.exs
diff --git a/lib/mv/membership/import/header_mapper.ex b/lib/mv/membership/import/header_mapper.ex
index eb8bb04..be90ca6 100644
--- a/lib/mv/membership/import/header_mapper.ex
+++ b/lib/mv/membership/import/header_mapper.ex
@@ -75,7 +75,9 @@ defmodule Mv.Membership.Import.HeaderMapper do
@ignored_normalized [
"membershipfeestatus",
"mitgliedsbeitragsstatus",
- "bezahlstatus"
+ "bezahlstatus",
+ # DE export label for membership_fee_start_date — system-managed, not importable
+ "startdatummitgliedsbeitrag"
]
# Normalized header variants for the groups column. The column is resolved to
diff --git a/lib/mv_web/live/import_live.ex b/lib/mv_web/live/import_live.ex
index a8c5a95..2c5aa8a 100644
--- a/lib/mv_web/live/import_live.ex
+++ b/lib/mv_web/live/import_live.ex
@@ -99,7 +99,12 @@ defmodule MvWeb.ImportLive do
<.form_section title={gettext("Choose CSV file")}>
-
+ <%= if @import_status != :preview do %>
+
+ <% end %>
+ <%= if @import_status == :preview do %>
+
+ <% end %>
<%= if @import_status == :running or @import_status == :done or @import_status == :error do %>
<% end %>
@@ -133,6 +138,29 @@ defmodule MvWeb.ImportLive do
end
end
+ @impl true
+ def handle_event("confirm_import", _params, socket) do
+ case socket.assigns do
+ %{import_state: import_state} when is_map(import_state) ->
+ start_import(socket, import_state)
+
+ _ ->
+ {:noreply,
+ put_flash(socket, :error, gettext("No prepared import to confirm. Please upload again."))}
+ end
+ end
+
+ @impl true
+ def handle_event("cancel_import", _params, socket) do
+ socket =
+ socket
+ |> assign(:import_state, nil)
+ |> assign(:import_progress, nil)
+ |> assign(:import_status, :idle)
+
+ {:noreply, socket}
+ end
+
# Checks if all prerequisites for starting an import are met.
#
# Validates:
@@ -169,10 +197,10 @@ defmodule MvWeb.ImportLive do
end
end
- # Processes CSV upload and starts import process.
+ # Processes CSV upload and enters the mapping preview.
#
- # Reads the uploaded CSV file, prepares it for import, and initiates
- # the chunked processing workflow.
+ # Reads the uploaded CSV file and prepares it (read-only at the DB level), then
+ # shows the mapping preview. No member is created until the user confirms.
@spec process_csv_upload(Phoenix.LiveView.Socket.t()) ::
{:noreply, Phoenix.LiveView.Socket.t()}
defp process_csv_upload(socket) do
@@ -181,7 +209,7 @@ defmodule MvWeb.ImportLive do
with {:ok, content} <- consume_and_read_csv(socket),
{:ok, import_state} <-
MemberCSV.prepare(content, max_rows: Config.csv_import_max_rows(), actor: actor) do
- start_import(socket, import_state)
+ enter_preview(socket, import_state)
else
{:error, reason} when is_binary(reason) ->
{:noreply,
@@ -193,6 +221,19 @@ defmodule MvWeb.ImportLive do
end
end
+ # Shows the mapping preview without starting any processing.
+ @spec enter_preview(Phoenix.LiveView.Socket.t(), map()) ::
+ {:noreply, Phoenix.LiveView.Socket.t()}
+ defp enter_preview(socket, import_state) do
+ socket =
+ socket
+ |> assign(:import_state, import_state)
+ |> assign(:import_progress, nil)
+ |> assign(:import_status, :preview)
+
+ {:noreply, socket}
+ end
+
# Starts the import process by initializing progress tracking and scheduling the first chunk.
@spec start_import(Phoenix.LiveView.Socket.t(), map()) ::
{:noreply, Phoenix.LiveView.Socket.t()}
@@ -263,7 +304,9 @@ defmodule MvWeb.ImportLive do
custom_field_lookup: import_state.custom_field_lookup,
existing_error_count: length(progress.errors),
max_errors: @max_errors,
- actor: actor
+ actor: actor,
+ fee_type_map: import_state.fee_type_map,
+ groups_found: import_state.groups_found
]
_ =
diff --git a/lib/mv_web/live/import_live/components.ex b/lib/mv_web/live/import_live/components.ex
index eacc263..c317b87 100644
--- a/lib/mv_web/live/import_live/components.ex
+++ b/lib/mv_web/live/import_live/components.ex
@@ -25,7 +25,22 @@ defmodule MvWeb.ImportLive.Components do
{gettext(
- "Use the data field name as the CSV column header in your file. Data fields must exist in Mila before importing, because unknown data field columns will be ignored. Groups and membership fees are not supported for import."
+ "Use the data field name as the CSV column header in your file. Data fields must exist in Mila before importing, because unknown data field columns will be ignored."
+ )}
+
+
+ {gettext(
+ "Groups column (recognized headers): Groups, Gruppen, Gruppe. Comma-separated group names are supported and missing groups are created automatically."
+ )}
+
+
+ {gettext(
+ "Fee type column (recognized headers): Fee Type, fee type, fee_type, membership_fee_type, Beitragsart. Unknown fee types fall back to the default."
+ )}
+
+
+ {gettext(
+ "Fee status columns (Membership Fee Status, Bezahlstatus, Mitgliedsbeitragsstatus) are always ignored and cannot be imported."
)}
@@ -100,6 +115,194 @@ defmodule MvWeb.ImportLive.Components do
"""
end
+ @doc """
+ Renders the mapping preview shown between upload and processing.
+
+ Shows the column-to-role mapping, up to 3 sample rows, and notices for
+ auto-created groups, unresolved fee types, empty fee-type cells, and unknown
+ columns. Nothing is written until the user confirms.
+ """
+ def preview(assigns) do
+ state = assigns.import_state
+ column_roles = column_roles(state)
+ column_samples = column_samples(state.preview_rows, length(state.headers))
+
+ assigns =
+ assigns
+ |> assign(:column_roles, column_roles)
+ |> assign(:column_samples, column_samples)
+
+ ~H"""
+
+
+ {gettext("Preview import")}
+
+
+
+
+
+
+ | {gettext("Role")} |
+ {gettext("Column")} |
+ {gettext("Row 1")} |
+ {gettext("Row 2")} |
+ {gettext("Row 3")} |
+
+
+
+ <%= for {{header, role}, samples} <- Enum.zip(@column_roles, @column_samples) do %>
+
+ |
+
+ {role_label(role)}
+
+ |
+ {header} |
+ <%= for sample <- samples do %>
+ {sample} |
+ <% end %>
+
+ <% end %>
+
+
+
+
+ <%= if @import_state.groups_to_create != [] do %>
+
+ <.icon name="hero-information-circle" class="size-5" aria-hidden="true" />
+
+
+ {gettext("These groups will be created automatically: %{names}",
+ names: Enum.join(@import_state.groups_to_create, ", ")
+ )}
+
+
+
+ <% end %>
+
+ <%= if @import_state.fee_type_warnings != [] do %>
+
+ <.icon name="hero-exclamation-circle" class="size-5" aria-hidden="true" />
+
+
+ {gettext("Unknown fee types (members get the default): %{names}",
+ names: Enum.join(@import_state.fee_type_warnings, ", ")
+ )}
+
+ <.link
+ navigate={~p"/membership_fee_settings/new_fee_type"}
+ class="link link-primary text-sm"
+ >
+ {gettext("Create fee type")}
+
+
+
+ <% end %>
+
+ <%= if @import_state.has_empty_fee_type_cells? do %>
+
+ <.icon name="hero-information-circle" class="size-5" aria-hidden="true" />
+
+
+ {gettext("Rows with an empty fee type will get the default fee type.")}
+
+
+
+ <% end %>
+
+ <%= if @import_state.warnings != [] do %>
+
+ <.icon name="hero-information-circle" class="size-5" aria-hidden="true" />
+
+
+ <%= for warning <- @import_state.warnings do %>
+ - {warning}
+ <% end %>
+
+ <.link navigate={~p"/admin/datafields"} class="link link-primary text-sm">
+ {gettext("Create custom field")}
+
+
+
+ <% end %>
+
+
+ <.button
+ type="button"
+ phx-click="confirm_import"
+ variant="primary"
+ data-testid="confirm-import-button"
+ >
+ {gettext("Confirm and Import")}
+
+ <.button type="button" phx-click="cancel_import" data-testid="cancel-import-button">
+ {gettext("Cancel")}
+
+
+
+ """
+ end
+
+ # Pairs each CSV header with its resolved role for the preview mapping table.
+ defp column_roles(state) do
+ member_indices = MapSet.new(Map.values(state.column_map))
+ custom_indices = MapSet.new(Map.values(state.custom_field_map))
+ ignored_headers = MapSet.new(state.ignored)
+
+ state.headers
+ |> Enum.with_index()
+ |> Enum.map(fn {header, index} ->
+ {header, role_for(index, header, state, member_indices, custom_indices, ignored_headers)}
+ end)
+ end
+
+ defp role_for(index, header, state, member_indices, custom_indices, ignored_headers) do
+ cond do
+ index == state.groups_column_index -> :groups
+ index == state.fee_type_column_index -> :fee_type
+ MapSet.member?(ignored_headers, header) -> :ignored
+ MapSet.member?(member_indices, index) -> :member_field
+ MapSet.member?(custom_indices, index) -> :custom_field
+ true -> :unknown
+ end
+ end
+
+ defp role_label(:member_field), do: gettext("Member field")
+ defp role_label(:custom_field), do: gettext("Custom field")
+ defp role_label(:groups), do: gettext("Groups")
+ defp role_label(:fee_type), do: gettext("Fee type")
+ defp role_label(:ignored), do: gettext("Ignored (system-computed field)")
+ defp role_label(:unknown), do: gettext("Unknown (ignored)")
+
+ defp role_badge_class(:member_field), do: "badge-primary"
+ defp role_badge_class(:custom_field), do: "badge-secondary"
+ defp role_badge_class(:groups), do: "badge-success"
+ defp role_badge_class(:fee_type), do: "badge-warning"
+ defp role_badge_class(:ignored), do: "badge-ghost"
+ defp role_badge_class(:unknown), do: "badge-error"
+
+ defp role_row_class(:ignored), do: "opacity-50"
+ defp role_row_class(:unknown), do: "opacity-50"
+ defp role_row_class(_), do: nil
+
+ defp column_samples([], col_count), do: List.duplicate([], col_count)
+
+ defp column_samples(rows, col_count) do
+ Enum.map(0..(col_count - 1), fn col_idx ->
+ rows
+ |> Enum.map(fn row -> Enum.at(row, col_idx, "") end)
+ |> pad_to(3, "")
+ end)
+ end
+
+ defp pad_to(list, target, fill) do
+ list ++ List.duplicate(fill, max(0, target - length(list)))
+ end
+
@doc """
Renders import progress text and, when done or aborted, the import results section.
"""
@@ -246,8 +449,10 @@ defmodule MvWeb.ImportLive.Components do
@doc """
Returns whether the Start Import button should be disabled.
"""
- @spec import_button_disabled?(:idle | :running | :done | :error, [map()]) :: boolean()
+ @spec import_button_disabled?(:idle | :preview | :running | :done | :error, [map()]) ::
+ boolean()
def import_button_disabled?(:running, _entries), do: true
+ def import_button_disabled?(:preview, _entries), do: true
def import_button_disabled?(_status, []), do: true
def import_button_disabled?(_status, [entry | _]) when not entry.done?, do: true
def import_button_disabled?(_status, _entries), do: false
diff --git a/priv/gettext/de/LC_MESSAGES/default.po b/priv/gettext/de/LC_MESSAGES/default.po
index 9fa6cd4..343ede8 100644
--- a/priv/gettext/de/LC_MESSAGES/default.po
+++ b/priv/gettext/de/LC_MESSAGES/default.po
@@ -390,6 +390,7 @@ msgstr "Kann jederzeit geändert werden. Änderungen des Betrags betreffen nur z
#: lib/mv_web/live/custom_field_live/form_component.ex
#: lib/mv_web/live/custom_field_live/index_component.ex
#: lib/mv_web/live/group_live/show.ex
+#: lib/mv_web/live/import_live/components.ex
#: lib/mv_web/live/member_field_live/form_component.ex
#: lib/mv_web/live/member_live/form.ex
#: lib/mv_web/live/member_live/show.ex
@@ -1329,6 +1330,7 @@ msgstr "Feb."
msgid "Fee Type"
msgstr "Beitragsart"
+#: lib/mv_web/live/import_live/components.ex
#: lib/mv_web/live/statistics_live.ex
#, elixir-autogen, elixir-format
msgid "Fee type"
@@ -1488,6 +1490,7 @@ msgstr "Gruppe erfolgreich gespeichert."
#: lib/mv_web/components/layouts/sidebar.ex
#: lib/mv_web/live/components/member_filter_component.ex
#: lib/mv_web/live/group_live/index.ex
+#: lib/mv_web/live/import_live/components.ex
#: lib/mv_web/live/member_live/index.html.heex
#: lib/mv_web/live/member_live/show.ex
#: lib/mv_web/translations/member_fields.ex
@@ -2643,6 +2646,7 @@ msgstr "Geprüft von"
msgid "Reviewed at"
msgstr "Geprüft am"
+#: lib/mv_web/live/import_live/components.ex
#: lib/mv_web/live/role_live/form.ex
#: lib/mv_web/live/user_live/form.ex
#: lib/mv_web/live/user_live/index.html.heex
@@ -3303,11 +3307,6 @@ msgstr "Aufhebung der Verknüpfung geplant"
msgid "Unpaid"
msgstr "Unbezahlt"
-#: lib/mv_web/live/import_live/components.ex
-#, elixir-autogen, elixir-format, fuzzy
-msgid "Use the data field name as the CSV column header in your file. Data fields must exist in Mila before importing, because unknown data field columns will be ignored. Groups and membership fees are not supported for import."
-msgstr "Verwende die Namen der Datenfelder als Spaltennamen in der CSV-Datei. Datenfelder müssen in Mila bereits angelegt sein, da unbekannte Spaltennamen ignoriert werden. Gruppen und Beitragsstatus können nicht importiert werden."
-
#: lib/mv_web/live/user_live/form.ex
#, elixir-autogen, elixir-format
msgid "User"
@@ -3977,3 +3976,103 @@ msgstr "Beitragsart '%{name}' nicht gefunden; Standard-Beitragsart wird verwende
#, elixir-autogen, elixir-format
msgid "Group assignment failed: %{reason}"
msgstr "Gruppenzuordnung fehlgeschlagen: %{reason}"
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Confirm and Import"
+msgstr "Bestätigen und importieren"
+
+#: lib/mv_web/live/import_live.ex
+#, elixir-autogen, elixir-format
+msgid "No prepared import to confirm. Please upload again."
+msgstr "Kein vorbereiteter Import zum Bestätigen. Bitte erneut hochladen."
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Preview import"
+msgstr "Importvorschau"
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Column"
+msgstr "Spalte"
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Custom field"
+msgstr "Benutzerdefiniertes Feld"
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Ignored (system-computed field)"
+msgstr "Ignoriert (vom System berechnetes Feld)"
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Member field"
+msgstr "Mitgliedsfeld"
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Rows with an empty fee type will get the default fee type."
+msgstr "Zeilen ohne Beitragsart erhalten die Standard-Beitragsart."
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "These groups will be created automatically: %{names}"
+msgstr "Diese Gruppen werden automatisch erstellt: %{names}"
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Unknown (ignored)"
+msgstr "Unbekannt (ignoriert)"
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Unknown fee types (members get the default): %{names}"
+msgstr "Unbekannte Beitragsarten (Mitglieder erhalten den Standard): %{names}"
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Fee status columns (Membership Fee Status, Bezahlstatus, Mitgliedsbeitragsstatus) are always ignored and cannot be imported."
+msgstr "Beitragsstatus-Spalten (Membership Fee Status, Bezahlstatus, Mitgliedsbeitragsstatus) werden immer ignoriert und können nicht importiert werden."
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Groups column (recognized headers): Groups, Gruppen, Gruppe. Comma-separated group names are supported and missing groups are created automatically."
+msgstr "Gruppen-Spalte (erkannte Spaltennamen): Groups, Gruppen, Gruppe. Mehrere durch Komma getrennte Gruppennamen werden unterstützt; fehlende Gruppen werden automatisch erstellt."
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Use the data field name as the CSV column header in your file. Data fields must exist in Mila before importing, because unknown data field columns will be ignored."
+msgstr "Verwende die Namen der Datenfelder als Spaltennamen in der CSV-Datei. Datenfelder müssen in Mila bereits angelegt sein, da unbekannte Spaltennamen ignoriert werden."
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Fee type column (recognized headers): Fee Type, fee type, fee_type, membership_fee_type, Beitragsart. Unknown fee types fall back to the default."
+msgstr "Beitragsart-Spalte (erkannte Spaltennamen): Fee Type, fee type, fee_type, membership_fee_type, Beitragsart. Unbekannte Beitragsarten erhalten die Standard-Beitragsart."
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Create custom field"
+msgstr "Datenfeld erstellen"
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Create fee type"
+msgstr "Beitragsart erstellen"
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Row 1"
+msgstr "Zeile 1"
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Row 2"
+msgstr "Zeile 2"
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Row 3"
+msgstr "Zeile 3"
diff --git a/priv/gettext/default.pot b/priv/gettext/default.pot
index c961420..f14f7a1 100644
--- a/priv/gettext/default.pot
+++ b/priv/gettext/default.pot
@@ -391,6 +391,7 @@ msgstr ""
#: lib/mv_web/live/custom_field_live/form_component.ex
#: lib/mv_web/live/custom_field_live/index_component.ex
#: lib/mv_web/live/group_live/show.ex
+#: lib/mv_web/live/import_live/components.ex
#: lib/mv_web/live/member_field_live/form_component.ex
#: lib/mv_web/live/member_live/form.ex
#: lib/mv_web/live/member_live/show.ex
@@ -1330,6 +1331,7 @@ msgstr ""
msgid "Fee Type"
msgstr ""
+#: lib/mv_web/live/import_live/components.ex
#: lib/mv_web/live/statistics_live.ex
#, elixir-autogen, elixir-format
msgid "Fee type"
@@ -1489,6 +1491,7 @@ msgstr ""
#: lib/mv_web/components/layouts/sidebar.ex
#: lib/mv_web/live/components/member_filter_component.ex
#: lib/mv_web/live/group_live/index.ex
+#: lib/mv_web/live/import_live/components.ex
#: lib/mv_web/live/member_live/index.html.heex
#: lib/mv_web/live/member_live/show.ex
#: lib/mv_web/translations/member_fields.ex
@@ -2644,6 +2647,7 @@ msgstr ""
msgid "Reviewed at"
msgstr ""
+#: lib/mv_web/live/import_live/components.ex
#: lib/mv_web/live/role_live/form.ex
#: lib/mv_web/live/user_live/form.ex
#: lib/mv_web/live/user_live/index.html.heex
@@ -3304,11 +3308,6 @@ msgstr ""
msgid "Unpaid"
msgstr ""
-#: lib/mv_web/live/import_live/components.ex
-#, elixir-autogen, elixir-format
-msgid "Use the data field name as the CSV column header in your file. Data fields must exist in Mila before importing, because unknown data field columns will be ignored. Groups and membership fees are not supported for import."
-msgstr ""
-
#: lib/mv_web/live/user_live/form.ex
#, elixir-autogen, elixir-format
msgid "User"
@@ -3977,3 +3976,103 @@ msgstr ""
#, elixir-autogen, elixir-format
msgid "Group assignment failed: %{reason}"
msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Confirm and Import"
+msgstr ""
+
+#: lib/mv_web/live/import_live.ex
+#, elixir-autogen, elixir-format
+msgid "No prepared import to confirm. Please upload again."
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Preview import"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Column"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Custom field"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Ignored (system-computed field)"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Member field"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Rows with an empty fee type will get the default fee type."
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "These groups will be created automatically: %{names}"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Unknown (ignored)"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Unknown fee types (members get the default): %{names}"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Fee status columns (Membership Fee Status, Bezahlstatus, Mitgliedsbeitragsstatus) are always ignored and cannot be imported."
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Groups column (recognized headers): Groups, Gruppen, Gruppe. Comma-separated group names are supported and missing groups are created automatically."
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Use the data field name as the CSV column header in your file. Data fields must exist in Mila before importing, because unknown data field columns will be ignored."
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Fee type column (recognized headers): Fee Type, fee type, fee_type, membership_fee_type, Beitragsart. Unknown fee types fall back to the default."
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Create custom field"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Create fee type"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Row 1"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Row 2"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Row 3"
+msgstr ""
diff --git a/priv/gettext/en/LC_MESSAGES/default.po b/priv/gettext/en/LC_MESSAGES/default.po
index 58aeead..18d1e30 100644
--- a/priv/gettext/en/LC_MESSAGES/default.po
+++ b/priv/gettext/en/LC_MESSAGES/default.po
@@ -391,6 +391,7 @@ msgstr ""
#: lib/mv_web/live/custom_field_live/form_component.ex
#: lib/mv_web/live/custom_field_live/index_component.ex
#: lib/mv_web/live/group_live/show.ex
+#: lib/mv_web/live/import_live/components.ex
#: lib/mv_web/live/member_field_live/form_component.ex
#: lib/mv_web/live/member_live/form.ex
#: lib/mv_web/live/member_live/show.ex
@@ -1330,6 +1331,7 @@ msgstr ""
msgid "Fee Type"
msgstr "Fee Type"
+#: lib/mv_web/live/import_live/components.ex
#: lib/mv_web/live/statistics_live.ex
#, elixir-autogen, elixir-format, fuzzy
msgid "Fee type"
@@ -1489,6 +1491,7 @@ msgstr ""
#: lib/mv_web/components/layouts/sidebar.ex
#: lib/mv_web/live/components/member_filter_component.ex
#: lib/mv_web/live/group_live/index.ex
+#: lib/mv_web/live/import_live/components.ex
#: lib/mv_web/live/member_live/index.html.heex
#: lib/mv_web/live/member_live/show.ex
#: lib/mv_web/translations/member_fields.ex
@@ -2644,6 +2647,7 @@ msgstr "Review by"
msgid "Reviewed at"
msgstr "Review date"
+#: lib/mv_web/live/import_live/components.ex
#: lib/mv_web/live/role_live/form.ex
#: lib/mv_web/live/user_live/form.ex
#: lib/mv_web/live/user_live/index.html.heex
@@ -3304,11 +3308,6 @@ msgstr ""
msgid "Unpaid"
msgstr ""
-#: lib/mv_web/live/import_live/components.ex
-#, elixir-autogen, elixir-format, fuzzy
-msgid "Use the data field name as the CSV column header in your file. Data fields must exist in Mila before importing, because unknown data field columns will be ignored. Groups and membership fees are not supported for import."
-msgstr ""
-
#: lib/mv_web/live/user_live/form.ex
#, elixir-autogen, elixir-format
msgid "User"
@@ -3977,3 +3976,103 @@ msgstr ""
#, elixir-autogen, elixir-format
msgid "Group assignment failed: %{reason}"
msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Confirm and Import"
+msgstr ""
+
+#: lib/mv_web/live/import_live.ex
+#, elixir-autogen, elixir-format
+msgid "No prepared import to confirm. Please upload again."
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Preview import"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Column"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format, fuzzy
+msgid "Custom field"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Ignored (system-computed field)"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format, fuzzy
+msgid "Member field"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Rows with an empty fee type will get the default fee type."
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "These groups will be created automatically: %{names}"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format, fuzzy
+msgid "Unknown (ignored)"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Unknown fee types (members get the default): %{names}"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Fee status columns (Membership Fee Status, Bezahlstatus, Mitgliedsbeitragsstatus) are always ignored and cannot be imported."
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Groups column (recognized headers): Groups, Gruppen, Gruppe. Comma-separated group names are supported and missing groups are created automatically."
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format, fuzzy
+msgid "Use the data field name as the CSV column header in your file. Data fields must exist in Mila before importing, because unknown data field columns will be ignored."
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format, fuzzy
+msgid "Fee type column (recognized headers): Fee Type, fee type, fee_type, membership_fee_type, Beitragsart. Unknown fee types fall back to the default."
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Create custom field"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Create fee type"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Row 1"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Row 2"
+msgstr ""
+
+#: lib/mv_web/live/import_live/components.ex
+#, elixir-autogen, elixir-format
+msgid "Row 3"
+msgstr ""
diff --git a/test/mv_web/live/import_live/components_test.exs b/test/mv_web/live/import_live/components_test.exs
new file mode 100644
index 0000000..3870ed6
--- /dev/null
+++ b/test/mv_web/live/import_live/components_test.exs
@@ -0,0 +1,31 @@
+defmodule MvWeb.ImportLive.ComponentsTest do
+ use ExUnit.Case, async: true
+
+ alias MvWeb.ImportLive.Components
+
+ describe "import_button_disabled?/2" do
+ @done_entry %{done?: true}
+
+ test "disables the Start Import button while the preview is displayed" do
+ # During :preview the upload entry is done, but re-clicking Start Import
+ # would re-run the upload processing and overwrite the current preview.
+ assert Components.import_button_disabled?(:preview, [@done_entry]) == true
+ end
+
+ test "disables the button while an import is running" do
+ assert Components.import_button_disabled?(:running, [@done_entry]) == true
+ end
+
+ test "disables the button when there are no upload entries" do
+ assert Components.import_button_disabled?(:idle, []) == true
+ end
+
+ test "disables the button while an upload entry is not yet done" do
+ assert Components.import_button_disabled?(:idle, [%{done?: false}]) == true
+ end
+
+ test "enables the button at idle with a completed upload" do
+ assert Components.import_button_disabled?(:idle, [@done_entry]) == false
+ end
+ end
+end
diff --git a/test/mv_web/live/import_live_test.exs b/test/mv_web/live/import_live_test.exs
index 7b4dd40..bd5cdec 100644
--- a/test/mv_web/live/import_live_test.exs
+++ b/test/mv_web/live/import_live_test.exs
@@ -27,6 +27,16 @@ defmodule MvWeb.ImportLiveTest do
defp submit_import(view), do: view |> form("#csv-upload-form", %{}) |> render_submit()
+ defp confirm_import(view),
+ do: view |> element("[data-testid='confirm-import-button']") |> render_click()
+
+ # Full flow: upload, enter preview (start), then confirm to begin processing.
+ defp run_full_import(view, csv_content, filename \\ "test_import.csv") do
+ upload_csv_file(view, csv_content, filename)
+ submit_import(view)
+ confirm_import(view)
+ end
+
defp wait_for_import_completion, do: Process.sleep(1000)
# ---------- Business logic: Authorization ----------
@@ -56,8 +66,7 @@ defmodule MvWeb.ImportLiveTest do
|> File.read!()
{:ok, view, _html} = live(conn, ~p"/admin/import")
- upload_csv_file(view, csv_content)
- submit_import(view)
+ run_full_import(view, csv_content)
wait_for_import_completion()
assert has_element?(view, "[data-testid='import-results-panel']")
@@ -121,8 +130,7 @@ defmodule MvWeb.ImportLiveTest do
invalid_csv: csv_content
} do
{:ok, view, _html} = live(conn, ~p"/admin/import")
- upload_csv_file(view, csv_content, "invalid_import.csv")
- submit_import(view)
+ run_full_import(view, csv_content, "invalid_import.csv")
wait_for_import_completion()
assert has_element?(view, "[data-testid='import-results-panel']")
@@ -141,8 +149,7 @@ defmodule MvWeb.ImportLiveTest do
invalid_rows =
for i <- 1..100, do: "Row#{i};Last#{i};;Country#{i};City#{i};Street#{i};12345\n"
- upload_csv_file(view, header <> Enum.join(invalid_rows), "large_invalid.csv")
- submit_import(view)
+ run_full_import(view, header <> Enum.join(invalid_rows), "large_invalid.csv")
wait_for_import_completion()
assert has_element?(view, "[data-testid='import-results-panel']")
@@ -174,8 +181,7 @@ defmodule MvWeb.ImportLiveTest do
Path.join([__DIR__, "..", "..", "fixtures", "csv_with_bom_semicolon.csv"])
|> File.read!()
- upload_csv_file(view, csv_content, "bom_import.csv")
- submit_import(view)
+ run_full_import(view, csv_content, "bom_import.csv")
wait_for_import_completion()
assert has_element?(view, "[data-testid='import-results-panel']")
@@ -193,8 +199,7 @@ defmodule MvWeb.ImportLiveTest do
Path.join([__DIR__, "..", "..", "fixtures", "csv_with_empty_lines.csv"])
|> File.read!()
- upload_csv_file(view, csv_content, "empty_lines.csv")
- submit_import(view)
+ run_full_import(view, csv_content, "empty_lines.csv")
wait_for_import_completion()
assert has_element?(view, "[data-testid='import-error-list']")
@@ -208,8 +213,7 @@ defmodule MvWeb.ImportLiveTest do
unknown_custom_field_csv: csv_content
} do
{:ok, view, _html} = live(conn, ~p"/admin/import")
- upload_csv_file(view, csv_content, "unknown_custom.csv")
- submit_import(view)
+ run_full_import(view, csv_content, "unknown_custom.csv")
wait_for_import_completion()
assert has_element?(view, "[data-testid='import-results-panel']")
@@ -254,14 +258,27 @@ defmodule MvWeb.ImportLiveTest do
assert has_element?(view, "[data-testid='csv-upload-form'] input[type='file']")
end
+ test "custom fields notice lists accepted groups and fee-type column names", %{conn: conn} do
+ {:ok, _view, html} = live(conn, ~p"/admin/import")
+
+ # Groups column variants (both EN and DE)
+ assert html =~ "Groups"
+ assert html =~ "Gruppen"
+ # Fee type column variants (both EN and DE)
+ assert html =~ "Beitragsart"
+ assert html =~ "Fee Type"
+ assert html =~ "fee type"
+ # Fee status is always ignored (named explicitly)
+ assert html =~ "Bezahlstatus"
+ end
+
test "after successful import, progress container has aria-live", %{conn: conn} do
csv_content =
Path.join([__DIR__, "..", "..", "fixtures", "valid_member_import.csv"])
|> File.read!()
{:ok, view, _html} = live(conn, ~p"/admin/import")
- upload_csv_file(view, csv_content)
- submit_import(view)
+ run_full_import(view, csv_content)
wait_for_import_completion()
assert has_element?(view, "[data-testid='import-progress-container']")
html = render(view)
@@ -280,4 +297,187 @@ defmodule MvWeb.ImportLiveTest do
html = render(view)
assert html =~ "Failed to prepare"
end
+
+ describe "preview state machine" do
+ setup %{conn: conn} do
+ admin_user = Mv.Fixtures.user_with_role_fixture("admin")
+
+ conn =
+ conn
+ |> MvWeb.ConnCase.conn_with_password_user(admin_user)
+ |> put_locale_en()
+
+ valid_csv =
+ Path.join([__DIR__, "..", "..", "fixtures", "valid_member_import.csv"])
+ |> File.read!()
+
+ {:ok, conn: conn, valid_csv: valid_csv}
+ end
+
+ test "start_import transitions to preview without processing", %{
+ conn: conn,
+ valid_csv: csv_content
+ } do
+ {:ok, view, _html} = live(conn, ~p"/admin/import")
+ upload_csv_file(view, csv_content)
+ submit_import(view)
+
+ # Preview is shown; no results panel yet because nothing was processed.
+ assert has_element?(view, "[data-testid='import-preview']")
+ refute has_element?(view, "[data-testid='import-results-panel']")
+
+ # No member was created during preview (read-only step).
+ system_actor = Mv.Helpers.SystemActor.get_system_actor()
+ {:ok, members} = Membership.list_members(actor: system_actor)
+
+ refute Enum.any?(
+ members,
+ &(&1.email in ["alice.smith@example.com", "bob.johnson@example.com"])
+ )
+ end
+
+ test "confirm_import starts processing and creates members", %{
+ conn: conn,
+ valid_csv: csv_content
+ } do
+ {:ok, view, _html} = live(conn, ~p"/admin/import")
+ run_full_import(view, csv_content)
+ wait_for_import_completion()
+
+ assert has_element?(view, "[data-testid='import-results-panel']")
+
+ system_actor = Mv.Helpers.SystemActor.get_system_actor()
+ {:ok, members} = Membership.list_members(actor: system_actor)
+
+ imported =
+ Enum.filter(
+ members,
+ &(&1.email in ["alice.smith@example.com", "bob.johnson@example.com"])
+ )
+
+ assert length(imported) == 2
+ end
+
+ test "cancel_import returns to idle and hides the preview", %{
+ conn: conn,
+ valid_csv: csv_content
+ } do
+ {:ok, view, _html} = live(conn, ~p"/admin/import")
+ upload_csv_file(view, csv_content)
+ submit_import(view)
+ assert has_element?(view, "[data-testid='import-preview']")
+
+ view |> element("[data-testid='cancel-import-button']") |> render_click()
+
+ refute has_element?(view, "[data-testid='import-preview']")
+ refute has_element?(view, "[data-testid='import-results-panel']")
+ end
+ end
+
+ describe "preview contents" do
+ setup %{conn: conn} do
+ admin_user = Mv.Fixtures.user_with_role_fixture("admin")
+
+ conn =
+ conn
+ |> MvWeb.ConnCase.conn_with_password_user(admin_user)
+ |> put_locale_en()
+
+ {:ok, conn: conn}
+ end
+
+ test "shows the column mapping table with roles for each column", %{conn: conn} do
+ csv = "email;Gruppen;Beitragsart;Bezahlstatus;UnknownCol\na@e.com;Chor;Premium;paid;x"
+
+ {:ok, view, _html} = live(conn, ~p"/admin/import")
+ upload_csv_file(view, csv)
+ submit_import(view)
+
+ assert has_element?(view, "[data-testid='preview-mapping-table']")
+ html = render(view)
+
+ assert html =~ "email"
+ assert html =~ "Gruppen"
+ assert html =~ "Beitragsart"
+ assert html =~ "Bezahlstatus"
+ assert html =~ "UnknownCol"
+ end
+
+ test "lists every CSV column exactly once in the mapping table", %{conn: conn} do
+ headers = ["email", "Gruppen", "Beitragsart", "Bezahlstatus", "UnknownCol"]
+ csv = Enum.join(headers, ";") <> "\na@e.com;Chor;Premium;paid;x"
+
+ {:ok, view, _html} = live(conn, ~p"/admin/import")
+ upload_csv_file(view, csv)
+ submit_import(view)
+
+ # Count the data rows via their stable testid so the assertion is independent
+ # of how Phoenix renders class attributes or tr tags (§1.15).
+ html = render(view)
+
+ row_count =
+ html |> String.split(~s(data-testid="preview-column-row")) |> length() |> Kernel.-(1)
+
+ assert row_count == length(headers)
+ end
+
+ test "shows up to 3 sample data rows", %{conn: conn} do
+ csv = "email\nr1@e.com\nr2@e.com\nr3@e.com\nr4@e.com"
+
+ {:ok, view, _html} = live(conn, ~p"/admin/import")
+ upload_csv_file(view, csv)
+ submit_import(view)
+
+ html = render(view)
+ assert html =~ "r1@e.com"
+ assert html =~ "r2@e.com"
+ assert html =~ "r3@e.com"
+ refute html =~ "r4@e.com"
+ end
+
+ test "shows an auto-create notice for unknown group names", %{conn: conn} do
+ csv = "email;Gruppen\na@e.com;Ganz Neue Gruppe"
+
+ {:ok, view, _html} = live(conn, ~p"/admin/import")
+ upload_csv_file(view, csv)
+ submit_import(view)
+
+ assert has_element?(view, "[data-testid='preview-groups-notice']")
+ assert render(view) =~ "Ganz Neue Gruppe"
+ end
+
+ test "shows a warning and link for unknown fee-type names", %{conn: conn} do
+ csv = "email;Beitragsart\na@e.com;Phantom Tarif"
+
+ {:ok, view, _html} = live(conn, ~p"/admin/import")
+ upload_csv_file(view, csv)
+ submit_import(view)
+
+ assert has_element?(view, "[data-testid='preview-fee-type-warning']")
+ html = render(view)
+ assert html =~ "Phantom Tarif"
+ assert html =~ "/membership_fee_settings"
+ end
+
+ test "shows an info notice when fee-type cells are empty", %{conn: conn} do
+ csv = "email;Beitragsart\na@e.com;\nb@e.com;"
+
+ {:ok, view, _html} = live(conn, ~p"/admin/import")
+ upload_csv_file(view, csv)
+ submit_import(view)
+
+ assert has_element?(view, "[data-testid='preview-fee-type-info']")
+ end
+
+ test "shows a warning for unknown custom-field columns", %{conn: conn} do
+ csv = "email;TotallyUnknown\na@e.com;value"
+
+ {:ok, view, _html} = live(conn, ~p"/admin/import")
+ upload_csv_file(view, csv)
+ submit_import(view)
+
+ assert has_element?(view, "[data-testid='preview-unknown-warning']")
+ assert render(view) =~ "TotallyUnknown"
+ end
+ end
end
From 118b9f8d57bdd09a259e6f1c8513f662d2d4d325 Mon Sep 17 00:00:00 2001
From: Moritz
Date: Wed, 3 Jun 2026 02:32:15 +0200
Subject: [PATCH 10/23] perf(import): reuse auto-created groups across import
chunks
---
lib/mv/membership/import/import_runner.ex | 14 ++++++
lib/mv/membership/import/member_csv.ex | 11 +++--
lib/mv_web/live/import_live.ex | 3 ++
.../membership/import/import_runner_test.exs | 18 +++++++
test/mv/membership/import/member_csv_test.exs | 47 +++++++++++++++++++
5 files changed, 90 insertions(+), 3 deletions(-)
diff --git a/lib/mv/membership/import/import_runner.ex b/lib/mv/membership/import/import_runner.ex
index 5f953d4..b56cae6 100644
--- a/lib/mv/membership/import/import_runner.ex
+++ b/lib/mv/membership/import/import_runner.ex
@@ -97,6 +97,20 @@ defmodule Mv.Membership.Import.ImportRunner do
}
end
+ @doc """
+ Carries the in-memory group snapshot grown by a chunk back into `import_state`
+ so the next chunk reuses groups created earlier instead of re-reading the
+ Group table. When the chunk result omits `groups_found`, the state is returned
+ unchanged.
+ """
+ @spec carry_groups_forward(map(), map()) :: map()
+ def carry_groups_forward(import_state, chunk_result) do
+ case Map.fetch(chunk_result, :groups_found) do
+ {:ok, groups_found} -> Map.put(import_state, :groups_found, groups_found)
+ :error -> import_state
+ end
+ end
+
@doc """
Returns the next action after processing a chunk: send the next chunk index or done.
"""
diff --git a/lib/mv/membership/import/member_csv.ex b/lib/mv/membership/import/member_csv.ex
index d0ab74b..31dea59 100644
--- a/lib/mv/membership/import/member_csv.ex
+++ b/lib/mv/membership/import/member_csv.ex
@@ -37,6 +37,9 @@ defmodule Mv.Membership.Import.MemberCSV do
- `inserted` - Number of successfully created members
- `failed` - Number of failed member creations
- `errors` - List of `%MemberCSV.Error{}` structs (capped at 50 per import)
+ - `groups_found` - The in-memory group snapshot grown while processing this
+ chunk; thread it into the next chunk's `:groups_found` opt so groups created
+ in an earlier chunk are reused without re-reading the Group table
## Examples
@@ -94,7 +97,8 @@ defmodule Mv.Membership.Import.MemberCSV do
failed: non_neg_integer(),
errors: list(Error.t()),
errors_truncated?: boolean(),
- warnings: list(String.t())
+ warnings: list(String.t()),
+ groups_found: list(Mv.Membership.Group.t() | %{id: String.t(), name: String.t()})
}
alias Mv.Membership.Import.ColumnResolver
@@ -374,7 +378,7 @@ defmodule Mv.Membership.Import.MemberCSV do
actor: actor
}
- {inserted, failed, errors, _collected_error_count, truncated?, warnings, _groups_acc} =
+ {inserted, failed, errors, _collected_error_count, truncated?, warnings, groups_acc} =
Enum.reduce(chunk_rows_with_lines, {0, 0, [], 0, false, [], groups_found}, fn {line_number,
row_map},
{acc_inserted,
@@ -417,7 +421,8 @@ defmodule Mv.Membership.Import.MemberCSV do
failed: failed,
errors: Enum.reverse(errors),
errors_truncated?: truncated?,
- warnings: warnings
+ warnings: warnings,
+ groups_found: groups_acc
}}
end
diff --git a/lib/mv_web/live/import_live.ex b/lib/mv_web/live/import_live.ex
index 2c5aa8a..cd7f6d3 100644
--- a/lib/mv_web/live/import_live.ex
+++ b/lib/mv_web/live/import_live.ex
@@ -367,8 +367,11 @@ defmodule MvWeb.ImportLive do
new_progress =
ImportRunner.merge_progress(progress, chunk_result, idx, max_errors: @max_errors)
+ new_import_state = ImportRunner.carry_groups_forward(import_state, chunk_result)
+
socket =
socket
+ |> assign(:import_state, new_import_state)
|> assign(:import_progress, new_progress)
|> assign(:import_status, new_progress.status)
|> maybe_send_next_chunk(idx, length(import_state.chunks))
diff --git a/test/mv/membership/import/import_runner_test.exs b/test/mv/membership/import/import_runner_test.exs
index 88d189e..22d21bd 100644
--- a/test/mv/membership/import/import_runner_test.exs
+++ b/test/mv/membership/import/import_runner_test.exs
@@ -3,6 +3,24 @@ defmodule Mv.Membership.Import.ImportRunnerTest do
alias Mv.Membership.Import.ImportRunner
+ describe "carry_groups_forward/2" do
+ test "replaces import_state groups_found with the chunk's grown snapshot" do
+ import_state = %{groups_found: [%{id: "1", name: "A"}]}
+ chunk_result = %{groups_found: [%{id: "1", name: "A"}, %{id: "2", name: "B"}]}
+
+ assert ImportRunner.carry_groups_forward(import_state, chunk_result) == %{
+ groups_found: [%{id: "1", name: "A"}, %{id: "2", name: "B"}]
+ }
+ end
+
+ test "leaves import_state unchanged when the chunk result omits groups_found" do
+ import_state = %{groups_found: [%{id: "1", name: "A"}], other: :kept}
+ chunk_result = %{inserted: 1}
+
+ assert ImportRunner.carry_groups_forward(import_state, chunk_result) == import_state
+ end
+ end
+
describe "read_file_entry/2" do
test "returns {:ok, content} for a readable file" do
path =
diff --git a/test/mv/membership/import/member_csv_test.exs b/test/mv/membership/import/member_csv_test.exs
index 0701a92..91adb91 100644
--- a/test/mv/membership/import/member_csv_test.exs
+++ b/test/mv/membership/import/member_csv_test.exs
@@ -1116,6 +1116,53 @@ defmodule Mv.Membership.Import.MemberCSVTest do
"Expected the group table read at most a few times, got #{reads} reads for 10 rows (N+1)."
end
+ test "returns the grown group snapshot so later chunks skip the table read",
+ %{actor: actor} do
+ chunk1 = [
+ {2, %{member: %{email: "g-xchunk-1@example.com"}, custom: %{}, groups: "Shared X"}}
+ ]
+
+ chunk2 = [
+ {3, %{member: %{email: "g-xchunk-2@example.com"}, custom: %{}, groups: "Shared X"}}
+ ]
+
+ assert {:ok, result1} =
+ MemberCSV.process_chunk(chunk1, %{email: 0}, %{}, actor: actor, groups_found: [])
+
+ # The chunk result must expose the accumulated snapshot, including the group
+ # auto-created while processing this chunk, so the LiveView can thread it
+ # into the next chunk's opts.
+ assert is_list(result1.groups_found)
+ assert Enum.any?(result1.groups_found, &(&1.name == "Shared X"))
+
+ group_read_count = Agent.start_link(fn -> 0 end) |> elem(1)
+ test_pid = self()
+
+ handler = fn _event, _measurements, metadata, _config ->
+ if self() == test_pid and metadata[:source] == "groups" and
+ is_binary(metadata[:query]) and String.starts_with?(metadata.query, "SELECT") do
+ Agent.update(group_read_count, &(&1 + 1))
+ end
+ end
+
+ handler_id = "test-xchunk-group-read-#{System.unique_integer([:positive])}"
+ :telemetry.attach(handler_id, [:mv, :repo, :query], handler, nil)
+
+ assert {:ok, %{inserted: 1}} =
+ MemberCSV.process_chunk(chunk2, %{email: 0}, %{},
+ actor: actor,
+ groups_found: result1.groups_found
+ )
+
+ reads = Agent.get(group_read_count, & &1)
+ :telemetry.detach(handler_id)
+
+ # The second chunk receives the snapshot grown by the first, so the shared
+ # group resolves from memory without any full-table read.
+ assert reads == 0,
+ "Expected no group table read in the second chunk, got #{reads} (snapshot not threaded across chunks)."
+ end
+
test "empty groups cell leaves the member without group assignment", %{actor: actor} do
chunk = [{2, %{member: %{email: "g-empty@example.com"}, custom: %{}, groups: " "}}]
opts = [actor: actor, groups_found: []]
From 45c9b819838d46461cfd7431c805f86d667ae7bd Mon Sep 17 00:00:00 2001
From: Moritz
Date: Wed, 3 Jun 2026 02:37:12 +0200
Subject: [PATCH 11/23] fix(import): collapse duplicate fee-type warnings into
a bounded list
---
lib/mv/membership/import/import_runner.ex | 2 +-
.../membership/import/import_runner_test.exs | 59 +++++++++++++++++++
2 files changed, 60 insertions(+), 1 deletion(-)
diff --git a/lib/mv/membership/import/import_runner.ex b/lib/mv/membership/import/import_runner.ex
index b56cae6..28893a3 100644
--- a/lib/mv/membership/import/import_runner.ex
+++ b/lib/mv/membership/import/import_runner.ex
@@ -80,7 +80,7 @@ defmodule Mv.Membership.Import.ImportRunner do
all_errors = progress.errors ++ chunk_result.errors
new_errors = Enum.take(all_errors, max_errors)
errors_truncated? = length(all_errors) > max_errors
- new_warnings = progress.warnings ++ Map.get(chunk_result, :warnings, [])
+ new_warnings = Enum.uniq(progress.warnings ++ Map.get(chunk_result, :warnings, []))
chunks_processed = current_chunk_idx + 1
new_status = if chunks_processed >= progress.total_chunks, do: :done, else: :running
diff --git a/test/mv/membership/import/import_runner_test.exs b/test/mv/membership/import/import_runner_test.exs
index 22d21bd..b5fe3c2 100644
--- a/test/mv/membership/import/import_runner_test.exs
+++ b/test/mv/membership/import/import_runner_test.exs
@@ -21,6 +21,65 @@ defmodule Mv.Membership.Import.ImportRunnerTest do
end
end
+ describe "merge_progress/4 warning accumulation" do
+ test "deduplicates identical warnings across chunks instead of growing unbounded" do
+ progress = %{
+ inserted: 0,
+ failed: 0,
+ errors: [],
+ warnings: ["Fee type 'Ghost' not found; using the default fee type."],
+ status: :running,
+ current_chunk: 0,
+ total_chunks: 3
+ }
+
+ chunk_result = %{
+ inserted: 2,
+ failed: 0,
+ errors: [],
+ errors_truncated?: false,
+ warnings: [
+ "Fee type 'Ghost' not found; using the default fee type.",
+ "Fee type 'Ghost' not found; using the default fee type."
+ ]
+ }
+
+ result = ImportRunner.merge_progress(progress, chunk_result, 0)
+
+ assert result.warnings == ["Fee type 'Ghost' not found; using the default fee type."]
+ end
+
+ test "preserves distinct warnings while collapsing duplicates" do
+ progress = %{
+ inserted: 0,
+ failed: 0,
+ errors: [],
+ warnings: ["Fee type 'A' not found; using the default fee type."],
+ status: :running,
+ current_chunk: 0,
+ total_chunks: 2
+ }
+
+ chunk_result = %{
+ inserted: 1,
+ failed: 0,
+ errors: [],
+ errors_truncated?: false,
+ warnings: [
+ "Fee type 'A' not found; using the default fee type.",
+ "Fee type 'B' not found; using the default fee type."
+ ]
+ }
+
+ result = ImportRunner.merge_progress(progress, chunk_result, 0)
+
+ assert result.warnings == [
+ "Fee type 'A' not found; using the default fee type.",
+ "Fee type 'B' not found; using the default fee type."
+ ]
+ end
+ end
+
describe "read_file_entry/2" do
test "returns {:ok, content} for a readable file" do
path =
From 2bc5fcec5ac655dac6abd06b3ebcddf9dda234bc Mon Sep 17 00:00:00 2001
From: Moritz
Date: Wed, 3 Jun 2026 02:37:46 +0200
Subject: [PATCH 12/23] docs(changelog): record CSV import improvements under
Unreleased
---
CHANGELOG.md | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8c8032c..edb53f9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,18 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+## [Unreleased]
+
+### Added
+- **CSV import – groups column** – Members can be assigned to groups during CSV import via a `Groups`/`Gruppen` column; group names that do not exist yet are created automatically, and re-importing the same file does not create duplicate groups.
+- **CSV import – membership fee type column** – A `Fee Type`/`Beitragsart` column assigns each member's membership fee type; an unknown name falls back to the default fee type and is flagged in the preview with a link to create it.
+- **CSV import – mapping preview** – After uploading a file, a preview shows how every column maps (with sample rows and warnings for ignored or unknown columns) and the import only starts once you confirm.
+- **Dynamic CSV import templates** – The EN and DE import-template downloads now include the association's current custom fields instead of a fixed column set.
+
+### Fixed
+- **CSV date round-trip** – Date custom-field values are now exported as ISO-8601 (`YYYY-MM-DD`), so an exported CSV can be re-imported without date-parsing errors.
+- **CSV import – fee-status columns ignored** – Columns such as `Bezahlstatus` / `Membership Fee Status` are always ignored on import and never stored as a custom-field value, even when a custom field of the same name exists.
+
## [1.2.0] - 2026-05-08
### Changed
From b6c2cf58b1c86f782e1b84391d22602aae677dc1 Mon Sep 17 00:00:00 2001
From: Simon
Date: Wed, 3 Jun 2026 12:01:41 +0200
Subject: [PATCH 13/23] feat(custom-field): add join_description attribute for
GDPR join-form labels
---
lib/membership/custom_field.ex | 24 ++-
..._add_join_description_to_custom_fields.exs | 21 +++
.../repo/custom_fields/20260603000204.json | 145 ++++++++++++++++++
.../custom_field_validation_test.exs | 55 +++++++
4 files changed, 242 insertions(+), 3 deletions(-)
create mode 100644 priv/repo/migrations/20260603000531_add_join_description_to_custom_fields.exs
create mode 100644 priv/resource_snapshots/repo/custom_fields/20260603000204.json
diff --git a/lib/membership/custom_field.ex b/lib/membership/custom_field.ex
index ef6c79a..5f4dd0e 100644
--- a/lib/membership/custom_field.ex
+++ b/lib/membership/custom_field.ex
@@ -12,6 +12,8 @@ defmodule Mv.Membership.CustomField do
- `slug` - URL-friendly, immutable identifier automatically generated from name (e.g., "phone-mobile")
- `value_type` - Data type constraint (`:string`, `:integer`, `:boolean`, `:date`, `:email`). Immutable after creation.
- `description` - Optional human-readable description
+ - `join_description` - Optional label shown for this field on the public join form
+ (e.g., a GDPR confirmation text); supports inline external links. Falls back to `name` when nil.
- `required` - If true, all members must have this custom field (future feature)
- `show_in_overview` - If true, this custom field will be displayed in the member overview table and can be sorted
@@ -61,7 +63,14 @@ defmodule Mv.Membership.CustomField do
end
actions do
- default_accept [:name, :value_type, :description, :required, :show_in_overview]
+ default_accept [
+ :name,
+ :value_type,
+ :description,
+ :join_description,
+ :required,
+ :show_in_overview
+ ]
read :read do
primary? true
@@ -69,13 +78,13 @@ defmodule Mv.Membership.CustomField do
end
create :create do
- accept [:name, :value_type, :description, :required, :show_in_overview]
+ accept [:name, :value_type, :description, :join_description, :required, :show_in_overview]
change Mv.Membership.Changes.GenerateSlug
validate string_length(:slug, min: 1)
end
update :update do
- accept [:name, :description, :required, :show_in_overview]
+ accept [:name, :description, :join_description, :required, :show_in_overview]
require_atomic? false
validate fn changeset, _context ->
@@ -139,6 +148,15 @@ defmodule Mv.Membership.CustomField do
trim?: true
]
+ attribute :join_description, :string,
+ allow_nil?: true,
+ public?: true,
+ description: "Label shown for this field on the public join form; supports external links",
+ constraints: [
+ max_length: 1000,
+ trim?: true
+ ]
+
attribute :required, :boolean,
default: false,
allow_nil?: false
diff --git a/priv/repo/migrations/20260603000531_add_join_description_to_custom_fields.exs b/priv/repo/migrations/20260603000531_add_join_description_to_custom_fields.exs
new file mode 100644
index 0000000..b1d9a05
--- /dev/null
+++ b/priv/repo/migrations/20260603000531_add_join_description_to_custom_fields.exs
@@ -0,0 +1,21 @@
+defmodule Mv.Repo.Migrations.AddJoinDescriptionToCustomFields do
+ @moduledoc """
+ Updates resources based on their most recent snapshots.
+
+ This file was autogenerated with `mix ash_postgres.generate_migrations`
+ """
+
+ use Ecto.Migration
+
+ def up do
+ alter table(:custom_fields) do
+ add :join_description, :text
+ end
+ end
+
+ def down do
+ alter table(:custom_fields) do
+ remove :join_description
+ end
+ end
+end
diff --git a/priv/resource_snapshots/repo/custom_fields/20260603000204.json b/priv/resource_snapshots/repo/custom_fields/20260603000204.json
new file mode 100644
index 0000000..aa0b0ed
--- /dev/null
+++ b/priv/resource_snapshots/repo/custom_fields/20260603000204.json
@@ -0,0 +1,145 @@
+{
+ "attributes": [
+ {
+ "allow_nil?": false,
+ "default": "fragment(\"gen_random_uuid()\")",
+ "generated?": false,
+ "precision": null,
+ "primary_key?": true,
+ "references": null,
+ "scale": null,
+ "size": null,
+ "source": "id",
+ "type": "uuid"
+ },
+ {
+ "allow_nil?": false,
+ "default": "nil",
+ "generated?": false,
+ "precision": null,
+ "primary_key?": false,
+ "references": null,
+ "scale": null,
+ "size": null,
+ "source": "name",
+ "type": "text"
+ },
+ {
+ "allow_nil?": false,
+ "default": "nil",
+ "generated?": false,
+ "precision": null,
+ "primary_key?": false,
+ "references": null,
+ "scale": null,
+ "size": null,
+ "source": "slug",
+ "type": "text"
+ },
+ {
+ "allow_nil?": false,
+ "default": "nil",
+ "generated?": false,
+ "precision": null,
+ "primary_key?": false,
+ "references": null,
+ "scale": null,
+ "size": null,
+ "source": "value_type",
+ "type": "text"
+ },
+ {
+ "allow_nil?": true,
+ "default": "nil",
+ "generated?": false,
+ "precision": null,
+ "primary_key?": false,
+ "references": null,
+ "scale": null,
+ "size": null,
+ "source": "description",
+ "type": "text"
+ },
+ {
+ "allow_nil?": true,
+ "default": "nil",
+ "generated?": false,
+ "precision": null,
+ "primary_key?": false,
+ "references": null,
+ "scale": null,
+ "size": null,
+ "source": "join_description",
+ "type": "text"
+ },
+ {
+ "allow_nil?": false,
+ "default": "false",
+ "generated?": false,
+ "precision": null,
+ "primary_key?": false,
+ "references": null,
+ "scale": null,
+ "size": null,
+ "source": "required",
+ "type": "boolean"
+ },
+ {
+ "allow_nil?": false,
+ "default": "true",
+ "generated?": false,
+ "precision": null,
+ "primary_key?": false,
+ "references": null,
+ "scale": null,
+ "size": null,
+ "source": "show_in_overview",
+ "type": "boolean"
+ }
+ ],
+ "base_filter": null,
+ "check_constraints": [],
+ "create_table_options": null,
+ "custom_indexes": [],
+ "custom_statements": [],
+ "has_create_action": true,
+ "hash": "2600667D140A2A846F9A848ACEFCADA1F1206950B38EF407B0BB13816E508A2A",
+ "identities": [
+ {
+ "all_tenants?": false,
+ "base_filter": null,
+ "index_name": "custom_fields_unique_name_index",
+ "keys": [
+ {
+ "type": "atom",
+ "value": "name"
+ }
+ ],
+ "name": "unique_name",
+ "nils_distinct?": true,
+ "where": null
+ },
+ {
+ "all_tenants?": false,
+ "base_filter": null,
+ "index_name": "custom_fields_unique_slug_index",
+ "keys": [
+ {
+ "type": "atom",
+ "value": "slug"
+ }
+ ],
+ "name": "unique_slug",
+ "nils_distinct?": true,
+ "where": null
+ }
+ ],
+ "multitenancy": {
+ "attribute": null,
+ "global": null,
+ "strategy": null
+ },
+ "repo": "Elixir.Mv.Repo",
+ "schema": null,
+ "table": "custom_fields"
+}
\ No newline at end of file
diff --git a/test/membership/custom_field_validation_test.exs b/test/membership/custom_field_validation_test.exs
index e642d82..9b1faf5 100644
--- a/test/membership/custom_field_validation_test.exs
+++ b/test/membership/custom_field_validation_test.exs
@@ -159,6 +159,61 @@ defmodule Mv.Membership.CustomFieldValidationTest do
end
end
+ describe "join_description" do
+ test "persists join_description when set", %{actor: actor} do
+ assert {:ok, custom_field} =
+ CustomField
+ |> Ash.Changeset.for_create(:create, %{
+ name: "dsgvo_field",
+ value_type: :boolean,
+ join_description: "hereby I confirm the GDPR"
+ })
+ |> Ash.create(actor: actor)
+
+ assert custom_field.join_description == "hereby I confirm the GDPR"
+ end
+
+ test "defaults to nil when not given", %{actor: actor} do
+ assert {:ok, custom_field} =
+ CustomField
+ |> Ash.Changeset.for_create(:create, %{
+ name: "no_join_desc",
+ value_type: :boolean
+ })
+ |> Ash.create(actor: actor)
+
+ assert custom_field.join_description == nil
+ end
+
+ test "rejects join_description longer than 1000 characters", %{actor: actor} do
+ assert {:error, changeset} =
+ CustomField
+ |> Ash.Changeset.for_create(:create, %{
+ name: "too_long_join_desc",
+ value_type: :boolean,
+ join_description: String.duplicate("a", 1001)
+ })
+ |> Ash.create(actor: actor)
+
+ assert [%{field: :join_description, message: message}] = changeset.errors
+ assert message =~ "max" or message =~ "length" or message =~ "1000"
+ end
+
+ test "is writable via the update action", %{actor: actor} do
+ {:ok, custom_field} =
+ CustomField
+ |> Ash.Changeset.for_create(:create, %{name: "updatable", value_type: :boolean})
+ |> Ash.create(actor: actor)
+
+ assert {:ok, updated} =
+ custom_field
+ |> Ash.Changeset.for_update(:update, %{join_description: "Accept the GDPR"})
+ |> Ash.update(actor: actor)
+
+ assert updated.join_description == "Accept the GDPR"
+ end
+ end
+
describe "name uniqueness" do
test "rejects duplicate names", %{actor: actor} do
assert {:ok, _} =
From cb5cb6848323d8d7bb00ac939fabe27a5d5a12e8 Mon Sep 17 00:00:00 2001
From: Simon
Date: Wed, 3 Jun 2026 12:06:48 +0200
Subject: [PATCH 14/23] feat(join): render join_description with auto-linked
URLs and Markdown links
---
.../helpers/join_description_renderer.ex | 70 +++++++++++++++
.../join_description_renderer_test.exs | 85 +++++++++++++++++++
2 files changed, 155 insertions(+)
create mode 100644 lib/mv_web/helpers/join_description_renderer.ex
create mode 100644 test/mv_web/helpers/join_description_renderer_test.exs
diff --git a/lib/mv_web/helpers/join_description_renderer.ex b/lib/mv_web/helpers/join_description_renderer.ex
new file mode 100644
index 0000000..121b02b
--- /dev/null
+++ b/lib/mv_web/helpers/join_description_renderer.ex
@@ -0,0 +1,70 @@
+defmodule MvWeb.Helpers.JoinDescriptionRenderer do
+ @moduledoc """
+ Renders a custom field's `join_description` into Phoenix-safe HTML for the
+ public join form.
+
+ The renderer auto-links two patterns into `` tags:
+
+ - Markdown links of the form `[text](url)` (processed first)
+ - bare `http(s)://` URLs in the remaining text
+
+ All other content is HTML-escaped: only `` tags are ever
+ emitted, so arbitrary HTML in the input is rendered as inert text. This is a
+ defense-in-depth measure — `join_description` is admin-set content, never
+ end-user input — but the renderer must not become a vector for injecting
+ arbitrary markup.
+
+ Markdown links are matched before bare URLs and their matched region is
+ consumed, so a Markdown link whose URL also looks like a bare URL is linked
+ exactly once (no nested anchors).
+ """
+
+ @markdown_link ~r/\[([^\]]+)\]\((https?:\/\/[^\s)]+)\)/
+ @bare_url ~r/(https?:\/\/[^\s<]+)/
+ @bare_url_anchored ~r/\A(https?:\/\/[^\s<]+)\z/
+
+ @doc """
+ Converts `value` to a Phoenix-safe HTML iolist.
+
+ Returns `{:safe, ""}` for `nil`. For a string, returns `{:safe, iolist}` with
+ links rendered and all other text HTML-escaped.
+ """
+ @spec render(String.t() | nil) :: Phoenix.HTML.safe()
+ def render(nil), do: {:safe, ""}
+
+ def render(value) when is_binary(value) do
+ {:safe, render_segments(value)}
+ end
+
+ # Split on Markdown links first; for each non-Markdown segment, link bare URLs;
+ # everything that is not a link is HTML-escaped.
+ defp render_segments(text) do
+ Regex.split(@markdown_link, text, include_captures: true)
+ |> Enum.map(&render_markdown_or_plain/1)
+ end
+
+ defp render_markdown_or_plain(segment) do
+ case Regex.run(@markdown_link, segment) do
+ [^segment, label, url] -> anchor(url, label)
+ _ -> render_plain(segment)
+ end
+ end
+
+ # Auto-link bare URLs in a plain-text segment, escaping all surrounding text.
+ defp render_plain(segment) do
+ Regex.split(@bare_url, segment, include_captures: true)
+ |> Enum.map(fn part ->
+ if Regex.match?(@bare_url_anchored, part) do
+ anchor(part, part)
+ else
+ escape(part)
+ end
+ end)
+ end
+
+ defp anchor(url, label) do
+ ["", escape(label), ""]
+ end
+
+ defp escape(text), do: Phoenix.HTML.html_escape(text) |> Phoenix.HTML.safe_to_string()
+end
diff --git a/test/mv_web/helpers/join_description_renderer_test.exs b/test/mv_web/helpers/join_description_renderer_test.exs
new file mode 100644
index 0000000..62eb91d
--- /dev/null
+++ b/test/mv_web/helpers/join_description_renderer_test.exs
@@ -0,0 +1,85 @@
+defmodule MvWeb.Helpers.JoinDescriptionRendererTest do
+ @moduledoc """
+ Tests for the join-description renderer that auto-links raw URLs and Markdown
+ links while escaping all other content.
+ """
+ use ExUnit.Case, async: true
+ use ExUnitProperties
+
+ alias MvWeb.Helpers.JoinDescriptionRenderer
+
+ defp html(value) do
+ value
+ |> JoinDescriptionRenderer.render()
+ |> Phoenix.HTML.safe_to_string()
+ end
+
+ describe "render/1" do
+ test "converts a raw URL to an anchor tag" do
+ result = html("Akzeptiere https://example.com/dsgvo")
+
+ assert result =~ ~s("
+ assert result =~ "Akzeptiere "
+ end
+
+ test "converts Markdown [text](url) to an anchor tag with the link text" do
+ result = html("[Datenschutzerklärung](https://example.com/dsgvo)")
+
+ assert result =~ ~s(Datenschutzerklärung"
+ end
+
+ test "returns an empty safe string for nil input" do
+ assert JoinDescriptionRenderer.render(nil) == {:safe, ""}
+ end
+
+ test "escapes arbitrary HTML in non-link text" do
+ result = html("")
+
+ refute result =~ "