diff --git a/lib/mv_web/live/member_live/index.ex b/lib/mv_web/live/member_live/index.ex index f9d8aa1..8857298 100644 --- a/lib/mv_web/live/member_live/index.ex +++ b/lib/mv_web/live/member_live/index.ex @@ -668,7 +668,7 @@ defmodule MvWeb.MemberLive.Index do query end - defp load_custom_field_values(query, custom_field_ids) when length(custom_field_ids) > 0 do + defp load_custom_field_values(query, custom_field_ids) do # Filter custom field values at the database level using Ash relationship query # This ensures only visible custom field values are loaded custom_field_values_query = diff --git a/test/membership/fuzzy_search_test.exs b/test/membership/fuzzy_search_test.exs index 6ec582b..19286df 100644 --- a/test/membership/fuzzy_search_test.exs +++ b/test/membership/fuzzy_search_test.exs @@ -69,7 +69,7 @@ defmodule Mv.Membership.FuzzySearchTest do ids = Enum.map(result, & &1.id) assert thomas.id in ids refute jane.id in ids - assert length(ids) >= 1 + assert not Enum.empty?(ids) end test "empty query returns all members" do diff --git a/test/seeds_test.exs b/test/seeds_test.exs index 6d29760..b4d887c 100644 --- a/test/seeds_test.exs +++ b/test/seeds_test.exs @@ -11,9 +11,9 @@ defmodule Mv.SeedsTest do {:ok, members} = Ash.read(Mv.Membership.Member) {:ok, custom_fields} = Ash.read(Mv.Membership.CustomField) - assert length(users) > 0, "Seeds should create at least one user" - assert length(members) > 0, "Seeds should create at least one member" - assert length(custom_fields) > 0, "Seeds should create at least one custom field" + assert not Enum.empty?(users), "Seeds should create at least one user" + assert not Enum.empty?(members), "Seeds should create at least one member" + assert not Enum.empty?(custom_fields), "Seeds should create at least one custom field" end test "can be run multiple times (idempotent)" do