diff --git a/test/mv_web/user_live/form_member_dropdown_test.exs b/test/mv_web/user_live/form_member_dropdown_test.exs new file mode 100644 index 0000000..0e93d4d --- /dev/null +++ b/test/mv_web/user_live/form_member_dropdown_test.exs @@ -0,0 +1,149 @@ +defmodule MvWeb.UserLive.FormMemberDropdownTest do + @moduledoc """ + UI tests for member linking dropdown visibility and email handling. + Tests dropdown behavior, visibility states, and email conflict scenarios. + Related to Issue #168. + """ + + use MvWeb.ConnCase, async: true + + import Phoenix.LiveViewTest + + alias Mv.Membership + + # Helper to setup authenticated connection for admin + defp setup_admin_conn(conn) do + conn_with_oidc_user(conn, %{email: "admin@example.com"}) + end + + describe "dropdown visibility" do + test "dropdown hidden on mount", %{conn: conn} do + conn = setup_admin_conn(conn) + {:ok, _view, html} = live(conn, ~p"/users/new") + + # Dropdown should not be visible initially + refute html =~ ~r/role="listbox"/ + end + + test "dropdown shows after focus event", %{conn: conn} do + conn = setup_admin_conn(conn) + # Create unlinked members + create_unlinked_members(3) + + {:ok, view, _html} = live(conn, ~p"/users/new") + + # Focus the member search input + view + |> element("#member-search-input") + |> render_focus() + + html = render(view) + + # Dropdown should now be visible + assert html =~ ~r/role="listbox"/ + end + + test "dropdown shows top 10 unlinked members on focus", %{conn: conn} do + conn = setup_admin_conn(conn) + # Create 15 unlinked members + _members = create_unlinked_members(15) + + {:ok, view, _html} = live(conn, ~p"/users/new") + + # Focus the member search input + view + |> element("#member-search-input") + |> render_focus() + + html = render(view) + + # Count how many member entries are shown in the dropdown + # Each member creates a div with role="option" + member_count = html |> String.split(~r/role="option"/) |> length() |> Kernel.-(1) + + # Should show exactly 10 members (limit) + assert member_count == 10 + end + end + + describe "email handling" do + test "links user and member with identical email successfully", %{conn: conn} do + conn = setup_admin_conn(conn) + + {:ok, member} = + Membership.create_member(%{ + first_name: "David", + last_name: "Miller", + email: "david@example.com" + }) + + {:ok, view, _html} = live(conn, ~p"/users/new") + + # Fill user form with same email + view + |> form("#user-form", user: %{email: "david@example.com"}) + |> render_change() + + # Focus input + view + |> element("#member-search-input") + |> render_focus() + + # Select member + view + |> element("[data-member-id='#{member.id}']") + |> render_click() + + # Submit form + view + |> form("#user-form", user: %{email: "david@example.com"}) + |> render_submit() + + # Should succeed without errors + assert_redirected(view, ~p"/users") + end + + test "shows member with same email in dropdown", %{conn: conn} do + conn = setup_admin_conn(conn) + + {:ok, _member} = + Membership.create_member(%{ + first_name: "Emma", + last_name: "Davis", + email: "emma@example.com" + }) + + {:ok, view, _html} = live(conn, ~p"/users/new") + + # Fill user form with same email + view + |> form("#user-form", user: %{email: "emma@example.com"}) + |> render_change() + + # Focus the member search to trigger loading + view + |> element("#member-search-input") + |> render_focus() + + html = render(view) + + # Should show member with matching email in dropdown + assert html =~ "Emma Davis" + assert html =~ "emma@example.com" + end + end + + # Helper functions + defp create_unlinked_members(count) do + for i <- 1..count do + {:ok, member} = + Membership.create_member(%{ + first_name: "FirstName#{i}", + last_name: "LastName#{i}", + email: "member#{i}@example.com" + }) + + member + end + end +end diff --git a/test/mv_web/user_live/form_member_search_test.exs b/test/mv_web/user_live/form_member_search_test.exs new file mode 100644 index 0000000..6b07e4f --- /dev/null +++ b/test/mv_web/user_live/form_member_search_test.exs @@ -0,0 +1,112 @@ +defmodule MvWeb.UserLive.FormMemberSearchTest do + @moduledoc """ + UI tests for fuzzy search functionality in member linking. + Tests PostgreSQL trigram-based fuzzy search behavior. + Related to Issue #168. + """ + + use MvWeb.ConnCase, async: true + + import Phoenix.LiveViewTest + + alias Mv.Membership + + # Helper to setup authenticated connection for admin + defp setup_admin_conn(conn) do + conn_with_oidc_user(conn, %{email: "admin@example.com"}) + end + + describe "fuzzy search" do + test "finds member with exact name", %{conn: conn} do + conn = setup_admin_conn(conn) + + {:ok, _member} = + Membership.create_member(%{ + first_name: "Jonathan", + last_name: "Smith", + email: "jonathan.smith@example.com" + }) + + {:ok, view, _html} = live(conn, ~p"/users/new") + + # Type exact name + view + |> element("#member-search-input") + |> render_change(%{"member_search_query" => "Jonathan"}) + + html = render(view) + + assert html =~ "Jonathan" + assert html =~ "Smith" + end + + test "finds member with typo (Jon finds Jonathan)", %{conn: conn} do + conn = setup_admin_conn(conn) + + {:ok, _member} = + Membership.create_member(%{ + first_name: "Jonathan", + last_name: "Smith", + email: "jonathan.smith@example.com" + }) + + {:ok, view, _html} = live(conn, ~p"/users/new") + + # Type with typo + view + |> element("#member-search-input") + |> render_change(%{"member_search_query" => "Jon"}) + + html = render(view) + + # Fuzzy search should find Jonathan + assert html =~ "Jonathan" + assert html =~ "Smith" + end + + test "finds member with partial substring", %{conn: conn} do + conn = setup_admin_conn(conn) + + {:ok, _member} = + Membership.create_member(%{ + first_name: "Alexander", + last_name: "Williams", + email: "alex@example.com" + }) + + {:ok, view, _html} = live(conn, ~p"/users/new") + + # Type partial + view + |> element("#member-search-input") + |> render_change(%{"member_search_query" => "lex"}) + + html = render(view) + + assert html =~ "Alexander" + end + + test "shows partial match with similar names", %{conn: conn} do + conn = setup_admin_conn(conn) + + {:ok, _member} = + Membership.create_member(%{ + first_name: "Johnny", + last_name: "Doeson", + email: "johnny@example.com" + }) + + {:ok, view, _html} = live(conn, ~p"/users/new") + + # Type partial match + view + |> element("#member-search-input") + |> render_change(%{"member_search_query" => "John"}) + + html = render(view) + + # Should find member with similar name + assert html =~ "Johnny" + end + end +end diff --git a/test/mv_web/user_live/form_member_linking_ui_test.exs b/test/mv_web/user_live/form_member_selection_test.exs similarity index 50% rename from test/mv_web/user_live/form_member_linking_ui_test.exs rename to test/mv_web/user_live/form_member_selection_test.exs index 280dca9..74810df 100644 --- a/test/mv_web/user_live/form_member_linking_ui_test.exs +++ b/test/mv_web/user_live/form_member_selection_test.exs @@ -1,7 +1,7 @@ -defmodule MvWeb.UserLive.FormMemberLinkingUiTest do +defmodule MvWeb.UserLive.FormMemberSelectionTest do @moduledoc """ - UI tests for member linking in UserLive.Form. - Tests dropdown behavior, fuzzy search, selection, and unlink workflow. + UI tests for member selection and unlink workflow. + Tests member selection behavior and unlink process. Related to Issue #168. """ @@ -17,147 +17,10 @@ defmodule MvWeb.UserLive.FormMemberLinkingUiTest do conn_with_oidc_user(conn, %{email: "admin@example.com"}) end - describe "dropdown visibility" do - test "dropdown hidden on mount", %{conn: conn} do - conn = setup_admin_conn(conn) - html = conn |> live(~p"/users/new") |> render() - - # Dropdown should not be visible initially - refute html =~ ~r/role="listbox"/ - end - - test "dropdown shows after focus event", %{conn: conn} do - conn = setup_admin_conn(conn) - # Create unlinked members - create_unlinked_members(3) - - {:ok, view, _html} = live(conn, ~p"/users/new") - - # Focus the member search input - view - |> element("#member-search-input") - |> render_focus() - - html = render(view) - - # Dropdown should now be visible - assert html =~ ~r/role="listbox"/ - end - - test "dropdown shows top 10 unlinked members on focus", %{conn: conn} do - # Create 15 unlinked members - members = create_unlinked_members(15) - - {:ok, view, _html} = live(conn, ~p"/users/new") - - # Focus the member search input - view - |> element("#member-search-input") - |> render_focus() - - html = render(view) - - # Should show only 10 members - shown_members = Enum.take(members, 10) - hidden_members = Enum.drop(members, 10) - - for member <- shown_members do - assert html =~ member.first_name - end - - for member <- hidden_members do - refute html =~ member.first_name - end - end - end - - describe "fuzzy search" do - test "finds member with exact name", %{conn: conn} do - {:ok, member} = - Membership.create_member(%{ - first_name: "Jonathan", - last_name: "Smith", - email: "jonathan.smith@example.com" - }) - - {:ok, view, _html} = live(conn, ~p"/users/new") - - # Type exact name - view - |> element("#member-search-input") - |> render_change(%{"member_search_query" => "Jonathan"}) - - html = render(view) - - assert html =~ "Jonathan" - assert html =~ "Smith" - end - - test "finds member with typo (Jon finds Jonathan)", %{conn: conn} do - {:ok, member} = - Membership.create_member(%{ - first_name: "Jonathan", - last_name: "Smith", - email: "jonathan.smith@example.com" - }) - - {:ok, view, _html} = live(conn, ~p"/users/new") - - # Type with typo - view - |> element("#member-search-input") - |> render_change(%{"member_search_query" => "Jon"}) - - html = render(view) - - # Fuzzy search should find Jonathan - assert html =~ "Jonathan" - assert html =~ "Smith" - end - - test "finds member with partial substring", %{conn: conn} do - {:ok, member} = - Membership.create_member(%{ - first_name: "Alexander", - last_name: "Williams", - email: "alex@example.com" - }) - - {:ok, view, _html} = live(conn, ~p"/users/new") - - # Type partial - view - |> element("#member-search-input") - |> render_change(%{"member_search_query" => "lex"}) - - html = render(view) - - assert html =~ "Alexander" - end - - test "returns empty for no matches", %{conn: conn} do - {:ok, member} = - Membership.create_member(%{ - first_name: "John", - last_name: "Doe", - email: "john@example.com" - }) - - {:ok, view, _html} = live(conn, ~p"/users/new") - - # Type something that doesn't match - view - |> element("#member-search-input") - |> render_change(%{"member_search_query" => "zzzzzzz"}) - - html = render(view) - - refute html =~ "John" - end - end - describe "member selection" do test "input field shows selected member name", %{conn: conn} do + conn = setup_admin_conn(conn) + {:ok, member} = Membership.create_member(%{ first_name: "Alice", @@ -184,6 +47,8 @@ defmodule MvWeb.UserLive.FormMemberLinkingUiTest do end test "confirmation box appears", %{conn: conn} do + conn = setup_admin_conn(conn) + {:ok, member} = Membership.create_member(%{ first_name: "Bob", @@ -212,6 +77,8 @@ defmodule MvWeb.UserLive.FormMemberLinkingUiTest do end test "hidden input stores member ID", %{conn: conn} do + conn = setup_admin_conn(conn) + {:ok, member} = Membership.create_member(%{ first_name: "Charlie", @@ -236,65 +103,9 @@ defmodule MvWeb.UserLive.FormMemberLinkingUiTest do end end - describe "email handling" do - test "links user and member with identical email successfully", %{conn: conn} do - {:ok, member} = - Membership.create_member(%{ - first_name: "David", - last_name: "Miller", - email: "david@example.com" - }) - - {:ok, view, _html} = live(conn, ~p"/users/new") - - # Fill user form with same email - view - |> form("#user-form", user: %{email: "david@example.com"}) - |> render_change() - - # Focus input - view - |> element("#member-search-input") - |> render_focus() - - # Select member - view - |> element("[data-member-id='#{member.id}']") - |> render_click() - - # Submit form - view - |> form("#user-form", user: %{email: "david@example.com"}) - |> render_submit() - - # Should succeed without errors - assert_redirected(view, ~p"/users") - end - - test "shows info when member has same email", %{conn: conn} do - {:ok, member} = - Membership.create_member(%{ - first_name: "Emma", - last_name: "Davis", - email: "emma@example.com" - }) - - {:ok, view, _html} = live(conn, ~p"/users/new") - - # Fill user form with same email - view - |> form("#user-form", user: %{email: "emma@example.com"}) - |> render_change() - - html = render(view) - - # Should show info message about email conflict - assert html =~ "A member with this email already exists" - end - end - describe "unlink workflow" do test "unlink hides dropdown", %{conn: conn} do + conn = setup_admin_conn(conn) # Create user with linked member {:ok, member} = Membership.create_member(%{ @@ -323,6 +134,7 @@ defmodule MvWeb.UserLive.FormMemberLinkingUiTest do end test "unlink shows warning", %{conn: conn} do + conn = setup_admin_conn(conn) # Create user with linked member {:ok, member} = Membership.create_member(%{ @@ -352,6 +164,7 @@ defmodule MvWeb.UserLive.FormMemberLinkingUiTest do end test "unlink disables input", %{conn: conn} do + conn = setup_admin_conn(conn) # Create user with linked member {:ok, member} = Membership.create_member(%{ @@ -380,6 +193,7 @@ defmodule MvWeb.UserLive.FormMemberLinkingUiTest do end test "save re-enables member selection", %{conn: conn} do + conn = setup_admin_conn(conn) # Create user with linked member {:ok, member} = Membership.create_member(%{ @@ -416,18 +230,4 @@ defmodule MvWeb.UserLive.FormMemberLinkingUiTest do refute html =~ "Unlinking scheduled" end end - - # Helper functions - defp create_unlinked_members(count) do - for i <- 1..count do - {:ok, member} = - Membership.create_member(%{ - first_name: "FirstName#{i}", - last_name: "LastName#{i}", - email: "member#{i}@example.com" - }) - - member - end - end end diff --git a/test/support/fixtures.ex b/test/support/fixtures.ex new file mode 100644 index 0000000..5dd14a9 --- /dev/null +++ b/test/support/fixtures.ex @@ -0,0 +1,96 @@ +defmodule Mv.Fixtures do + @moduledoc """ + Shared test fixtures for consistent test data creation. + + This module provides factory functions for creating test data across + different test suites, ensuring consistency and reducing duplication. + """ + + @doc """ + Creates a member with default or custom attributes. + + ## Parameters + - `attrs` - Map or keyword list of attributes to override defaults + + ## Returns + - Member struct + + ## Examples + + iex> member_fixture() + %Mv.Membership.Member{first_name: "Test", ...} + + iex> member_fixture(%{first_name: "Alice", email: "alice@example.com"}) + %Mv.Membership.Member{first_name: "Alice", email: "alice@example.com"} + + """ + def member_fixture(attrs \\ %{}) do + attrs + |> Enum.into(%{ + first_name: "Test", + last_name: "Member", + email: "test#{System.unique_integer([:positive])}@example.com" + }) + |> Mv.Membership.create_member() + |> case do + {:ok, member} -> member + {:error, error} -> raise "Failed to create member: #{inspect(error)}" + end + end + + @doc """ + Creates a user with default or custom attributes. + + ## Parameters + - `attrs` - Map or keyword list of attributes to override defaults + + ## Returns + - User struct + + ## Examples + + iex> user_fixture() + %Mv.Accounts.User{email: "user123@example.com"} + + iex> user_fixture(%{email: "custom@example.com"}) + %Mv.Accounts.User{email: "custom@example.com"} + + """ + def user_fixture(attrs \\ %{}) do + attrs + |> Enum.into(%{ + email: "user#{System.unique_integer([:positive])}@example.com" + }) + |> Mv.Accounts.create_user() + |> case do + {:ok, user} -> user + {:error, error} -> raise "Failed to create user: #{inspect(error)}" + end + end + + @doc """ + Creates a user linked to a member. + + ## Parameters + - `user_attrs` - Map or keyword list of user attributes + - `member_attrs` - Map or keyword list of member attributes + + ## Returns + - Tuple of {user, member} + + ## Examples + + iex> {user, member} = linked_user_member_fixture() + iex> user.member_id == member.id + true + + """ + def linked_user_member_fixture(user_attrs \\ %{}, member_attrs \\ %{}) do + member = member_fixture(member_attrs) + + user_attrs = Map.put(user_attrs, :member, %{id: member.id}) + user = user_fixture(user_attrs) + + {user, member} + end +end