From c3ad8894b09fe8a906dbfc2d865c2cd579850e5f Mon Sep 17 00:00:00 2001 From: Simon Date: Wed, 28 Jan 2026 14:47:30 +0100 Subject: [PATCH] refactor: implement more review comments --- test/mv_web/user_live/form_test.exs | 3 ++- test/mv_web/user_live/index_test.exs | 15 +++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/test/mv_web/user_live/form_test.exs b/test/mv_web/user_live/form_test.exs index ad99337..842dc98 100644 --- a/test/mv_web/user_live/form_test.exs +++ b/test/mv_web/user_live/form_test.exs @@ -124,7 +124,8 @@ defmodule MvWeb.UserLive.FormTest do system_actor = Mv.Helpers.SystemActor.get_system_actor() updated_user = Ash.reload!(user, domain: Mv.Accounts, actor: system_actor) assert updated_user.hashed_password != original_password - assert String.starts_with?(updated_user.hashed_password, "$2b$") + assert not is_nil(updated_user.hashed_password) + assert updated_user.hashed_password != "" end end diff --git a/test/mv_web/user_live/index_test.exs b/test/mv_web/user_live/index_test.exs index 92f11a1..1b470c1 100644 --- a/test/mv_web/user_live/index_test.exs +++ b/test/mv_web/user_live/index_test.exs @@ -98,14 +98,12 @@ defmodule MvWeb.UserLive.IndexTest do |> has_element?() # Select second user - html = view |> element("input[type='checkbox'][name='#{user2.id}']") |> render_click() + view |> element("input[type='checkbox'][name='#{user2.id}']") |> render_click() # Now select all should be automatically checked (all individual users are selected) - # Note: This test might need adjustment based on actual implementation - # The logic depends on whether authenticated user is included in the count - assert html =~ "Email" - assert html =~ to_string(user1.email) - assert html =~ to_string(user2.email) + assert view + |> element("input[type='checkbox'][name='select_all'][checked]") + |> has_element?() end end @@ -118,11 +116,12 @@ defmodule MvWeb.UserLive.IndexTest do # Confirm user is displayed assert render(view) =~ "delete-me@example.com" - # Click the first delete button to test the functionality + # Click the delete button (phx-click="delete" event) view |> element("tbody tr:first-child a[data-confirm]") |> render_click() - # The page should still render (basic functionality test) + # Verify user was actually deleted (should not appear in HTML anymore) html = render(view) + refute html =~ "delete-me@example.com" # Table header should still be there assert html =~ "Email" end