From d07f1984cd84794ea948f9f0225a593766609fcd Mon Sep 17 00:00:00 2001
From: Moritz <moritz.m@local-it.org>
Date: Wed, 21 Jan 2026 08:35:34 +0100
Subject: [PATCH] Move require Logger to module level

Move require Logger statements from function/case level to module level
for better code organization and consistency with Elixir best practices
---
 lib/membership/member.ex                                  | 8 --------
 .../user/validations/email_not_used_by_other_member.ex    | 4 ++--
 .../member/validations/email_not_used_by_other_user.ex    | 4 ++--
 3 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/lib/membership/member.ex b/lib/membership/member.ex
index 828e82e..cebcc5c 100644
--- a/lib/membership/member.ex
+++ b/lib/membership/member.ex
@@ -203,8 +203,6 @@ defmodule Mv.Membership.Member do
                      {:ok, member, notifications}
 
                    {:error, reason} ->
-                     require Logger
-
                      Logger.warning(
                        "Failed to regenerate cycles for member #{member.id}: #{inspect(reason)}"
                      )
@@ -962,8 +960,6 @@ defmodule Mv.Membership.Member do
 
   # Runs cycle generation synchronously (for test environment)
   defp handle_cycle_generation_sync(member, initiator) do
-    require Logger
-
     case Mv.MembershipFees.CycleGenerator.generate_cycles_for_member(
            member.id,
            today: Date.utc_today(),
@@ -1015,8 +1011,6 @@ defmodule Mv.Membership.Member do
          sync: sync?,
          initiator: initiator
        ) do
-    require Logger
-
     sync_label = if sync?, do: "", else: " (async)"
     initiator_info = get_initiator_info(initiator)
 
@@ -1030,8 +1024,6 @@ defmodule Mv.Membership.Member do
 
   # Logs cycle generation errors
   defp log_cycle_generation_error(member, reason, sync: sync?, initiator: initiator) do
-    require Logger
-
     sync_label = if sync?, do: "", else: " (async)"
     initiator_info = get_initiator_info(initiator)
 
diff --git a/lib/mv/accounts/user/validations/email_not_used_by_other_member.ex b/lib/mv/accounts/user/validations/email_not_used_by_other_member.ex
index 9f900eb..0e693e1 100644
--- a/lib/mv/accounts/user/validations/email_not_used_by_other_member.ex
+++ b/lib/mv/accounts/user/validations/email_not_used_by_other_member.ex
@@ -9,6 +9,8 @@ defmodule Mv.Accounts.User.Validations.EmailNotUsedByOtherMember do
   """
   use Ash.Resource.Validation
 
+  require Logger
+
   @doc """
   Validates email uniqueness across linked User-Member pairs.
 
@@ -92,8 +94,6 @@ defmodule Mv.Accounts.User.Validations.EmailNotUsedByOtherMember do
         {:error, field: :email, message: "is already used by another member", value: email}
 
       {:error, reason} ->
-        require Logger
-
         Logger.warning(
           "Email uniqueness validation query failed for user email '#{email}': #{inspect(reason)}. Allowing operation to proceed (fail-open)."
         )
diff --git a/lib/mv/membership/member/validations/email_not_used_by_other_user.ex b/lib/mv/membership/member/validations/email_not_used_by_other_user.ex
index 78af70c..f9fba1b 100644
--- a/lib/mv/membership/member/validations/email_not_used_by_other_user.ex
+++ b/lib/mv/membership/member/validations/email_not_used_by_other_user.ex
@@ -10,6 +10,8 @@ defmodule Mv.Membership.Member.Validations.EmailNotUsedByOtherUser do
   use Ash.Resource.Validation
   alias Mv.Helpers
 
+  require Logger
+
   @doc """
   Validates email uniqueness across linked Member-User pairs.
 
@@ -64,8 +66,6 @@ defmodule Mv.Membership.Member.Validations.EmailNotUsedByOtherUser do
         {:error, field: :email, message: "is already used by another user", value: email}
 
       {:error, reason} ->
-        require Logger
-
         Logger.warning(
           "Email uniqueness validation query failed for member email '#{email}': #{inspect(reason)}. Allowing operation to proceed (fail-open)."
         )