From d296418c8e76dedc2af640c1ca56a8f8e4ba22c4 Mon Sep 17 00:00:00 2001 From: Moritz Date: Tue, 20 Jan 2026 16:33:50 +0100 Subject: [PATCH] test: Remove outdated TODO for auto-assignment feature Auto-assignment of default membership fee type is already implemented via SetDefaultMembershipFeeType change. Test assertion is now active. --- .../membership_fee_type_integration_test.exs | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/test/membership_fees/membership_fee_type_integration_test.exs b/test/membership_fees/membership_fee_type_integration_test.exs index b70f47c..681bd02 100644 --- a/test/membership_fees/membership_fee_type_integration_test.exs +++ b/test/membership_fees/membership_fee_type_integration_test.exs @@ -158,10 +158,8 @@ defmodule Mv.MembershipFees.MembershipFeeTypeIntegrationTest do |> Ash.update!() # Create a member without explicitly setting membership_fee_type_id - # Note: This test assumes that the Member resource automatically assigns - # the default_membership_fee_type_id during creation. If this is not yet - # implemented, this test will fail initially (which is expected in TDD). - # For now, we skip this test as the auto-assignment feature is not yet implemented. + # The Member resource automatically assigns the default_membership_fee_type_id + # during creation via SetDefaultMembershipFeeType change. {:ok, member} = Ash.create(Member, %{ first_name: "Test", @@ -169,10 +167,8 @@ defmodule Mv.MembershipFees.MembershipFeeTypeIntegrationTest do email: "test.member.#{System.unique_integer([:positive])}@example.com" }) - # TODO: When auto-assignment is implemented, uncomment this assertion - # assert member.membership_fee_type_id == fee_type.id - # For now, we just verify the member was created successfully - assert %Member{} = member + # Verify that the default membership fee type was automatically assigned + assert member.membership_fee_type_id == fee_type.id end test "include_joining_cycle is used during cycle generation" do